From patchwork Fri Mar 9 18:56:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kanavin X-Patchwork-Id: 131243 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp1345800lja; Fri, 9 Mar 2018 11:07:14 -0800 (PST) X-Google-Smtp-Source: AG47ELvOUrYTAvlMRysg6BtMslO9E1t7zLjDOMcj0nYUVw6A7CE5HPLD0WfVnbmIKk1zxihI2Gco X-Received: by 10.99.103.195 with SMTP id b186mr25026249pgc.446.1520622433935; Fri, 09 Mar 2018 11:07:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520622433; cv=none; d=google.com; s=arc-20160816; b=0FSrWWk0BG+enbUvb1vPClIMpEFB7IUnMmS16L1aNUaM9fOtSfLtSTHkr2HRK45VDi 1Jfb/+ZQOgHm7ACEHCTqWL3QgwnRXTbn4khAROhhc5koKNoXd3N0T3NkG3XjpTf52/Mm j4uIIJmmzVWoOmDbmqUc4jq304AGh95SYJsAmFgowKLLlSHRz8O9YntqvyeSGs3m2I3u xkGxBmCkyW8ubLKt+lhpdPj+TsiDbM1vzW7Bh5OriF6ppqsOu2+8ok90KMwbE+afUoy9 Th3yO9qW2Xr+LAX8cl501tC31ow1z6++JyPTWO2V+FAOqTZaV+SeMOI0YJTpq/d2B5Fk 4P7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to:arc-authentication-results; bh=pR5hK0z9DFE48s1/xrtTEtPgFA1zk8raJvDpfXzwUNk=; b=Fflzq6JtXCK3sSlaAoOUVXEYDWv1Fwg0FmAQH3RlEL4J/srEToXSR+aFxbAUaf1i61 cp1fwEi/xUkgRZuVdANAk2bvV8lzmLD5Vwk+TcLgOIuwms5w73SQQcrRt1w6TcygRWWp u8mLtXV9l/0abOwluA72EP4k+0Qzj/TAc2BvCBVzC1DPKA258kJYm2DwsTuW5H6lBJPF z7Yqc5Tov0ueqJuzJzVhRlX9OXxFdJxqvzwvBuHmvxuFTuYlMr5CD3HrSNpMp3gTVwo4 wf61FjoJvcA7egqD9Q2WRgWYm08NiD6wDuXkmMlDZ0+aB/AwMzk96OC1zPVupe396MpR iIYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id e4si1097692pgv.581.2018.03.09.11.07.13; Fri, 09 Mar 2018 11:07:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Received: from layers.openembedded.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 0230178A0D; Fri, 9 Mar 2018 19:03:51 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mail.openembedded.org (Postfix) with ESMTP id 09349789C5 for ; Fri, 9 Mar 2018 19:03:41 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2018 11:03:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,446,1515484800"; d="scan'208";a="32652079" Received: from kanavin-desktop.fi.intel.com ([10.237.68.161]) by FMSMGA003.fm.intel.com with ESMTP; 09 Mar 2018 11:03:41 -0800 From: Alexander Kanavin To: openembedded-core@lists.openembedded.org Date: Fri, 9 Mar 2018 20:56:13 +0200 Message-Id: <20180309185614.31113-35-alexander.kanavin@linux.intel.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180309185614.31113-1-alexander.kanavin@linux.intel.com> References: <20180309185614.31113-1-alexander.kanavin@linux.intel.com> Subject: [OE-core] [PATCH 35/36] attr: refresh patches X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org From: Ross Burton The patch tool will apply patches by default with "fuzz", which is where if the hunk context isn't present but what is there is close enough, it will force the patch in. Whilst this is useful when there's just whitespace changes, when applied to source it is possible for a patch applied with fuzz to produce broken code which still compiles (see #10450). This is obviously bad. We'd like to eventually have do_patch() rejecting any fuzz on these grounds. For that to be realistic the existing patches with fuzz need to be rebased and reviewed. Signed-off-by: Ross Burton Signed-off-by: Alexander Kanavin --- .../acl/test-fix-insufficient-quoting-of.patch | 52 +++++++++------------- 1 file changed, 22 insertions(+), 30 deletions(-) -- 2.16.1 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/recipes-support/attr/acl/test-fix-insufficient-quoting-of.patch b/meta/recipes-support/attr/acl/test-fix-insufficient-quoting-of.patch index 0b350be5634..f392465b58e 100644 --- a/meta/recipes-support/attr/acl/test-fix-insufficient-quoting-of.patch +++ b/meta/recipes-support/attr/acl/test-fix-insufficient-quoting-of.patch @@ -35,61 +35,56 @@ http://git.savannah.gnu.org/cgit/acl.git/commit/?id=e98ce8acf84d12ea67a3ac76bf63 Signed-off-by: Kamil Dudka Signed-off-by: He Zhe ---- - test/cp.test | 2 +- - test/misc.test | 6 +++--- - test/sbits-restore.test | 6 +++--- - 3 files changed, 7 insertions(+), 7 deletions(-) -diff --git a/test/cp.test b/test/cp.test -index 0867f63..a927195 100644 ---- a/test/cp.test -+++ b/test/cp.test -@@ -9,7 +9,7 @@ The cp utility should only copy ACLs if `-p' is given. +Index: acl-2.2.52/test/cp.test +=================================================================== +--- acl-2.2.52.orig/test/cp.test ++++ acl-2.2.52/test/cp.test +@@ -9,7 +9,7 @@ The cp utility should only copy ACLs if > -rw-rw-r--+ - + $ cp f g - $ ls -l g | awk -- '{ print $1 }' | sed 's/\.$//g' + $ ls -l g | awk -- '{ print $1 }' | sed 's/\\.$//g' > -rw-r--r-- - + $ rm g -diff --git a/test/misc.test b/test/misc.test -index 6e98053..29372b7 100644 ---- a/test/misc.test -+++ b/test/misc.test +Index: acl-2.2.52/test/misc.test +=================================================================== +--- acl-2.2.52.orig/test/misc.test ++++ acl-2.2.52/test/misc.test @@ -254,7 +254,7 @@ Add some users and groups Symlink in directory with default ACL? - + $ ln -s d d/l - $ ls -dl d/l | awk '{print $1}' | sed 's/\.$//g' + $ ls -dl d/l | awk '{print $1}' | sed 's/\\.$//g' > lrwxrwxrwx - + $ ls -dl -L d/l | awk '{print $1}' @@ -343,7 +343,7 @@ Remove the default ACL Reset to base entries - + $ setfacl -b d - $ ls -dl d | awk '{print $1}' | sed 's/\.$//g' + $ ls -dl d | awk '{print $1}' | sed 's/\\.$//g' > drwxr-x--- - + $ getfacl --omit-header d @@ -355,7 +355,7 @@ Reset to base entries Now, chmod should change the group_obj entry - + $ chmod 775 d - $ ls -dl d | awk '{print $1}' | sed 's/\.$//g' + $ ls -dl d | awk '{print $1}' | sed 's/\\.$//g' > drwxrwxr-x - + $ getfacl --omit-header d -diff --git a/test/sbits-restore.test b/test/sbits-restore.test -index de21340..5899b0a 100644 ---- a/test/sbits-restore.test -+++ b/test/sbits-restore.test -@@ -13,10 +13,10 @@ Ensure setting of SUID/SGID/sticky via --restore works +Index: acl-2.2.52/test/sbits-restore.test +=================================================================== +--- acl-2.2.52.orig/test/sbits-restore.test ++++ acl-2.2.52/test/sbits-restore.test +@@ -13,10 +13,10 @@ Ensure setting of SUID/SGID/sticky via - $ touch d/g $ touch d/u $ setfacl --restore d.acl @@ -103,6 +98,3 @@ index de21340..5899b0a 100644 + $ ls -dl d/g | awk '{print $1}' | sed 's/\\.$//g' > -rw-r-Sr-- $ rm -Rf d --- -1.9.1 -