From patchwork Mon Oct 7 19:38:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 175403 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp4714739ill; Mon, 7 Oct 2019 12:38:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqz8vgacI14uBg0GDzz4GN1R8eLbLq6ezekyjLMwslLF8fIzHTxBFW0xJXbhulro4N1Qg3QC X-Received: by 2002:a65:504d:: with SMTP id k13mr2211137pgo.66.1570477094237; Mon, 07 Oct 2019 12:38:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570477094; cv=none; d=google.com; s=arc-20160816; b=DntEy6rUwZy4sbKgSBUhqEmTCRhTFwm+Cmlpn68b6xGC0fcOMCs89lKBdVf0Kpr8Wg qQ8edqJtKQCMUj7wHBZFIUjeBQMReAb9LLMpHk/Pc9is6Ty4LJb1Dps+chUUn56ffIfi SGcpL/CpwTM54iSU1sN51eOWVu7W2tnVeF6y5pQvAu3JOF3BIYsbDY1wOSAx+eG5N7HD jC/TlAonFcXGBRd+q46OrmXJ5px2LUEsycFbj6j2CJ/Vc5Sf28K2Cctme3Rj/QsrneQJ HezKYSGH5pP0x0VwNoPwtBJ9x+4eh3gZrHgvlqGFZMAAhaQHtWSygWfNvj8aUpHhqDVS SHIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:delivered-to; bh=n+nPDhjyhyUWEy9+uh5PC0s+kZDncG6fpKY9bou9Y8E=; b=jl16t0Ev4h0DA///TlCPB7tqKzdeXRwFGRd8kmK17yyNPVMLJQbOve3QtfujkQaQZO FLwoDOGyibBqLAqdhc8896w2a6VrYhaT/mMtoXs8isWU0onUgrVvGvlJ4q8ErW1ybwE9 TPd80OUb80ciNOSdWeJUHwWGjwdipFiG0aOE7F3T8eapA4nTwLxiYwxTvxapVO4dnof8 bwY4RLtbyM4pa0XD5Zb//cgWK6r7V/d8KLmAH7W2hyqe9TJWlInwBJXtVS1xsUHcFZ1+ bE3PI7SAXUjhlmhm3GWp9cZ7uNnA9HQNOXX8GNviANZPV7Nj63uQuXiSs1cS4t8pHWgA sl+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=qSAoTRVe; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id h5si468963pjt.7.2019.10.07.12.38.13; Mon, 07 Oct 2019 12:38:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=qSAoTRVe; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ec2-34-214-78-129.us-west-2.compute.amazonaws.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 66E8F7E708; Mon, 7 Oct 2019 19:38:10 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mail.openembedded.org (Postfix) with ESMTP id A68FD7E468 for ; Mon, 7 Oct 2019 19:38:08 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id r3so16705985wrj.6 for ; Mon, 07 Oct 2019 12:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=ClHUq6k51nIhWQIw1R9XSpTm220SsJ1iAiBeVj3Ovk8=; b=qSAoTRVeXQTZ1VrTFC4pGZhcaQPZdRqAY9X/dpsOETxGcS1yyyzs6Pj32zlGm0BObb MQokvSQzvImUT0l/ubb/DJzELAwdGZqBKqltpwLvUj6Mh8lHwQcWvvd5ZttYw2ROCRNw 9lloapVNU069iERy34nsyr4NrOmL4APu/vQX+7hJhhv2fLgArssfb6QjGjkhGgPSM9OY HLKhpAPeOI9dI55HHwFurxdAjzbqH8E/ozn5DZsk/lJ/PR/N2PGhnWNj0y/XZiPg4ff5 gZp0lvXnDRKiObvNRA+uZIuypgop90N96RTHhywETiaEDNdyVdIyA08dcwqo6869tBPj nu0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=ClHUq6k51nIhWQIw1R9XSpTm220SsJ1iAiBeVj3Ovk8=; b=bGw/QLqIxeljfkMMjkGgoFNOWixekD+dioM0HvME7uBcdaljIqXkUAgG0VUdIOl9nE /cpWK4tP9SdT3eZSMaf6khviCLe64+6jBPPmQEJGoDdh2hiyfW4jy6+Gh8mE3iHFjnqP og0cbqLUkT2bE1TYGVGe5SjTbk+Y2XbMIRatI3Bhgc7VFagygcLjrb+4wzYBFpf+YeTo wvQug7wsssxWlwWDoX+UZi/GuZ+aHK+/XKa5y+Jp7nLFs6sz/vZ4SXMvciTBj0oTeEjc MaPUAQmhvQOZzQgs2hAw9GNSkjXjnurYz2FvcK7vKQPRQs8LCqpMtpHz2adAgukjb0h/ Vnlw== X-Gm-Message-State: APjAAAVu2MWyvAVr9kCwi/vlndscK8mbyqBhT3W6fWq3/hiRP/+npLFj 5ElhThcMcd82+K+jY6CReafkiigQfOI= X-Received: by 2002:adf:ea0d:: with SMTP id q13mr939214wrm.111.1570477088993; Mon, 07 Oct 2019 12:38:08 -0700 (PDT) Received: from flashheart.burtonini.com (35.106.2.81.in-addr.arpa. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id a10sm17356942wrm.52.2019.10.07.12.38.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2019 12:38:07 -0700 (PDT) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Mon, 7 Oct 2019 20:38:04 +0100 Message-Id: <20191007193805.13219-1-ross.burton@intel.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [OE-core] [PATCH 1/2] systemd: don't install systemd-hwdb-update.service X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org This service file is designed to do first-boot initialisation of the udev hwdb database, but the condition logic to fire it is suboptimal: it can fire if not needed, and can also not fire if needed. Specifically it will always fire on first boot, even though as part of rootfs generation we build the hwdb database. On slow machines this can take a significant amount of time, the pathological case being qemumips where the service can time out after 90 seconds of processing. Other distributions have also noticed this problem (specifically, at least Debian and Clear) and solve it by using traditional postinst scripts to generate the hwdb (which we already do) and deleting the service file (which we don't). Finish the fix and improve boot times across all boards by deleting the service file. [ YOCTO #13581 ] Signed-off-by: Ross Burton --- meta/recipes-core/systemd/systemd_243.bb | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- 2.20.1 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/recipes-core/systemd/systemd_243.bb b/meta/recipes-core/systemd/systemd_243.bb index b9097593f17..a4a744ce9ba 100644 --- a/meta/recipes-core/systemd/systemd_243.bb +++ b/meta/recipes-core/systemd/systemd_243.bb @@ -297,13 +297,10 @@ do_install() { # install default policy for presets # https://www.freedesktop.org/wiki/Software/systemd/Preset/#howto install -Dm 0644 ${WORKDIR}/99-default.preset ${D}${systemd_unitdir}/system-preset/99-default.preset -} -do_install_append () { - # Mips qemu is extremely slow, allow more time for the hwdb update - # This is a workaround until https://github.com/systemd/systemd/issues/13581 is resolved - [ ! -e ${D}${systemd_unitdir}/system/systemd-hwdb-update.service ] || - sed -i -e s#TimeoutSec=90s#TimeoutSec=180s# ${D}${systemd_unitdir}/system/systemd-hwdb-update.service + # We use package postinsts for the hwdb update, as the update service is + # easily triggered for no reason and will slow down boots. + find ${D} -name systemd-hwdb-update.service -delete } python populate_packages_prepend (){