From patchwork Thu Oct 12 20:44:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Denys Dmytriyenko X-Patchwork-Id: 115676 Delivered-To: patch@linaro.org Received: by 10.80.163.170 with SMTP id s39csp5505edb; Thu, 12 Oct 2017 13:45:10 -0700 (PDT) X-Google-Smtp-Source: AOwi7QDlBqpwpV1JPN5H38vlj+dockh6rkJhP/Ggzmr++eTPzH7Z8BEJF7XwRbdGvbege3R/NgSG X-Received: by 10.98.215.66 with SMTP id v2mr3213783pfl.24.1507841110747; Thu, 12 Oct 2017 13:45:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507841110; cv=none; d=google.com; s=arc-20160816; b=Gda2Sq5TUl55+TezJYdX7wuVtYEe7eU+CsTST82Yo0xqOl4IK3gyzjpuNVDkV0eSgo fFKlTkc3Vb7ElOBCD0aQaQHFDevCDMQ5ykePt+3C4mnUkKLc7gwSsPOJv1nUWcd8zba1 kI37IzG/vaf+71FZeeT/7YwtAcGFBZWCdpIrpmQbGTXJo6FcnLS2Doiy4ATEFacHB1jR kMscLkOtbQzvwHk/II6HHxBApLcIIgLSLOPrhf0wxbDoutojWYjBggTQLjtinG67Htt5 sM6zFNOUMAszrecwSY/+eggg5GwJWLMKq88u0wghrwUn0CpCFIzWEfIVIfUuTfi4U0Ac Oxag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:message-id:date:to:from:delivered-to :arc-authentication-results; bh=iSZ29+dwJaLKNIuZevF+x1bEks/ZKrgSf3KcPXSidO4=; b=wdmUB8EYtvBHLNErk5T7AnUe85Z1FCpMNcqs3Fks1NmC8aeAz/+2e2iMR79dFAEsdA z4JG4HClovV7HqKr75kpJEjP5PEjnTuyjH/6V5pR3YZl2fdShZ7yDMjIFxByOQivUM8C Z6d9ppst+qbG76TxsmJSoyB6OiS5EVYQkv9U5xaTTUkm1U6G4++1VU+VQm0oynJdRqXY GvQqizh8VBGmBVOe4jsXexA+Y68yhTtilUbTrt7s5oosXj58Vxe9VVXdHQn+vCD/Vbq+ qPzvwxr2VVSJXbkx/1nRhchhLQcwMDiR+R91OcKUh6t6knrY0Ufo6ZJ51QHmcY5kULhQ fvSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-devel-bounces@lists.openembedded.org Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id z130si11412090pgz.199.2017.10.12.13.45.06; Thu, 12 Oct 2017 13:45:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of openembedded-devel-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-devel-bounces@lists.openembedded.org Received: from review.yoctoproject.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id C32DC6E5FC; Thu, 12 Oct 2017 20:44:58 +0000 (UTC) X-Original-To: openembedded-devel@lists.openembedded.org Delivered-To: openembedded-devel@lists.openembedded.org Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.17]) by mail.openembedded.org (Postfix) with ESMTP id D6C3C607A5 for ; Thu, 12 Oct 2017 20:44:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id 99B2D20AD5; Thu, 12 Oct 2017 20:44:57 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo03-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ntVs4IIhjbCb; Thu, 12 Oct 2017 20:44:57 +0000 (UTC) Received: from mail.denix.org (pool-100-15-85-143.washdc.fios.verizon.net [100.15.85.143]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id 78D672006B; Thu, 12 Oct 2017 20:44:56 +0000 (UTC) Received: from gimli.denix (gimli [192.168.0.6]) by mail.denix.org (Postfix) with ESMTP id 03E791626E6; Thu, 12 Oct 2017 16:44:56 -0400 (EDT) From: Denys Dmytriyenko To: openembedded-devel@lists.openembedded.org Date: Thu, 12 Oct 2017 16:44:47 -0400 Message-Id: <1507841087-145584-1-git-send-email-denis@denix.org> X-Mailer: git-send-email 2.7.4 Cc: Denys Dmytriyenko Subject: [oe] [meta-qt5][PATCH] qt5-ptest.inc: fix qtxmlpatterns:do_install_ptest out-of-order call X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-devel-bounces@lists.openembedded.org Errors-To: openembedded-devel-bounces@lists.openembedded.org From: Denys Dmytriyenko ptest.bbclass provides a set of standard do_*_ptest_base tasks. Each of them calls a corresponding regular do_*_ptest task, that components are supposed to override for own implementation. When PTEST_ENABLED is not set, an anonymous python function removes all do_*_ptest_base tasks from the queue. qt5-ptest.inc adds a special case for do_populate_sysroot and re-arranges the order or ptest tasks due to that. But, unfortunately, do_install_ptest was added directly, not do_install_ptest_base, hence when "ptest" is disabled and all other do_*_ptest_base tasks are removed, this one do_install_ptest task is left w/o dependencies and gets scheduled for execution very early on, even before pseudo-native gets built and stages "fakeroot" functionality. The fix is to add do_install_ptest_base task, which calls do_install_ptest only when "ptest" is enabled. Signed-off-by: Denys Dmytriyenko --- recipes-qt/qt5/qt5-ptest.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel diff --git a/recipes-qt/qt5/qt5-ptest.inc b/recipes-qt/qt5/qt5-ptest.inc index 4844878..480a06d 100644 --- a/recipes-qt/qt5/qt5-ptest.inc +++ b/recipes-qt/qt5/qt5-ptest.inc @@ -5,7 +5,7 @@ inherit ptest addtask do_populate_sysroot after do_install before do_compile_ptest_base deltask do_compile_ptest_base addtask do_compile_ptest_base after do_populate_sysroot before do_install_ptest -addtask do_install_ptest after do_compile_ptest_base before do_package +addtask do_install_ptest_base after do_compile_ptest_base before do_package do_compile_ptest() { cd ${S}/tests