From patchwork Tue Mar 26 04:12:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 15639 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 840EE23E64 for ; Tue, 26 Mar 2013 04:24:08 +0000 (UTC) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by fiordland.canonical.com (Postfix) with ESMTP id 3CC4AA19751 for ; Tue, 26 Mar 2013 04:24:08 +0000 (UTC) Received: by mail-vc0-f171.google.com with SMTP id ha11so5213786vcb.16 for ; Mon, 25 Mar 2013 21:24:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=PCy+IR26d43OqQn85RLmoAC+oZN8UBGkDIcACGX24XI=; b=RJNXN7bm2SjVDPpEA12b7+fY4b3OWsXzYLA3whTJn+9j4jdR1yo3mOBDZON5tUfAHD fyOIJAb2b9xd16kOsjf9qJsIy1ZaTTqRVQ16Ou3ZxTRCYUlIsnzsmmhxDNdt+hYxX25V n9A9IA1JnviIzJUsc7h5nmg+vzPdfF6Gjl/+J4jKtB6MhE3rxuJO8ddCPzvmPsBedoOw gFq3ccErPgJ9xiG7W5tN+HIWb20nVd0yW4ACTNvJyx2IKP8O5hFBnZNZ/58J+itvV0aL nPdRA2LOQ6CEvzVX1aW+hdPl17DANrKTCy/fNrIYYUBnYELO0hxJp9g6zr57pxSBEX/U UJgg== X-Received: by 10.220.150.74 with SMTP id x10mr18771273vcv.68.1364271847742; Mon, 25 Mar 2013 21:24:07 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.59.4.204 with SMTP id cg12csp54428ved; Mon, 25 Mar 2013 21:24:07 -0700 (PDT) X-Received: by 10.68.52.69 with SMTP id r5mr20908698pbo.145.1364271846756; Mon, 25 Mar 2013 21:24:06 -0700 (PDT) Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) by mx.google.com with ESMTPS id td2si16434376pac.166.2013.03.25.21.24.06 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 25 Mar 2013 21:24:06 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.220.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pa0-f50.google.com with SMTP id bg2so1389119pad.9 for ; Mon, 25 Mar 2013 21:24:06 -0700 (PDT) X-Received: by 10.68.227.97 with SMTP id rz1mr20513731pbc.45.1364271846309; Mon, 25 Mar 2013 21:24:06 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id mz8sm15894438pbc.9.2013.03.25.21.24.03 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 25 Mar 2013 21:24:05 -0700 (PDT) From: Sachin Kamat To: rtc-linux@googlegroups.com Cc: a.zummo@towertech.it, akpm@linux-foundation.org, sachin.kamat@linaro.org, patches@linaro.org, Laxman dewangan Subject: [PATCH v2 1/5] drivers/rtc/rtc-tps6586x.c: Remove incorrect use of rtc_device_unregister Date: Tue, 26 Mar 2013 09:42:38 +0530 Message-Id: <1364271162-18141-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1364271162-18141-1-git-send-email-sachin.kamat@linaro.org> References: <1364271162-18141-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQnJCUfCh8njDTilqbgjdoT4zJrsT12XVMjBnncqJHUQpqwbZvHNMXtqeXXGVScuQzwJ5K2K Device managed functions do not need explicit freeing/unregistering. Moreover in this case it was done using non-device managed function which is incorrect. Hence remove it. Signed-off-by: Sachin Kamat Cc: Laxman dewangan --- drivers/rtc/rtc-tps6586x.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c index badfea4..459c2ff 100644 --- a/drivers/rtc/rtc-tps6586x.c +++ b/drivers/rtc/rtc-tps6586x.c @@ -289,15 +289,12 @@ static int tps6586x_rtc_probe(struct platform_device *pdev) if (ret < 0) { dev_err(&pdev->dev, "request IRQ(%d) failed with ret %d\n", rtc->irq, ret); - goto fail_req_irq; + goto fail_rtc_register; } disable_irq(rtc->irq); device_set_wakeup_capable(&pdev->dev, 1); return 0; -fail_req_irq: - rtc_device_unregister(rtc->rtc); - fail_rtc_register: tps6586x_update(tps_dev, RTC_CTRL, 0, RTC_ENABLE | OSC_SRC_SEL | PRE_BYPASS | CL_SEL_MASK);