From patchwork Mon May 13 11:01:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 16876 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-we0-f198.google.com (mail-we0-f198.google.com [74.125.82.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E718425E14 for ; Mon, 13 May 2013 11:02:11 +0000 (UTC) Received: by mail-we0-f198.google.com with SMTP id q54sf6135979wes.9 for ; Mon, 13 May 2013 04:01:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-beenthere:x-received:received-spf:x-received :x-forwarded-to:x-forwarded-for:delivered-to:x-received:received-spf :x-ironport-av:message-id:subject:from:to:cc:date:in-reply-to :references:organization:x-mailer:mime-version:x-gm-message-state :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:x-google-group-id:list-post:list-help :list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=YNpNf7lCmgz/yp3Dv2V+/kcFjdbjRE+6wAJSuWTiXrI=; b=U3LvBjrSCfe6wE3wcwpBq/LNz5hUAS7ezDddFOBymAQYa6po4BFAs2+uMfGbiaQ90m Cbh4+aHP2d6IE5zmgg1aSSaOhYBKw2oJF7WJKUjw1ttY5E4yCwfui2TkVXy3tXfCzPzd PZ1qAXgAgKU/o6ulu52VVNGUn2ABddXPKzNcMcnJ46csAYsIulST++RcqS0Z8z/Ea7K0 9p0LfaLm9seXbXaS5++GPFjxtW81n27Z4Dl3Z7hQKbZA98QRFzGYqotucWttjjrM9djq 2FouxofmjzPcHqKD1uyQ/cE5rwq0wktaHK3L6HWhsE5z/ClS+UTJqEW2+kgSIgCEX7cy w4bg== X-Received: by 10.180.109.111 with SMTP id hr15mr3385392wib.1.1368442898740; Mon, 13 May 2013 04:01:38 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.180.88.196 with SMTP id bi4ls174427wib.47.gmail; Mon, 13 May 2013 04:01:38 -0700 (PDT) X-Received: by 10.194.92.176 with SMTP id cn16mr39315281wjb.51.1368442898607; Mon, 13 May 2013 04:01:38 -0700 (PDT) Received: from mail-ve0-x232.google.com (mail-ve0-x232.google.com [2607:f8b0:400c:c01::232]) by mx.google.com with ESMTPS id r17si3979241wjw.190.2013.05.13.04.01.38 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 13 May 2013 04:01:38 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c01::232 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c01::232; Received: by mail-ve0-f178.google.com with SMTP id jy13so5534953veb.23 for ; Mon, 13 May 2013 04:01:37 -0700 (PDT) X-Received: by 10.52.36.115 with SMTP id p19mr1149121vdj.8.1368442897512; Mon, 13 May 2013 04:01:37 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.217.15 with SMTP id hk15csp14069vcb; Mon, 13 May 2013 04:01:36 -0700 (PDT) X-Received: by 10.180.109.84 with SMTP id hq20mr7931670wib.11.1368442896508; Mon, 13 May 2013 04:01:36 -0700 (PDT) Received: from SMTP.EU.CITRIX.COM (smtp.eu.citrix.com. [46.33.159.39]) by mx.google.com with ESMTPS id s7si3992850wjs.56.2013.05.13.04.01.35 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 13 May 2013 04:01:36 -0700 (PDT) Received-SPF: pass (google.com: domain of Ian.Campbell@citrix.com designates 46.33.159.39 as permitted sender) client-ip=46.33.159.39; X-IronPort-AV: E=Sophos;i="4.87,552,1363132800"; d="scan'208";a="4489010" Received: from lonpmailmx01.citrite.net ([10.30.203.162]) by LONPIPO01.EU.CITRIX.COM with ESMTP/TLS/RC4-MD5; 13 May 2013 10:52:41 +0000 Received: from [10.80.2.42] (10.80.2.42) by LONPMAILMX01.citrite.net (10.30.203.162) with Microsoft SMTP Server id 8.3.298.1; Mon, 13 May 2013 12:01:35 +0100 Message-ID: <1368442894.537.59.camel@zakaz.uk.xensource.com> Subject: Re: [PATCH V4 02/32] xen/mm: Align virtual address on PAGE_SIZE in iounmap From: Ian Campbell To: Julien Grall CC: "xen-devel@lists.xen.org" , Stefano Stabellini , "patches@linaro.org" , "Keir (Xen.org)" Date: Mon, 13 May 2013 12:01:34 +0100 In-Reply-To: <1368198723-24639-3-git-send-email-julien.grall@linaro.org> References: <1368198723-24639-1-git-send-email-julien.grall@linaro.org> <1368198723-24639-3-git-send-email-julien.grall@linaro.org> Organization: Citrix Systems, Inc. X-Mailer: Evolution 3.4.4-1 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQm/gzLnnQHOIy+tlwsTnA4HYYMauP+ffseS+6N+bh8BHK4Yxypsqo21WmMmV1nM0VgKSExW X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c01::232 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On Fri, 2013-05-10 at 16:11 +0100, Julien Grall wrote: > ioremap function can unlikely return an unaligned virtual address if > the physical address itself is unaligned on a page size. On x86 this causes: In file included from /local/scratch/ianc/devel/committer.git/xen/include/asm/io.h:5, from /local/scratch/ianc/devel/committer.git/xen/include/asm/mc146818rtc.h:8, from rtc.c:26: /local/scratch/ianc/devel/committer.git/xen/include/xen/vmap.h: In function ‘iounmap’: /local/scratch/ianc/devel/committer.git/xen/include/xen/vmap.h:20: error: ‘PAGE_MASK’ undeclared (first use in this function) /local/scratch/ianc/devel/committer.git/xen/include/xen/vmap.h:20: error: (Each undeclared identifier is reported only once /local/scratch/ianc/devel/committer.git/xen/include/xen/vmap.h:20: error: for each function it appears in.) make[5]: *** [rtc.o] Error 1 make[5]: *** Waiting for unfinished jobs.... Since I had already prepared the branch for commit/push and it was a bit of a faff I will fold in the following patchlet: diff --git a/xen/include/xen/vmap.h b/xen/include/xen/vmap.h index daee7f5..b1923dd 100644 --- a/xen/include/xen/vmap.h +++ b/xen/include/xen/vmap.h @@ -2,6 +2,7 @@ #define __XEN_VMAP_H__ #include +#include void *vm_alloc(unsigned int nr, unsigned int align); void vm_free(const void *);