From patchwork Fri Oct 18 01:44:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roy Franz X-Patchwork-Id: 21104 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pb0-f71.google.com (mail-pb0-f71.google.com [209.85.160.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3AAAB246F1 for ; Fri, 18 Oct 2013 01:44:18 +0000 (UTC) Received: by mail-pb0-f71.google.com with SMTP id uo15sf2724853pbc.6 for ; Thu, 17 Oct 2013 18:44:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:x-gm-message-state:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=T7AdR2fbXCRd4rW3+xbsxGocCXetT4zGKsO2MEdUOk8=; b=TCp9N19Mur087L0eTwo/EN+IYGIrWy2T0Qxzg+RMpDbCERdq0on8QIYF1VMRAk0AjM P/0aylpNxbYXnkGku8z1HS+sr2dJuLJcNj2z3V0OncIOwbBtFo/gsytrx/gVhKSYcqcF E/hametsV+eKGah/XJUziRMhegh5HDN2DxZbKbiCW1caPPrLkCYumTinEjiVI/qPFpzE rwkiY951hlct2V3uf9m5ikpAhtjRhSaIpArqjXMV+kKFsFYxklvamSDFwafd9wD86VoT v7RXejloeHUm7BvTKUy9Y2WtrLlSF20hPNsdmEDm95zvwACDqcbJpQb/MG+Z3MVi9KkY UWvw== X-Received: by 10.68.136.229 with SMTP id qd5mr214176pbb.6.1382060658071; Thu, 17 Oct 2013 18:44:18 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.109.226 with SMTP id hv2ls1107761qeb.22.gmail; Thu, 17 Oct 2013 18:44:17 -0700 (PDT) X-Received: by 10.52.173.165 with SMTP id bl5mr130402vdc.18.1382060657857; Thu, 17 Oct 2013 18:44:17 -0700 (PDT) Received: from mail-vc0-f169.google.com (mail-vc0-f169.google.com [209.85.220.169]) by mx.google.com with ESMTPS id sv5si7649216veb.13.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 17 Oct 2013 18:44:17 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.169; Received: by mail-vc0-f169.google.com with SMTP id hu8so93854vcb.28 for ; Thu, 17 Oct 2013 18:44:17 -0700 (PDT) X-Gm-Message-State: ALoCoQl9DQZF+SUnATX2agClYsARNOVu/LEvqbOfi2gGhAodfPqTS0UB9Uad5LQUESWTPQSwA3P5 X-Received: by 10.58.208.130 with SMTP id me2mr124426vec.13.1382060657691; Thu, 17 Oct 2013 18:44:17 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp163026vcz; Thu, 17 Oct 2013 18:44:17 -0700 (PDT) X-Received: by 10.67.3.34 with SMTP id bt2mr896899pad.3.1382060656038; Thu, 17 Oct 2013 18:44:16 -0700 (PDT) Received: from mail-pb0-f46.google.com (mail-pb0-f46.google.com [209.85.160.46]) by mx.google.com with ESMTPS id mi5si25409pab.280.2013.10.17.18.44.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 17 Oct 2013 18:44:15 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.46 is neither permitted nor denied by best guess record for domain of roy.franz@linaro.org) client-ip=209.85.160.46; Received: by mail-pb0-f46.google.com with SMTP id rq2so3122792pbb.19 for ; Thu, 17 Oct 2013 18:44:11 -0700 (PDT) X-Received: by 10.68.76.65 with SMTP id i1mr420020pbw.37.1382060651729; Thu, 17 Oct 2013 18:44:11 -0700 (PDT) Received: from rfranz-i7.local (c-98-244-40-86.hsd1.ca.comcast.net. [98.244.40.86]) by mx.google.com with ESMTPSA id xv2sm100764207pbb.39.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 17 Oct 2013 18:44:10 -0700 (PDT) From: Roy Franz To: edk2-devel@lists.sourceforge.net, linaro-uefi-internal@linaro.org Cc: patches@linaro.org, Roy Franz Subject: [PATCH] Fix checking of return value of NorFlashWriteBlocks(). Date: Thu, 17 Oct 2013 18:44:04 -0700 Message-Id: <1382060644-18479-1-git-send-email-roy.franz@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: roy.franz@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Signed-off-by: Roy Franz Contributed-under: TianoCore Contribution Agreement 1.0 --- ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c index ab6304b..4b56f2a 100644 --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c @@ -608,7 +608,7 @@ FvbWrite ( CopyMem((BlockBuffer + Offset), Buffer, *NumBytes); // Write the modified buffer back to the NorFlash - Status = NorFlashWriteBlocks (Instance, Instance->StartLba + Lba, BlockSize, BlockBuffer); + TempStatus = NorFlashWriteBlocks (Instance, Instance->StartLba + Lba, BlockSize, BlockBuffer); if (EFI_ERROR (TempStatus)) { // Return one of the pre-approved error statuses Status = EFI_DEVICE_ERROR;