From patchwork Tue Sep 2 22:56:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 36528 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f72.google.com (mail-pa0-f72.google.com [209.85.220.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9BC2820C93 for ; Tue, 2 Sep 2014 22:57:03 +0000 (UTC) Received: by mail-pa0-f72.google.com with SMTP id eu11sf75992774pac.3 for ; Tue, 02 Sep 2014 15:57:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:subject:precedence:reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version :errors-to:x-original-sender:x-original-authentication-results :mailing-list:content-type:content-transfer-encoding; bh=R8o4fei3VfEDDxE2AGiYlFd3uKKHqNGVnxMMprQKDyU=; b=HpqdTOMpkijbN2zeucr70ERvNN0unyNfRLryZZaG39MPJ2Ug4fFNXHmZCpVFe9U6Ch VKnxEZt2ES7LSrQ+6+2PA5EzFqcsT1E61elhmnBmN07uYOA7QO4idtT5KqtP7ZpRPzxs 6BdaTW5EiuM+Cr0UbnzqL/OyQVW9u81iPNiOjEFiDW+CQqUb/uWmqDRAijBTDoRCkOtF wNUeQN3mPUntInEJDBflMPZxQAnfuMMuTn5XdTiWaDJ4MIolSKLFErJ3em0SUnf8T2K/ 3cYmQeStDdllDWKEs+325A0SsTi4GQ13SD5oMdguoJ0rDtBQxiwAABSKcPCTbkiH4b02 5p4g== X-Gm-Message-State: ALoCoQm5gmWnm+RKh4qG2XjbkdD7PgowTCucjC70e/hVv5tX/p1uAGg3A6Dql41rgcYs2sgD0auO X-Received: by 10.70.119.74 with SMTP id ks10mr1351144pdb.9.1409698622864; Tue, 02 Sep 2014 15:57:02 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.37.35 with SMTP id q32ls2705516qgq.50.gmail; Tue, 02 Sep 2014 15:57:02 -0700 (PDT) X-Received: by 10.221.49.133 with SMTP id va5mr2807740vcb.37.1409698622635; Tue, 02 Sep 2014 15:57:02 -0700 (PDT) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by mx.google.com with ESMTPS id ct1si174874vdc.80.2014.09.02.15.57.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 02 Sep 2014 15:57:02 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.174 as permitted sender) client-ip=209.85.220.174; Received: by mail-vc0-f174.google.com with SMTP id hy4so7889554vcb.19 for ; Tue, 02 Sep 2014 15:57:02 -0700 (PDT) X-Received: by 10.52.234.228 with SMTP id uh4mr3064203vdc.34.1409698622509; Tue, 02 Sep 2014 15:57:02 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp596451vcb; Tue, 2 Sep 2014 15:57:02 -0700 (PDT) X-Received: by 10.50.43.225 with SMTP id z1mr31538059igl.17.1409698621459; Tue, 02 Sep 2014 15:57:01 -0700 (PDT) Received: from lists.sourceforge.net (lists.sourceforge.net. [216.34.181.88]) by mx.google.com with ESMTPS id za2si9899863icb.82.2014.09.02.15.57.00 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 02 Sep 2014 15:57:01 -0700 (PDT) Received-SPF: pass (google.com: domain of edk2-devel-bounces@lists.sourceforge.net designates 216.34.181.88 as permitted sender) client-ip=216.34.181.88; Received: from localhost ([127.0.0.1] helo=sfs-ml-4.v29.ch3.sourceforge.com) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XOx0Q-00059j-B8; Tue, 02 Sep 2014 22:56:54 +0000 Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XOx0O-000598-CB for edk2-devel@lists.sourceforge.net; Tue, 02 Sep 2014 22:56:52 +0000 Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=lersek@redhat.com; helo=mx1.redhat.com; Received: from mx1.redhat.com ([209.132.183.28]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1XOx0N-0004yt-ET for edk2-devel@lists.sourceforge.net; Tue, 02 Sep 2014 22:56:52 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s82MujQB016323 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 2 Sep 2014 18:56:45 -0400 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-55.ams2.redhat.com [10.36.116.55]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s82MueDU005138 for ; Tue, 2 Sep 2014 18:56:44 -0400 From: Laszlo Ersek To: edk2-devel@lists.sourceforge.net Date: Wed, 3 Sep 2014 00:56:31 +0200 Message-Id: <1409698598-9766-5-git-send-email-lersek@redhat.com> In-Reply-To: <1409698598-9766-1-git-send-email-lersek@redhat.com> References: <54063964.8060402@redhat.com> <1409698598-9766-1-git-send-email-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Spam-Score: -3.2 (---) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-Headers-End: 1XOx0N-0004yt-ET Subject: [edk2] [PATCH 05/12] OvmfPkg: PlatformBdsLib: add constructor X-BeenThere: edk2-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: edk2-devel@lists.sourceforge.net List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.sourceforge.net X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lersek@redhat.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.174 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Calls to constructors of interdependent library instances are generated in the correct order only if all library instances in question have constructors. If some have no constructors, then the rest may see their constructors called out of order. Cycle detection also only works when all library instances have constructors. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/PlatformBdsLib/PlatformBdsLib.inf | 2 ++ OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 10 ++++++++++ 2 files changed, 12 insertions(+) diff --git a/OvmfPkg/Library/PlatformBdsLib/PlatformBdsLib.inf b/OvmfPkg/Library/PlatformBdsLib/PlatformBdsLib.inf index a2b72ba..a28534b 100644 --- a/OvmfPkg/Library/PlatformBdsLib/PlatformBdsLib.inf +++ b/OvmfPkg/Library/PlatformBdsLib/PlatformBdsLib.inf @@ -20,6 +20,8 @@ VERSION_STRING = 1.0 LIBRARY_CLASS = PlatformBdsLib|DXE_DRIVER + CONSTRUCTOR = PlatformBdsLibConstructor + # # The following information is for reference only and not required by the build tools. # diff --git a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c index 2a1ca88..3a70799 100644 --- a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c @@ -1447,3 +1447,13 @@ LockKeyboards ( return EFI_UNSUPPORTED; } + +EFI_STATUS +EFIAPI +PlatformBdsLibConstructor ( + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE *SystemTable + ) +{ + return EFI_SUCCESS; +}