From patchwork Mon Oct 6 15:40:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 38376 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f200.google.com (mail-wi0-f200.google.com [209.85.212.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D3F40202E7 for ; Mon, 6 Oct 2014 15:42:13 +0000 (UTC) Received: by mail-wi0-f200.google.com with SMTP id cc10sf1752674wib.3 for ; Mon, 06 Oct 2014 08:42:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:from:to:date:in-reply-to :references:organization:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-type:content-transfer-encoding; bh=qXf7ZLNsWKKBWpb+8OxzNo+lW3FKanzBPXWy8ipf/B0=; b=C1aX7N/IPRFz2okcscfZMun+xqIn5lrChaKLSqfG0LuVR3xRaEvQrrha3eTmR6FqYJ R/diNyFQZkKEhPzpFeLg15OOMEM3BP2fkK9Qs/wHc8F9ukpYgDajMfepKEILyXYaD0eJ nFXbS91lLFGAXWIPFADDJBaZXMTng9fn9hdGI6YlGh3vuqGudd79Gate1zIcVDoEd4rG 32If5G/Lm8ZF0DvBXYELfANUyYdlnH+3D92mUAwWenNyg2s6DZfWXMwsrZOGF/A2ODJD CX04o/ib2zoizJItATCuqDM6kfEjrYP4sbjT5cxZVoSoCcNMXw56hdS68Lwbrn/VQzMB Z7eg== X-Gm-Message-State: ALoCoQk08g3wvlIvPlLrMWVvHtdIRlhXyyPpfZ8weM3GZxiu1Prakzz1XgTkCTem0N2M7QrRHNLI X-Received: by 10.152.6.195 with SMTP id d3mr15447laa.10.1412610132990; Mon, 06 Oct 2014 08:42:12 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.30.40 with SMTP id p8ls496521lah.106.gmail; Mon, 06 Oct 2014 08:42:12 -0700 (PDT) X-Received: by 10.152.5.9 with SMTP id o9mr3947137lao.95.1412610132808; Mon, 06 Oct 2014 08:42:12 -0700 (PDT) Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com [209.85.217.170]) by mx.google.com with ESMTPS id of9si24434264lbb.124.2014.10.06.08.42.12 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 06 Oct 2014 08:42:12 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) client-ip=209.85.217.170; Received: by mail-lb0-f170.google.com with SMTP id u10so4520276lbd.15 for ; Mon, 06 Oct 2014 08:42:12 -0700 (PDT) X-Received: by 10.112.134.229 with SMTP id pn5mr24784839lbb.22.1412610132721; Mon, 06 Oct 2014 08:42:12 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp204909lbb; Mon, 6 Oct 2014 08:42:12 -0700 (PDT) X-Received: by 10.52.147.106 with SMTP id tj10mr1012724vdb.85.1412610131107; Mon, 06 Oct 2014 08:42:11 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id w46si25898795qgw.23.2014.10.06.08.42.10 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 06 Oct 2014 08:42:11 -0700 (PDT) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XbAOp-0007D3-Jc; Mon, 06 Oct 2014 15:40:35 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XbAOo-0007Cy-LT for xen-devel@lists.xen.org; Mon, 06 Oct 2014 15:40:34 +0000 Received: from [85.158.137.68:35165] by server-15.bemta-3.messagelabs.com id 65/90-01573-1F7B2345; Mon, 06 Oct 2014 15:40:33 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-12.tower-31.messagelabs.com!1412610031!11732976!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.12.2; banners=-,-,- X-VirusChecked: Checked Received: (qmail 12834 invoked from network); 6 Oct 2014 15:40:33 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-12.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 6 Oct 2014 15:40:33 -0000 X-IronPort-AV: E=Sophos;i="5.04,664,1406592000"; d="scan'208";a="178627830" Message-ID: <1412610028.14255.19.camel@citrix.com> From: Ian Campbell To: Olaf Hering Date: Mon, 6 Oct 2014 16:40:28 +0100 In-Reply-To: <1412181690-19609-16-git-send-email-olaf@aepfle.de> References: <1412181690-19609-1-git-send-email-olaf@aepfle.de> <1412181690-19609-16-git-send-email-olaf@aepfle.de> Organization: Citrix Systems, Inc. X-Mailer: Evolution 3.12.6-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: Wei Liu , George Dunlap , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org, Samuel Thibault Subject: Re: [Xen-devel] [PATCH 15/28] Use configure --libexecdir=BASEDIR to set LIBEXEC X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: On Wed, 2014-10-01 at 18:41 +0200, Olaf Hering wrote: > Most users of LIBEXEC are updated to use LIBEXEC_BIN because that is > what they want. This caused the qemu-dm binary to move from dist/install/usr/local/lib/xen/bin/qemu-dm has become dist/install/usr/local/lib/xen/qemu-dm, because you missed the hidden reliance on LIBEXEC inside the qemu-trad tree. I propose that Ian J reviews and applies the following and I will fold the associated Config.mk change into this changeset. I've done builds locally for both x86_32 and x86_64 and it has put qemu-dm back where it belongs... Ian. >From 6e0f43aa9d7af043347abe2ddbdf0e1eb0dbff0c Mon Sep 17 00:00:00 2001 From: Ian Campbell Date: Mon, 6 Oct 2014 16:24:46 +0100 Subject: [PATCH] qemu-xen-trad: Switch to $(LIBEXEC_BIN) from $(LIBEXEC) The meaning of LIBEXEC in the Xen build system has been made to follow the more conventional meaning. Signed-off-by: Ian Campbell --- xen-config.mak | 2 +- xen-setup-stubdom | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen-config.mak b/xen-config.mak index 77fef4f..280af0c 100644 --- a/xen-config.mak +++ b/xen-config.mak @@ -9,4 +9,4 @@ CONFIG_SOFTMMU=yes CFLAGS += -I$(QEMU_ROOT)/hw -bindir = ${LIBEXEC} +bindir = ${LIBEXEC_BIN} diff --git a/xen-setup-stubdom b/xen-setup-stubdom index 4f1b081..b523509 100755 --- a/xen-setup-stubdom +++ b/xen-setup-stubdom @@ -22,7 +22,7 @@ TARGET_CPPFLAGS += $TARGET_CPPFLAGS -DCONFIG_STUBDOM -D__XEN_TOOLS__ TARGET_CFLAGS= $TARGET_CFLAGS TARGET_LDFLAGS= $TARGET_LDFLAGS -bindir = \${LIBEXEC} +bindir = \${LIBEXEC_BIN} END mv -f $target/config.mak.new $target/config.mak #----------