From patchwork Thu Oct 23 11:33:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laszlo Ersek X-Patchwork-Id: 39355 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f199.google.com (mail-lb0-f199.google.com [209.85.217.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id F0DBA24022 for ; Thu, 23 Oct 2014 11:34:30 +0000 (UTC) Received: by mail-lb0-f199.google.com with SMTP id w7sf479990lbi.6 for ; Thu, 23 Oct 2014 04:34:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:subject:precedence:reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version :errors-to:x-original-sender:x-original-authentication-results :mailing-list:content-type:content-transfer-encoding; bh=xmHfMUUrrrmOq4N+DpaYhtWuOPH13mzlXoIfiu76NkI=; b=bVBpQMCVgso7iq01i3Tncxjfl0QQF8xuDHbCNnaEBpB9sMZsWyJq0b8Tcx/rmQx0+a a862DJPFFNxLk5Ql8RI6/6i1fqlv527dpDvOQKli2LMxAF2WE2L0XkOnO9K4h49obviW 8XKzku2RQxqhtKV/EPW7fc1cm5dG1bjxSZLfjRcQ7dO/8Ze5bijvwMh4fpUtqpbGsmhu si9ewnBq1EvRiRiZTazDmbFPXHDzdrkavqkAaZP2FJ9iZYRIxY6ptqYKrlZeLb4Xky3i oG3Qao3+V7Z/MZeJPfqJ7YEjNxV47kF6V/dgokf0Vpp5kaw3Fv3/vgA2dVUQqayMiHvC 0E6g== X-Gm-Message-State: ALoCoQlBfIKJWhycmvLvj8bYOdt1SKq2XXtoqb2Vs+e8jTaM19r9UWGCvteLftJKuTFCmTDd6w9w X-Received: by 10.180.96.101 with SMTP id dr5mr6102550wib.0.1414064069720; Thu, 23 Oct 2014 04:34:29 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.202.230 with SMTP id kl6ls66348lac.99.gmail; Thu, 23 Oct 2014 04:34:29 -0700 (PDT) X-Received: by 10.152.36.230 with SMTP id t6mr4368849laj.88.1414064069469; Thu, 23 Oct 2014 04:34:29 -0700 (PDT) Received: from mail-lb0-f177.google.com (mail-lb0-f177.google.com. [209.85.217.177]) by mx.google.com with ESMTPS id jp10si2213076lab.19.2014.10.23.04.34.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Oct 2014 04:34:29 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.177 as permitted sender) client-ip=209.85.217.177; Received: by mail-lb0-f177.google.com with SMTP id w7so640428lbi.22 for ; Thu, 23 Oct 2014 04:34:29 -0700 (PDT) X-Received: by 10.152.6.228 with SMTP id e4mr4322969laa.71.1414064069376; Thu, 23 Oct 2014 04:34:29 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.84.229 with SMTP id c5csp238318lbz; Thu, 23 Oct 2014 04:34:28 -0700 (PDT) X-Received: by 10.42.231.198 with SMTP id jr6mr700009icb.91.1414064066459; Thu, 23 Oct 2014 04:34:26 -0700 (PDT) Received: from lists.sourceforge.net (lists.sourceforge.net. [216.34.181.88]) by mx.google.com with ESMTPS id f71si1649783ioi.33.2014.10.23.04.34.25 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 23 Oct 2014 04:34:26 -0700 (PDT) Received-SPF: pass (google.com: domain of edk2-devel-bounces@lists.sourceforge.net designates 216.34.181.88 as permitted sender) client-ip=216.34.181.88; Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XhGen-0000zX-4n; Thu, 23 Oct 2014 11:34:17 +0000 Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XhGel-0000zC-Rv for edk2-devel@lists.sourceforge.net; Thu, 23 Oct 2014 11:34:15 +0000 Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=lersek@redhat.com; helo=mx1.redhat.com; Received: from mx1.redhat.com ([209.132.183.28]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1XhGel-0005M3-23 for edk2-devel@lists.sourceforge.net; Thu, 23 Oct 2014 11:34:15 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9NBY9Av002119 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 23 Oct 2014 07:34:09 -0400 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-105.ams2.redhat.com [10.36.116.105]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9NBXtPZ027262 for ; Thu, 23 Oct 2014 07:34:08 -0400 From: Laszlo Ersek To: edk2-devel@lists.sourceforge.net Date: Thu, 23 Oct 2014 13:33:47 +0200 Message-Id: <1414064030-11029-7-git-send-email-lersek@redhat.com> In-Reply-To: <1414064030-11029-1-git-send-email-lersek@redhat.com> References: <1414064030-11029-1-git-send-email-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Spam-Score: -2.9 (--) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-Headers-End: 1XhGel-0005M3-23 Subject: [edk2] [PATCH v2 6/9] OvmfPkg: BDS: optimize second argument in PlatformBdsEnterFrontPage() call X-BeenThere: edk2-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: edk2-devel@lists.sourceforge.net List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.sourceforge.net X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: lersek@redhat.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.177 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The second parameter of said function is "ConnectAllHappened", and if set to TRUE, the function sets "gConnectAllHappened" to TRUE. This global variable in turn controls whether Intel BDS code *itself* calls BdsLibConnectAllDriversToAllControllers() in various places -- if the indicator is TRUE, then the "connect all" is assumed to have been performed, and Intel BDS doesn't do it itself. OVMF should pass TRUE as "ConnectAllHappened", because a few lines before our call to PlatformBdsEnterFrontPage(), we already connect everything with BdsLibConnectAll(), which includes the effects of BdsLibConnectAllDriversToAllControllers(): PlatformBdsPolicyBehavior() [OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c] BdsLibConnectAll() [IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConnect.c] BdsLibConnectAllDriversToAllControllers() PlatformBdsEnterFrontPage() [IntelFrameworkModulePkg/Universal/BdsDxe/FrontPage.c] Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c index f2ece66..9fa48c9 100644 --- a/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c @@ -1193,7 +1193,7 @@ Returns: // // Enter Setup if user input // - PlatformBdsEnterFrontPage (Timeout, FALSE); + PlatformBdsEnterFrontPage (Timeout, TRUE); } }