From patchwork Wed May 13 04:31:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: gary guo X-Patchwork-Id: 48419 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id ECD35214A1 for ; Wed, 13 May 2015 04:33:25 +0000 (UTC) Received: by labgx2 with SMTP id gx2sf6680082lab.1 for ; Tue, 12 May 2015 21:33:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:cc:subject :precedence:reply-to:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:x-original-sender :x-original-authentication-results:mailing-list; bh=9gVo8zxZPM4MV8m4K64Grf7vh4J576EhRDCCiXFIPIo=; b=Od71kcl/faR9U14KINXv0mt61CXRcUFCw6xwh+k8ZQHe5+NhRqAzmzeLxCey2/WCB9 h+1BOo0O/B4zu9D9AN4JewoM5CzgasEogseP4I4mVsOsrCksiFJ9/lPl558StHwP+CeZ 72W8atYNKdVIoxahdUItz8vcMLxt8E8uAsqcCg8pp0T5SOlRaeP1D9RbR4YJGoARLV6q lTQ0ykpDLyFn9uMd5FmiZHr2+oyyXS7vF2TH4jTv1xuXXZAY6qW1SEa4Vk7VMbxbYOvv u5rG6iGYne1F7gOQVh1my3IKMWi9FYMlgXs7VgR9hrj+DleDoiLwhOHNMSKMqTjRFeuZ LA5A== X-Gm-Message-State: ALoCoQlZt+WdaTwONOeKhdQxLxRz0OX+q7nbwJpRh8zJx198nOxP8ejJY5J69pz4O5JoVeJw+W1t X-Received: by 10.180.211.168 with SMTP id nd8mr4022587wic.4.1431491604763; Tue, 12 May 2015 21:33:24 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.178.164 with SMTP id cz4ls134403lac.3.gmail; Tue, 12 May 2015 21:33:24 -0700 (PDT) X-Received: by 10.112.159.162 with SMTP id xd2mr14188320lbb.67.1431491604532; Tue, 12 May 2015 21:33:24 -0700 (PDT) Received: from mail-la0-f50.google.com (mail-la0-f50.google.com. [209.85.215.50]) by mx.google.com with ESMTPS id w5si11584367law.138.2015.05.12.21.33.24 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 May 2015 21:33:24 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) client-ip=209.85.215.50; Received: by labbd9 with SMTP id bd9so20651060lab.2 for ; Tue, 12 May 2015 21:33:24 -0700 (PDT) X-Received: by 10.152.2.227 with SMTP id 3mr5323003lax.73.1431491604103; Tue, 12 May 2015 21:33:24 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp294869lbb; Tue, 12 May 2015 21:33:23 -0700 (PDT) X-Received: by 10.42.236.78 with SMTP id kj14mr6968488icb.43.1431491602550; Tue, 12 May 2015 21:33:22 -0700 (PDT) Received: from lists.sourceforge.net (lists.sourceforge.net. [216.34.181.88]) by mx.google.com with ESMTPS id l11si3357171igk.57.2015.05.12.21.33.21 (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 12 May 2015 21:33:22 -0700 (PDT) Received-SPF: pass (google.com: domain of edk2-devel-bounces@lists.sourceforge.net designates 216.34.181.88 as permitted sender) client-ip=216.34.181.88; Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1YsOLy-0000Lw-Jy; Wed, 13 May 2015 04:33:06 +0000 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1YsOLw-0000Lr-MW for edk2-devel@lists.sourceforge.net; Wed, 13 May 2015 04:33:04 +0000 Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of linaro.org designates 209.85.220.49 as permitted sender) client-ip=209.85.220.49; envelope-from=heyi.guo@linaro.org; helo=mail-pa0-f49.google.com; Received: from mail-pa0-f49.google.com ([209.85.220.49]) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1YsOLv-0000Vl-UX for edk2-devel@lists.sourceforge.net; Wed, 13 May 2015 04:33:04 +0000 Received: by pabsx10 with SMTP id sx10so37482707pab.3 for ; Tue, 12 May 2015 21:32:58 -0700 (PDT) X-Received: by 10.68.252.106 with SMTP id zr10mr34174386pbc.79.1431491578208; Tue, 12 May 2015 21:32:58 -0700 (PDT) Received: from localhost.localdomain ([167.160.116.38]) by mx.google.com with ESMTPSA id v8sm501834pdm.89.2015.05.12.21.32.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 May 2015 21:32:57 -0700 (PDT) From: Heyi Guo To: olivier.martin@arm.com Date: Wed, 13 May 2015 12:31:42 +0800 Message-Id: <1431491502-15855-1-git-send-email-heyi.guo@linaro.org> X-Mailer: git-send-email 2.1.4 X-Spam-Score: -1.5 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1YsOLv-0000Vl-UX Cc: edk2-devel@lists.sourceforge.net, ilias.biris@linaro.org Subject: [edk2] [PATCH] ArmPkg: fix ArmWriteCntkCtl simple code bug X-BeenThere: edk2-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: edk2-devel@lists.sourceforge.net List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.sourceforge.net X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: heyi.guo@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 We need to use msr instruction to write system register. It seems the code was simply copied from ArmReadCntkCtl. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo --- ArmPkg/Library/ArmLib/AArch64/AArch64ArchTimerSupport.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Library/ArmLib/AArch64/AArch64ArchTimerSupport.S b/ArmPkg/Library/ArmLib/AArch64/AArch64ArchTimerSupport.S index 1ac0108..3944d8b 100644 --- a/ArmPkg/Library/ArmLib/AArch64/AArch64ArchTimerSupport.S +++ b/ArmPkg/Library/ArmLib/AArch64/AArch64ArchTimerSupport.S @@ -58,7 +58,7 @@ ASM_PFX(ArmReadCntkCtl): ASM_PFX(ArmWriteCntkCtl): - mrs x0, cntkctl_el1 // Write to CNTK_CTL (Timer PL1 Control Register) + msr cntkctl_el1, x0 // Write to CNTK_CTL (Timer PL1 Control Register) ret