From patchwork Mon Jun 22 23:30:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roy Franz X-Patchwork-Id: 50195 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f72.google.com (mail-wg0-f72.google.com [74.125.82.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 1265021575 for ; Mon, 22 Jun 2015 23:30:52 +0000 (UTC) Received: by wgbhy7 with SMTP id hy7sf47740591wgb.3 for ; Mon, 22 Jun 2015 16:30:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:subject:precedence:reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:mime-version :content-type:content-transfer-encoding:errors-to:x-original-sender :x-original-authentication-results:mailing-list; bh=hnn1PlOCCYNHo/0YNXBMIkMhJlPE2EaXu8+GHvsCJ28=; b=Lho25iAZH2j71gYUjuXQZMtziWeYdY7wl1TQn2J2Vd3YO2ulUuUaL/HGqpiii9kP7C slt0f7ReX9ZQkyA5VXHQd6Rkw0ldJH9C0OeAFI84peZfJ4SS4/3lfIBza9PjSXg4hUtV IbRxQxrf9A+MxMO2fH2Odx3RodLNA+AWHyWceMHA+LD76DMaFOBEvEg6kOTOQlq8OynB pp2O2ReVhwNtPDoJ4fiqAJ6s1670/CcllJJFnpJSxvo553yYREhvmhmKCNsv2WAI9oOK s0qdr7XjtUTIHuK+fkVTPpwc/1xPHY67Js09LYeoqLWAY83tpol5GorwVM4g0oLoNCQN wp3g== X-Gm-Message-State: ALoCoQneR9oIuPPIbVJ405pbAjhGueVBeSYQmjkMJl/Yn6fIiwwfISB5JvH0RXsScaYZf9WtnvNk X-Received: by 10.180.216.12 with SMTP id om12mr17726827wic.1.1435015851422; Mon, 22 Jun 2015 16:30:51 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.205.6 with SMTP id lc6ls478644lac.80.gmail; Mon, 22 Jun 2015 16:30:51 -0700 (PDT) X-Received: by 10.152.25.227 with SMTP id f3mr31583357lag.67.1435015851253; Mon, 22 Jun 2015 16:30:51 -0700 (PDT) Received: from mail-la0-f50.google.com (mail-la0-f50.google.com. [209.85.215.50]) by mx.google.com with ESMTPS id t2si17774492lbj.163.2015.06.22.16.30.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jun 2015 16:30:50 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) client-ip=209.85.215.50; Received: by lagx9 with SMTP id x9so31390106lag.1 for ; Mon, 22 Jun 2015 16:30:50 -0700 (PDT) X-Received: by 10.152.87.33 with SMTP id u1mr32949700laz.35.1435015850834; Mon, 22 Jun 2015 16:30:50 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp2697011lbb; Mon, 22 Jun 2015 16:30:49 -0700 (PDT) X-Received: by 10.42.88.197 with SMTP id d5mr28944097icm.44.1435015845102; Mon, 22 Jun 2015 16:30:45 -0700 (PDT) Received: from lists.sourceforge.net (lists.sourceforge.net. [216.34.181.88]) by mx.google.com with ESMTPS id pj7si10561455igb.9.2015.06.22.16.30.44 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 22 Jun 2015 16:30:45 -0700 (PDT) Received-SPF: pass (google.com: domain of edk2-devel-bounces@lists.sourceforge.net designates 216.34.181.88 as permitted sender) client-ip=216.34.181.88; Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Z7BAh-0001LO-Sa; Mon, 22 Jun 2015 23:30:35 +0000 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Z7BAf-0001LD-WC for edk2-devel@lists.sourceforge.net; Mon, 22 Jun 2015 23:30:34 +0000 Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of linaro.org designates 209.85.220.49 as permitted sender) client-ip=209.85.220.49; envelope-from=roy.franz@linaro.org; helo=mail-pa0-f49.google.com; Received: from mail-pa0-f49.google.com ([209.85.220.49]) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1Z7BAe-0006YI-9O for edk2-devel@lists.sourceforge.net; Mon, 22 Jun 2015 23:30:33 +0000 Received: by pactm7 with SMTP id tm7so4451744pac.2 for ; Mon, 22 Jun 2015 16:30:26 -0700 (PDT) X-Received: by 10.66.141.109 with SMTP id rn13mr62538895pab.127.1435015826641; Mon, 22 Jun 2015 16:30:26 -0700 (PDT) Received: from localhost.localdomain (c-73-41-93-56.hsd1.ca.comcast.net. [73.41.93.56]) by mx.google.com with ESMTPSA id tj8sm21143238pab.30.2015.06.22.16.30.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 22 Jun 2015 16:30:25 -0700 (PDT) From: Roy Franz To: edk2-devel@lists.sourceforge.net, feng.tian@intel.com, lersek@redhat.com, ard.biesheuvel@linaro.org Date: Mon, 22 Jun 2015 16:30:09 -0700 Message-Id: <1435015811-25912-3-git-send-email-roy.franz@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1435015811-25912-1-git-send-email-roy.franz@linaro.org> References: <1435015811-25912-1-git-send-email-roy.franz@linaro.org> X-Spam-Score: -1.5 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1Z7BAe-0006YI-9O Subject: [edk2] [PATCH 2/4] Treat ASCII 0x7F as backspace for TtyTerm terminals X-BeenThere: edk2-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: edk2-devel@lists.sourceforge.net List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.sourceforge.net X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: roy.franz@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.50 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Treat ASCII 0x7F as backspace, rather than delete, for TTY terminals. This better matches the default Linux terminal settings that are used when connecting to a simulated platform using xterm or a similar terminal program. Signed-off-by: Roy Franz Contributed-under: TianoCore Contribution Agreement 1.0 --- MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c index 17a1244..227df85 100644 --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c @@ -1561,8 +1561,14 @@ UnicodeToEfiKey ( } if (UnicodeChar == DEL) { - Key.ScanCode = SCAN_DELETE; - Key.UnicodeChar = 0; + if (TerminalDevice->TerminalType == TTYTERMTYPE) { + Key.ScanCode = SCAN_NULL; + Key.UnicodeChar = CHAR_BACKSPACE; + } + else { + Key.ScanCode = SCAN_DELETE; + Key.UnicodeChar = 0; + } } else { Key.ScanCode = SCAN_NULL; Key.UnicodeChar = UnicodeChar;