From patchwork Fri Mar 4 10:28:02 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 321 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:41:41 -0000 Delivered-To: patches@linaro.org Received: by 10.224.60.68 with SMTP id o4cs9942qah; Fri, 4 Mar 2011 02:28:03 -0800 (PST) Received: by 10.52.175.101 with SMTP id bz5mr627424vdc.201.1299234482715; Fri, 04 Mar 2011 02:28:02 -0800 (PST) Received: from mail-qw0-f50.google.com (mail-qw0-f50.google.com [209.85.216.50]) by mx.google.com with ESMTPS id b21si2964134vbz.51.2011.03.04.02.28.02 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Mar 2011 02:28:02 -0800 (PST) Received-SPF: neutral (google.com: 209.85.216.50 is neither permitted nor denied by best guess record for domain of linus.walleij@linaro.org) client-ip=209.85.216.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.216.50 is neither permitted nor denied by best guess record for domain of linus.walleij@linaro.org) smtp.mail=linus.walleij@linaro.org Received: by qwk3 with SMTP id 3so1842771qwk.37 for ; Fri, 04 Mar 2011 02:28:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.224.11.20 with SMTP id r20mr287193qar.384.1299234482199; Fri, 04 Mar 2011 02:28:02 -0800 (PST) Received: by 10.224.28.201 with HTTP; Fri, 4 Mar 2011 02:28:02 -0800 (PST) In-Reply-To: <1297895333-5551-1-git-send-email-linus.walleij@linaro.org> References: <1297895333-5551-1-git-send-email-linus.walleij@linaro.org> Date: Fri, 4 Mar 2011 11:28:02 +0100 Message-ID: Subject: Fwd: [PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg() From: Linus Walleij To: Patch Tracking ---------- Forwarded message ---------- From: Linus Walleij Date: Wed, Feb 16, 2011 at 11:28 PM Subject: [PATCH] msm_sdcc: remove needless cache flush after dma_unmap_sg() To: linux-mmc@vger.kernel.org Cc: Sahitya Tummala , San Mehat , Linus Walleij dma_unmap_sg() already flushes the cache, I don't get what this code is doing here. Signed-off-by: Linus Walleij ---  drivers/mmc/host/msm_sdcc.c |    8 --------  1 files changed, 0 insertions(+), 8 deletions(-) -- 1.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c index 153ab97..67b0881 100644 --- a/drivers/mmc/host/msm_sdcc.c +++ b/drivers/mmc/host/msm_sdcc.c @@ -266,14 +266,6 @@ msmsdcc_dma_complete_tlet(unsigned long data)        dma_unmap_sg(mmc_dev(host->mmc), host->dma.sg, host->dma.num_ents,                     host->dma.dir); -       if (host->curr.user_pages) { -               struct scatterlist *sg = host->dma.sg; -               int i; - -               for (i = 0; i < host->dma.num_ents; i++) -                       flush_dcache_page(sg_page(sg++)); -       } -        host->dma.sg = NULL;        host->dma.busy = 0;