From patchwork Wed Aug 28 08:57:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 19558 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f71.google.com (mail-yh0-f71.google.com [209.85.213.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id F133825E58 for ; Wed, 28 Aug 2013 08:57:27 +0000 (UTC) Received: by mail-yh0-f71.google.com with SMTP id c41sf6715486yho.6 for ; Wed, 28 Aug 2013 01:57:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=r86czqKzMStNlJzfYFooDoE/yZRMjQl9Uq1ZJGtRne0=; b=eBlvWBPElf+odvJ7DBf+RJxLK8B7iZU9nV2llKBLz+Uddk1PwjdMnwpKMb4Hx8m/Q1 q+hKfzBMR2+NUClJCbOvzvfEANqyPk3eZL3YNsFh9ajFNVuHTTx24KrX8VQBXovgH0SC VQoZLTwpFqFK/HToyYbK8gJVNxQ+hCdayilSFXqDCappFzjfDDuEOp7HWZ9AZCFWr1Mm +RjwVZH1QjiOJ+6nbevCTnuoVFDyjFck3nh/pQ80FA9Sok6/qMxDS2z3PSJa+H54wdvq FN9168smytDGfKN07IIhyJ5Ti/RxzQL1vvihApMaLxxCFpX7gyewLX9HkvfbWxq3F/8+ Nb2Q== X-Received: by 10.236.174.232 with SMTP id x68mr9651118yhl.42.1377680247470; Wed, 28 Aug 2013 01:57:27 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.24.233 with SMTP id x9ls255944qef.46.gmail; Wed, 28 Aug 2013 01:57:27 -0700 (PDT) X-Received: by 10.52.230.74 with SMTP id sw10mr13298181vdc.6.1377680247264; Wed, 28 Aug 2013 01:57:27 -0700 (PDT) Received: from mail-ve0-f173.google.com (mail-ve0-f173.google.com [209.85.128.173]) by mx.google.com with ESMTPS id wa2si6195966vcb.103.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 28 Aug 2013 01:57:27 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.173; Received: by mail-ve0-f173.google.com with SMTP id cy12so4097145veb.32 for ; Wed, 28 Aug 2013 01:57:27 -0700 (PDT) X-Gm-Message-State: ALoCoQnO/OuXKmXYENXJ+sHXq1taCF+BeHclWoCTMhN7FWxNjUIkvFeMsaf0vpbQE6I6s+3rI7DR X-Received: by 10.52.96.100 with SMTP id dr4mr20373970vdb.17.1377680247146; Wed, 28 Aug 2013 01:57:27 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp343914vcz; Wed, 28 Aug 2013 01:57:26 -0700 (PDT) X-Received: by 10.182.60.70 with SMTP id f6mr5775761obr.61.1377680246056; Wed, 28 Aug 2013 01:57:26 -0700 (PDT) Received: from mail-oa0-f49.google.com (mail-oa0-f49.google.com [209.85.219.49]) by mx.google.com with ESMTPS id f9si7734806obv.75.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 28 Aug 2013 01:57:26 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.219.49 is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) client-ip=209.85.219.49; Received: by mail-oa0-f49.google.com with SMTP id n12so4312348oag.36 for ; Wed, 28 Aug 2013 01:57:25 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.56.3 with SMTP id w3mr15051133oep.37.1377680245473; Wed, 28 Aug 2013 01:57:25 -0700 (PDT) Received: by 10.182.28.168 with HTTP; Wed, 28 Aug 2013 01:57:25 -0700 (PDT) In-Reply-To: References: Date: Wed, 28 Aug 2013 14:27:25 +0530 Message-ID: Subject: Re: [LNG] Re: [ovs-dev] datapath: remove HAVE_MAC_RAW From: Viresh Kumar To: Jesse Gross Cc: "dev@openvswitch.org" , Linaro Networking , Patch Tracking X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 28 August 2013 05:37, Jesse Gross wrote: > On Tue, Aug 27, 2013 at 3:51 AM, Viresh Kumar wrote: >> On 26 August 2013 21:59, Jesse Gross wrote: >> >>> This is compatibility code for older kernels so by definition it >>> doesn't exist in current kernels. You can't just remove it. >> >> My mistake :( >> >> Will something like this makes sense? This was changed in 2.6.22 by >> following patch: >> b0e380b [SK_BUFF]: unions of just one member don't get anything done, kill them > > I suspect that this is just some unrelated key word that was added to > skbuff.h for the RT kernels. I think the best solution would be to > just tighten up the grep expression since that is simpler and clearer > than adding version checks as well. What about this? diff --git a/acinclude.m4 b/acinclude.m4 index 73ee5ce..d55ab14 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -238,7 +238,7 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ # quoting rules. OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [[[^@]]proto_data_valid], [OVS_DEFINE([HAVE_PROTO_DATA_VALID])]) - OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [raw], + OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [\*raw\;], [OVS_DEFINE([HAVE_MAC_RAW])]) OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [skb_dst(], [OVS_DEFINE([HAVE_SKB_DST_ACCESSOR_FUNCS])])