mbox series

[v4,0/9] Support the Capstone disassembler

Message ID 20170928165414.7339-1-richard.henderson@linaro.org
Headers show
Series Support the Capstone disassembler | expand

Message

Richard Henderson Sept. 28, 2017, 4:54 p.m. UTC 
Changes since v3:
  * Adjust how the submodule is detected and invoked.
    - This should fix the reported patchew failure,
    - Fixes e.g. -m32 "cross" compilation, or similar
      abi-changing option sets.


r~


Richard Henderson (9):
  target/i386: Convert to disas_set_info hook
  target/ppc: Convert to disas_set_info hook
  disas: Remove unused flags arguments
  disas: Support the Capstone disassembler library
  i386: Support Capstone in disas_set_info
  arm: Support Capstone in disas_set_info
  ppc: Support Capstone in disas_set_info
  disas: Remove monitor_disas_is_physical
  disas: Add capstone as submodule

 Makefile                      |  13 ++
 include/disas/bfd.h           |   4 +
 include/disas/capstone.h      |  38 ++++++
 include/disas/disas.h         |   4 +-
 include/exec/log.h            |   4 +-
 disas.c                       | 308 ++++++++++++++++++++++++++++++------------
 monitor.c                     |  29 +---
 target/alpha/translate.c      |   2 +-
 target/arm/cpu.c              |  21 ++-
 target/arm/translate-a64.c    |   3 +-
 target/arm/translate.c        |   3 +-
 target/cris/translate.c       |   3 +-
 target/hppa/translate.c       |   2 +-
 target/i386/cpu.c             |  19 +++
 target/i386/translate.c       |   8 +-
 target/lm32/translate.c       |   2 +-
 target/m68k/translate.c       |   2 +-
 target/microblaze/translate.c |   2 +-
 target/mips/translate.c       |   2 +-
 target/nios2/translate.c      |   2 +-
 target/openrisc/translate.c   |   2 +-
 target/ppc/translate.c        |   5 +-
 target/ppc/translate_init.c   |  27 ++++
 target/s390x/translate.c      |   2 +-
 target/sh4/translate.c        |   2 +-
 target/sparc/translate.c      |   2 +-
 target/tricore/translate.c    |   2 +-
 target/unicore32/translate.c  |   2 +-
 target/xtensa/translate.c     |   2 +-
 .gitmodules                   |   3 +
 capstone                      |   1 +
 configure                     |  36 +++++
 32 files changed, 406 insertions(+), 151 deletions(-)
 create mode 100644 include/disas/capstone.h
 create mode 160000 capstone

-- 
2.13.5

Comments

Peter Maydell Oct. 12, 2017, 12:34 p.m. UTC | #1 
On 28 September 2017 at 17:54, Richard Henderson
<richard.henderson@linaro.org> wrote:
> Changes since v3:

>   * Adjust how the submodule is detected and invoked.

>     - This should fix the reported patchew failure,

>     - Fixes e.g. -m32 "cross" compilation, or similar

>       abi-changing option sets.

>

>

> r~

>

>

> Richard Henderson (9):

>   target/i386: Convert to disas_set_info hook

>   target/ppc: Convert to disas_set_info hook

>   disas: Remove unused flags arguments

>   disas: Support the Capstone disassembler library

>   i386: Support Capstone in disas_set_info

>   arm: Support Capstone in disas_set_info

>   ppc: Support Capstone in disas_set_info

>   disas: Remove monitor_disas_is_physical

>   disas: Add capstone as submodule


I think the "add as submodule" patch might want to be
revised in the light of the changes to handling of
submodules that the current UI pull request is making,
but are the first 8 patches here more or less ready to
go in?

My other issue with patch 9 is that I think all our
submodules should be for git repos hosted on
git.qemu.org (ie mirrored from somewhere else). So
we should get capstone mirrored first and then use it.

thanks
-- PMM
Richard Henderson Oct. 12, 2017, 2:49 p.m. UTC | #2 
On 10/12/2017 05:34 AM, Peter Maydell wrote:
> I think the "add as submodule" patch might want to be

> revised in the light of the changes to handling of

> submodules that the current UI pull request is making,

> but are the first 8 patches here more or less ready to

> go in?


Yes, the first 8 are ready.

I'll fix up the 9th to follow the UI modules changes, and the new mirror.


r~