From patchwork Wed Nov 8 15:32:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 118283 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp5436304qgn; Wed, 8 Nov 2017 07:35:46 -0800 (PST) X-Google-Smtp-Source: ABhQp+QGAswXDlO6FKjVjlwZ98Be02G2d32ANvayQcziQqZz/zSLqieerlH4l0NL4NXlNcUguX2h X-Received: by 10.129.196.77 with SMTP id s13mr599292ywj.430.1510155346174; Wed, 08 Nov 2017 07:35:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510155346; cv=none; d=google.com; s=arc-20160816; b=f51W15k4Vs+vAaURTX/xzSvKThGKH/HraLAdwwyHE2WiTmWc9Y1SL1Vz+w84iJ/Rsf MWz7sXVQL+IQQSjxrGSP5mcORZqG+pmKPiA5aKV5HfomBxglB2YjkYwaCN7qthVKOsWd EZHaH/QucvAS3eVxPo88YzosLeABno9F3AxWsJdyqhnWXI5905UzXY7wSMIOlLiqhveB BZXZ+rdYv1Afx9HMGiEwj5K/TPWc8OPZmUFPSNaOOg5byLpN1vA7rSg7WKyi/ju824rm y/ENB8CFgIrZBy4uJbXGmXX0Bq1o2rvJy7aElpeGNCr6SxGoRipup9zynL/PU6M6ZCB+ hDCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:message-id:date:to:from :dkim-signature:arc-authentication-results; bh=b/5k/Ymy6gjo9gHNYaojlB04BuoV2GQZhJnCBn9w8y8=; b=KsLao/X12kjYjJj3jounI71kE7ejUbUL1WyByH0hDH4QD6yuQvbEfz6BML+aZSKzvl EDCu/llYSgI8JdLmd3m/kkOT06I5aDmAQrbPzYc7nXbhf2lwk8IgOsAt7491NEuVFbjy 5lXCWXBnwW/cVywK8aa6XIK7dcTdVp5XeBSgC0FgD7f/SrQV0MIWDFxn6jq9LxpmKijw KSV7PAgna8jnfzt1djZGrFadJFae+0rAU2gCU8gVT9dRtaxnMFLWbw8yb0EEgaTCKYpH t5ZWBvc+yEl32nQsEVmG3PIv86axlrAuuL2lMO31n+ph74gW+rzJT2BDg1IiVLwXm1JD tPVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Z60shCnl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id q2si982355ybk.92.2017.11.08.07.35.46 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 08 Nov 2017 07:35:46 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Z60shCnl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:60467 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCSOH-0001VL-Is for patch@linaro.org; Wed, 08 Nov 2017 10:35:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCSLU-0000OY-6m for qemu-devel@nongnu.org; Wed, 08 Nov 2017 10:32:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCSLR-000262-44 for qemu-devel@nongnu.org; Wed, 08 Nov 2017 10:32:52 -0500 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:52704) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCSLQ-00025W-T5 for qemu-devel@nongnu.org; Wed, 08 Nov 2017 10:32:49 -0500 Received: by mail-wr0-x243.google.com with SMTP id j23so2772256wra.9 for ; Wed, 08 Nov 2017 07:32:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b/5k/Ymy6gjo9gHNYaojlB04BuoV2GQZhJnCBn9w8y8=; b=Z60shCnlhWXwHLu1esvGGEZvbf5XhotHbgKgiT+Du9S8q/CJbWfIGui3vcKuzHpNGJ RpkQqohfGTzT+fwB1AV7ufaPytkq68/e9aIMM+4UzChUcp0Szc/Yol7uH8zjNDJUtB4F FwiIQZrhfVJfSJIka/WXdMafvT33nyCKRi7CQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b/5k/Ymy6gjo9gHNYaojlB04BuoV2GQZhJnCBn9w8y8=; b=PuF1/uWbzjoVLCByTLqzXkwtUWwYBSjjPnrMB+qNOXhlYocfHt2UsPXXcd/TH8w2ea Xo8Agxny1sxkcv1p3bghTOTQMqFYM75kJPfa/3BRUl+zl6xytDiZGs6DGpSqfHVS9EZE Qo5kFQsVxDayLsXZgUcNPC/8M+aV21jozUiGrwsLtupg3UGzdR3WgUwJMZ2OwGGj9hys 9KfRp8jcjXahdUOHn8oSBD+D1l6S+uWOfuOydFfsZ8ejGIpPzBJ+Cq5b1Src1Hq8E+xv bd5ZKjZTLthUxwfm2rlujkdL4Cv6DQy1HCHpQzmkY8TZJqg35KT2Wvu54Qv4BlTIeJs6 uEyg== X-Gm-Message-State: AJaThX6ZjPJZ7XRyf2DeQO0ogSxQsUJNs4SoN68odyOZu2Chz2u27/+4 QdiOoAHA66E7495ihDZUPLGqVA== X-Received: by 10.223.196.247 with SMTP id o52mr798737wrf.119.1510155167134; Wed, 08 Nov 2017 07:32:47 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id p81sm6836306wrc.61.2017.11.08.07.32.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Nov 2017 07:32:46 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id A42133E009E; Wed, 8 Nov 2017 15:32:45 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Wed, 8 Nov 2017 15:32:43 +0000 Message-Id: <20171108153245.20740-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.14.2 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::243 Subject: [Qemu-devel] [PATCH v2 0/2] fixing translation time segfaults X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Hi, This is a follow up to the patch I posted yesterday. I've made some clean-ups to the comments and logic as suggested from the review. Additionally I've added a clean-up patch which tidied up all the call-sites which no longer need to check retaddr/pc before calling cpu_restore_state. Alex Bennée (2): accel/tcg/translate-all: expand cpu_restore_state addr check target/*helper: don't check retaddr before calling cpu_restore_state accel/tcg/translate-all.c | 52 +++++++++++++++++------------- include/exec/exec-all.h | 11 +++++++ scripts/coccinelle/cpu_restore_state.cocci | 12 +++++++ target/alpha/mem_helper.c | 12 ++----- target/arm/op_helper.c | 17 +++------- target/i386/svm_helper.c | 4 +-- target/lm32/op_helper.c | 7 ++-- target/m68k/op_helper.c | 7 ++-- target/microblaze/op_helper.c | 7 ++-- target/moxie/helper.c | 4 +-- target/nios2/mmu.c | 7 ++-- target/openrisc/mmu_helper.c | 7 ++-- target/s390x/excp_helper.c | 4 +-- target/tricore/op_helper.c | 11 ++----- target/unicore32/op_helper.c | 7 ++-- 15 files changed, 77 insertions(+), 92 deletions(-) create mode 100644 scripts/coccinelle/cpu_restore_state.cocci -- 2.14.2