From patchwork Tue May 1 18:04:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 134787 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp5236856lji; Tue, 1 May 2018 11:06:43 -0700 (PDT) X-Google-Smtp-Source: AB8JxZruvUv3r/z17WhXqyZesQF8BkA9hDeBmo/eogq3PNs+5KJkXgc2uxZjZ4L9199c5Fd4ZctX X-Received: by 10.55.157.205 with SMTP id g196mr12682675qke.107.1525198002934; Tue, 01 May 2018 11:06:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525198002; cv=none; d=google.com; s=arc-20160816; b=o9CG3agZf5hWjkTFUiOeXlaLMbabVcb60yKj5hsc+7FQgFAN0pcb21342h3LzdNpAk YdBNo0r0nMlj5+3crzhnxnvgOu75CzcSau8kVYRyeqGmBuK+wNSF3fhXCXCxcGLCGPjs q7FLrkSpSPXloK0cZEhv67vcY6EG6mGA4A2wCyniXwQLJqwiPTrpGQOewjkWl0UrRCij F4qouMzVRhjufrMoPFpmZfrvNXE+B/pPEx6kru3aIgPGV+YkJQRF/H4Mlb4/zhTx1UWx VbbtAzWLWPzJhtu8F0roHR5s+aTEVar/Z/+MrgFM/JwKeoSeYBoufUmEXHr6Y+qghm5X NSJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:to:from :dkim-signature:arc-authentication-results; bh=V1LlPnp9vNZHiPhtR+RK7W+cN80g2Hnuxhx3TU51Om4=; b=msVm50G9TSRvz4qfx3GEDIKI6YBKPUajOdhgL5ho79agILctJ0xJbPFC/mSd1Vawdr x96QrgRPGBqEfH79VmaTP0m75/eanBrB5UQIj3qr0D/zaz51GNhHEUmRenlvTrjixI52 mFxC1AXKnSXdT/5yme7JLs2OpTItn3gPw9bVPy+6Q4jkZnPopBFPKw/aBEQy+TL9b8G6 dO72BG7qNFMhZK8PxK/uzR2/NfOeNMuSYanc/lXbJCHW9oOkXETDThj0KSMIz8v6+ZNX 4UTWp3YzXqN8W/iB9qfk5oQCuV1bjWU7w/6wMsFjVT8NMWzb9cjtz9z3aSwDcOfuKRn+ M0bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eCDb8j3F; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id e30-v6si5097401qtg.171.2018.05.01.11.06.42 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 01 May 2018 11:06:42 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eCDb8j3F; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45543 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDZfm-0000i4-H5 for patch@linaro.org; Tue, 01 May 2018 14:06:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDZeC-0008HY-GS for qemu-devel@nongnu.org; Tue, 01 May 2018 14:05:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDZe9-0000YV-9M for qemu-devel@nongnu.org; Tue, 01 May 2018 14:05:04 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:37417) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDZe8-0000Xj-VY for qemu-devel@nongnu.org; Tue, 01 May 2018 14:05:01 -0400 Received: by mail-pf0-x243.google.com with SMTP id e9so5636899pfi.4 for ; Tue, 01 May 2018 11:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=V1LlPnp9vNZHiPhtR+RK7W+cN80g2Hnuxhx3TU51Om4=; b=eCDb8j3FsTOworYmkV65ymvxdKj5vPbc7ZU5kC+SwQB60KXo7np0gVBnuGD+QFtu9/ T3bSIERZuM8l+EFL2gmE/R2Qaaf+xSZ7w9BDKw5iSxc195cIfibJuZA17fc1GzNIqcJP wzfhLKk3jA8qd2YfVDh4+vvU6ANZKdcIWAWpA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=V1LlPnp9vNZHiPhtR+RK7W+cN80g2Hnuxhx3TU51Om4=; b=WGtzbpIix56xkpQdMl/PZ9G0iQHvcUq7CQdo1bA4EH8CoOSlZcSQAqU+rCofHhzsm3 MCHHU5Y63Nk8Gvw+2le3cAHqnJrGPyqBLqfTad8J20GEjFbsdFKYoc0b4/FXHGc1rEFM J/C611R/9ho97Wsi/3R5ERtz2TbhNSIKxU8eMoy4NBA8gs1gwRz/3f+rcBeA5KZm2AU7 xR0JWYi/EFtfwcls3QB/WWK2UaHQ8Bym1Hz2VkGaG9tP0SDK6jqePXCjGwsyJdj3EFwu iI2jK+QJfkP9tHhWcgi9LHZIML9WmdOH0wgN3/cfXrXEwxDCm8RUYCSHKZZgTZjs1Umr 9y6Q== X-Gm-Message-State: ALQs6tDuCdi3aPSvUG7ldLf8RDlUcrQyUAB8JS/zLT53Emv4koX0dfSH 8N5n1ekJvWn3UjGx8Ue5a0CupovhAeg= X-Received: by 10.98.73.215 with SMTP id r84mr15049723pfi.146.1525197899254; Tue, 01 May 2018 11:04:59 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id j5sm23732224pfe.119.2018.05.01.11.04.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 11:04:58 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 1 May 2018 11:04:53 -0700 Message-Id: <20180501180455.11214-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PATCH 0/2] target/arm: Coverity fixups X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The first patch covers four related false positives. However, we check the same condition twice and we certainly don't need to that. Plus the assert might just help documentation-wise. The second patch covers dead code. I believe that Coverity is right and that there are no paths that have !is_q at this point. Add the assert to check that is true. The RISU tests that I ran over these insns came out clean. r~ Richard Henderson (2): target/arm: Tidy conditions in handle_vec_simd_shri target/arm: Tidy condition in disas_simd_two_reg_misc target/arm/translate-a64.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.14.3