| Message ID | 20181031165321.4422-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | decodetree improvements | expand |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20181031165321.4422-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PULL 0/3] decodetree improvements
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
cb5d408f30 decodetree: Allow multiple input files
68998e1b57 decodetree: Remove "insn" argument from trans_* expanders
572d4f99b8 decodetree: Add !extern flag to argument sets
=== OUTPUT BEGIN ===
Checking PATCH 1/3: decodetree: Add !extern flag to argument sets...
Checking PATCH 2/3: decodetree: Remove "insn" argument from trans_* expanders...
ERROR: spaces required around that '*' (ctx:WxV)
#122: FILE: target/arm/translate-sve.c:372:
+static bool trans_##NAME##_zpzz(DisasContext *s, arg_rprr_esz *a) \
^
ERROR: spaces required around that '*' (ctx:WxV)
#131: FILE: target/arm/translate-sve.c:404:
+static bool trans_SDIV_zpzz(DisasContext *s, arg_rprr_esz *a)
^
ERROR: spaces required around that '*' (ctx:WxV)
#158: FILE: target/arm/translate-sve.c:450:
+static bool trans_##NAME(DisasContext *s, arg_rpr_esz *a) \
^
ERROR: spaces required around that '*' (ctx:WxV)
#167: FILE: target/arm/translate-sve.c:467:
+static bool trans_FABS(DisasContext *s, arg_rpr_esz *a)
^
ERROR: spaces required around that '*' (ctx:WxV)
#331: FILE: target/arm/translate-sve.c:851:
+static bool trans_##NAME(DisasContext *s, arg_rprrr_esz *a) \
^
ERROR: spaces required around that '*' (ctx:WxV)
#1442: FILE: target/arm/translate-sve.c:3981:
+static bool trans_##NAME(DisasContext *s, arg_rprrr_esz *a) \
^
ERROR: spaces required around that '*' (ctx:WxV)
#1950: FILE: target/openrisc/disas.c:55:
+static bool trans_l_##opcode(disassemble_info *info, arg_l_##opcode *a) \
^
ERROR: spaces required around that '*' (ctx:WxV)
#1950: FILE: target/openrisc/disas.c:55:
+static bool trans_l_##opcode(disassemble_info *info, arg_l_##opcode *a) \
^
ERROR: spaces required around that '*' (ctx:WxV)
#1968: FILE: target/openrisc/disas.c:149:
+static bool trans_lf_##opcode##_##suffix(disassemble_info *info, \
^
ERROR: spaces required around that '*' (ctx:WxV)
#1969: FILE: target/openrisc/disas.c:150:
+ arg_lf_##opcode##_##suffix *a) \
^
total: 10 errors, 0 warnings, 2539 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/3: decodetree: Allow multiple input files...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On 31 October 2018 at 16:53, Richard Henderson <richard.henderson@linaro.org> wrote: > The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: > > Merge remote-tracking branch 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging (2018-10-30 15:49:55 +0000) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-dt-20181031 > > for you to fetch changes up to 6699ae6a8e74381583622502db8bd47fac381c9e: > > decodetree: Allow multiple input files (2018-10-31 16:48:58 +0000) > > ---------------------------------------------------------------- > Updates to decodetree.py for risc-v. > > ---------------------------------------------------------------- > Richard Henderson (3): > decodetree: Add !extern flag to argument sets > decodetree: Remove "insn" argument from trans_* expanders > decodetree: Allow multiple input files Applied, thanks. -- PMM
The following changes since commit a2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd: Merge remote-tracking branch 'remotes/vivier2/tags/qemu-trivial-for-3.1-pull-request' into staging (2018-10-30 15:49:55 +0000) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-dt-20181031 for you to fetch changes up to 6699ae6a8e74381583622502db8bd47fac381c9e: decodetree: Allow multiple input files (2018-10-31 16:48:58 +0000) ---------------------------------------------------------------- Updates to decodetree.py for risc-v. ---------------------------------------------------------------- Richard Henderson (3): decodetree: Add !extern flag to argument sets decodetree: Remove "insn" argument from trans_* expanders decodetree: Allow multiple input files target/arm/translate-sve.c | 507 +++++++++++++++++++++----------------------- target/openrisc/disas.c | 23 +- target/openrisc/translate.c | 200 ++++++++--------- scripts/decodetree.py | 64 +++--- 4 files changed, 395 insertions(+), 399 deletions(-)