| Message ID | 20190828165307.18321-1-alex.bennee@linaro.org |
|---|---|
| Headers | show |
| Series | arm semih-hosting cleanups and other misc cleanups | expand |
On 8/28/19 6:52 PM, Alex Bennée wrote: > Hi Peter, > > Here are the ARM semi-hosting cleanup patches and a small selection of > miscellaneous TCG clean-ups. If your happy taking them all through > your tree please do otherwise I'll poke Richard. I'm just trying to > reduce the delta for my next iteration of the plugin series. > > The following patches need review > 04 - target arm remove run time semihosting checks > 05 - includes remove stale smp max _cpus externs > > The first is the result of review comments, moving CONFIG_TCG ifdefs > around and the second is pretty trivial. > > Alex Bennée (7): > target/arm: handle M-profile semihosting at translate time > target/arm: handle A-profile T32 semihosting at translate time > target/arm: handle A-profile A32 semihosting at translate time > target/arm: remove run time semihosting checks > includes: remove stale [smp|max]_cpus externs > accel/stubs: reduce headers from tcg-stub > include/exec/cpu-defs.h: fix typo > > Emilio G. Cota (2): > tcg/README: fix typo s/afterwise/afterwards/ > atomic_template: fix indentation in GEN_ATOMIC_HELPER Thanks for cleaning this! Series except patch #8 which you dropped: Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On Wed, 28 Aug 2019 at 18:08, Alex Bennée <alex.bennee@linaro.org> wrote: > > Hi Peter, > > Here are the ARM semi-hosting cleanup patches and a small selection of > miscellaneous TCG clean-ups. If your happy taking them all through > your tree please do otherwise I'll poke Richard. I'm just trying to > reduce the delta for my next iteration of the plugin series. > > The following patches need review > 04 - target arm remove run time semihosting checks > 05 - includes remove stale smp max _cpus externs > > The first is the result of review comments, moving CONFIG_TCG ifdefs > around and the second is pretty trivial. > > Alex Bennée (7): > target/arm: handle M-profile semihosting at translate time > target/arm: handle A-profile T32 semihosting at translate time > target/arm: handle A-profile A32 semihosting at translate time > target/arm: remove run time semihosting checks > includes: remove stale [smp|max]_cpus externs > accel/stubs: reduce headers from tcg-stub > include/exec/cpu-defs.h: fix typo > > Emilio G. Cota (2): > tcg/README: fix typo s/afterwise/afterwards/ > atomic_template: fix indentation in GEN_ATOMIC_HELPER Series, except for patch 8, applied to target-arm.next. thanks -- PMM
On Wed, 28 Aug 2019 at 18:08, Alex Bennée <alex.bennee@linaro.org> wrote: > > Hi Peter, > > Here are the ARM semi-hosting cleanup patches and a small selection of > miscellaneous TCG clean-ups. If your happy taking them all through > your tree please do otherwise I'll poke Richard. I'm just trying to > reduce the delta for my next iteration of the plugin series. > > The following patches need review > 04 - target arm remove run time semihosting checks > 05 - includes remove stale smp max _cpus externs > > The first is the result of review comments, moving CONFIG_TCG ifdefs > around and the second is pretty trivial. > > Alex Bennée (7): > target/arm: handle M-profile semihosting at translate time > target/arm: handle A-profile T32 semihosting at translate time > target/arm: handle A-profile A32 semihosting at translate time On closer testing, this patch breaks the semihosting test suite: $ /home/petmay01/linaro/qemu-from-laptop/qemu/build/arm-clang//arm-linux-user/qemu-arm usertest-a32 hello world via semi_write0 qemu: uncaught target signal 11 (Segmentation fault) - core dumped Segmentation fault (core dumped) so I'm unqueueing the first 4 patches (but have kept the misc unrelated other fixes). thanks -- PMM
Peter Maydell <peter.maydell@linaro.org> writes: > On Wed, 28 Aug 2019 at 18:08, Alex Bennée <alex.bennee@linaro.org> wrote: >> >> Hi Peter, >> >> Here are the ARM semi-hosting cleanup patches and a small selection of >> miscellaneous TCG clean-ups. If your happy taking them all through >> your tree please do otherwise I'll poke Richard. I'm just trying to >> reduce the delta for my next iteration of the plugin series. >> >> The following patches need review >> 04 - target arm remove run time semihosting checks >> 05 - includes remove stale smp max _cpus externs >> >> The first is the result of review comments, moving CONFIG_TCG ifdefs >> around and the second is pretty trivial. >> >> Alex Bennée (7): >> target/arm: handle M-profile semihosting at translate time >> target/arm: handle A-profile T32 semihosting at translate time >> target/arm: handle A-profile A32 semihosting at translate time > > On closer testing, this patch breaks the semihosting test suite: > > $ /home/petmay01/linaro/qemu-from-laptop/qemu/build/arm-clang//arm-linux-user/qemu-arm > usertest-a32 > hello world via semi_write0 > qemu: uncaught target signal 11 (Segmentation fault) - core dumped > Segmentation fault (core dumped) That must of broken on re-base, I'll re-spin and fix. > > so I'm unqueueing the first 4 patches (but have kept the > misc unrelated other fixes). > > thanks > -- PMM -- Alex Bennée