From patchwork Tue Sep 22 21:21:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Snow X-Patchwork-Id: 273027 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F0C8C2D0E2 for ; Tue, 22 Sep 2020 22:03:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC22E20B1F for ; Tue, 22 Sep 2020 22:03:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H9ilRlPK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC22E20B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kKqNG-0006FH-CW for qemu-devel@archiver.kernel.org; Tue, 22 Sep 2020 18:02:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kKpj3-00038f-Px for qemu-devel@nongnu.org; Tue, 22 Sep 2020 17:21:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kKpj1-00074j-SV for qemu-devel@nongnu.org; Tue, 22 Sep 2020 17:21:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600809683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X+Rbeql97Nua52db8mYi11B7/W48z48bdtrk2XfVR7w=; b=H9ilRlPKhpxrRc47dDM+bpAepdfTpnerqkzbWhUJrjk3gcGQPI3jcGBZX1Qqpi7RFv8Fev kngpJ6G7ddW70/ndiiXQfDNj9CLSadegOMt1/llZxNGCz8JCKXop5tpVNIRnHpQyfR22kT nTWrdOPTlZzl0N3Fl3VYaMBOvpYDnak= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-nEbkCAXbMLGUx5xPQ1ATPw-1; Tue, 22 Sep 2020 17:21:20 -0400 X-MC-Unique: nEbkCAXbMLGUx5xPQ1ATPw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ED559186DD27; Tue, 22 Sep 2020 21:21:19 +0000 (UTC) Received: from scv.redhat.com (ovpn-119-140.rdu2.redhat.com [10.10.119.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id C56515DA7B; Tue, 22 Sep 2020 21:21:15 +0000 (UTC) From: John Snow To: Markus Armbruster Subject: [PATCH 0/6] qapi: static typing conversion, pt4 Date: Tue, 22 Sep 2020 17:21:09 -0400 Message-Id: <20200922212115.4084301-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/22 02:07:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , qemu-devel@nongnu.org, John Snow , Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" based-on: <20200922211802.4083666-1-jsnow@redhat.com> [PATCH 00/14] qapi: static typing conversion, pt3 Hi, this series adds static type hints to the QAPI module. This is part four! Part 4: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt4 Everything: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt6 - Requires Python 3.6+ - Requires mypy 0.770 or newer (for type analysis only) - Requires pylint 2.6.0 or newer (for lint checking only) This part of the series focuses on error.py. Type hints are added in patches that add *only* type hints and change no other behavior. Any necessary changes to behavior to accommodate typing are split out into their own tiny patches. Every commit should pass with: - flake8 qapi/ - pylint --rcfile=qapi/pylintrc qapi/ - mypy --config-file=qapi/mypy.ini qapi/ John Snow (6): qapi/error.py: refactor error classes qapi/parser.py: remove parser context from QAPIDoc qapi/error.py: move QAPIParseError to parser.py qapi/parser.py: refactor QAPIParseError qapi/error.py: enable mypy checks qapi/error.py: enable pylint checks scripts/qapi/error.py | 41 +++++++------- scripts/qapi/main.py | 2 +- scripts/qapi/mypy.ini | 5 -- scripts/qapi/parser.py | 120 ++++++++++++++++++++++++----------------- scripts/qapi/pylintrc | 3 +- scripts/qapi/schema.py | 4 +- 6 files changed, 94 insertions(+), 81 deletions(-) -- 2.26.2