mbox series

[0/4] Enable plugin support on msys2/mingw

Message ID 20200926140415.1286-1-luoyonggang@gmail.com
Headers show
Series Enable plugin support on msys2/mingw | expand

Message

罗勇刚(Yonggang Luo) Sept. 26, 2020, 2:04 p.m. UTC 
Add this feature on msys2/mingw by using glib provided cross-platform dlsym f=
unctional.

Yonggang Luo (4):
  plugins: Fixes a issue when dlsym failed, the handle not closed.
  plugin: Fixes compiling errors on msys2/mingw
  Getting qemu-plugin works under win32.
  cirrus: Enable plugin in cirrus for windows

 .cirrus.yml                  |   3 +-
 Makefile                     |   1 -
 configure                    |  71 --------------
 contrib/plugins/hotblocks.c  |   4 +-
 contrib/plugins/hotpages.c   |   2 +
 contrib/plugins/howvec.c     |   2 +
 contrib/plugins/lockstep.c   |   2 +
 include/qemu/qemu-plugin.h   | 184 ++++++++++++++++++++++++++---------
 meson.build                  |   6 +-
 plugins/api.c                |  65 +++++++------
 plugins/core.c               |   7 +-
 plugins/loader.c             |  21 ++++
 plugins/meson.build          |  10 +-
 plugins/qemu-plugins.symbols |  40 --------
 tests/plugin/bb.c            |   6 +-
 tests/plugin/empty.c         |   2 +
 tests/plugin/insn.c          |   2 +
 tests/plugin/mem.c           |   2 +
 18 files changed, 224 insertions(+), 206 deletions(-)
 delete mode 100644 plugins/qemu-plugins.symbols

--=20
2.28.0.windows.1

Comments

Philippe Mathieu-Daudé Sept. 26, 2020, 8:30 p.m. UTC | #1 
On 9/26/20 4:04 PM, Yonggang Luo wrote:
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>

Superfluous trailing '.' in patch subject.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  plugins/loader.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/plugins/loader.c b/plugins/loader.c
> index 685d334e1a..8ac5dbc20f 100644
> --- a/plugins/loader.c
> +++ b/plugins/loader.c
> @@ -235,6 +235,7 @@ static int plugin_load(struct qemu_plugin_desc *desc, const qemu_info_t *info)
>      return rc;
>  
>   err_symbol:
> +    g_module_close(ctx->handle);
>   err_dlopen:
>      qemu_vfree(ctx);
>      return 1;
>