mbox series

[v4,0/5] pseries NUMA distance calculation

Message ID 20201007172849.302240-1-danielhb413@gmail.com
Headers show
Series pseries NUMA distance calculation | expand

Message

Daniel Henrique Barboza Oct. 7, 2020, 5:28 p.m. UTC
This forth version is based on review comments and suggestion
from David in v3.

changes from v3:
- patch 4:
    * copied the explanation in spapr_numa_define_associativity_domains()
      to the commit message
    * return numa_level directly instead of calculating a temp
      value in spapr_numa_get_numa_level()
    * we're now setting assoc_src in all n_levels above it in 
      spapr_numa_define_associativity_domains()
- patch 5:
    * changed the documentation as suggested by David

v3 link: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg10443.html

Daniel Henrique Barboza (5):
  spapr: add spapr_machine_using_legacy_numa() helper
  spapr_numa: forbid asymmetrical NUMA setups
  spapr_numa: change reference-points and maxdomain settings
  spapr_numa: consider user input when defining associativity
  specs/ppc-spapr-numa: update with new NUMA support

 capstone                      |   2 +-
 docs/specs/ppc-spapr-numa.rst | 235 ++++++++++++++++++++++++++++++++--
 hw/ppc/spapr.c                |  12 ++
 hw/ppc/spapr_numa.c           | 185 ++++++++++++++++++++++++--
 include/hw/ppc/spapr.h        |   2 +
 5 files changed, 419 insertions(+), 17 deletions(-)

Comments

Greg Kurz Oct. 8, 2020, 9:13 a.m. UTC | #1
On Wed,  7 Oct 2020 14:28:44 -0300
Daniel Henrique Barboza <danielhb413@gmail.com> wrote:

> This forth version is based on review comments and suggestion


Series for SLOF ? ;-) ;-) ;-)

> from David in v3.

> 

> changes from v3:

> - patch 4:

>     * copied the explanation in spapr_numa_define_associativity_domains()

>       to the commit message

>     * return numa_level directly instead of calculating a temp

>       value in spapr_numa_get_numa_level()

>     * we're now setting assoc_src in all n_levels above it in 

>       spapr_numa_define_associativity_domains()

> - patch 5:

>     * changed the documentation as suggested by David

> 

> v3 link: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg10443.html

> 

> Daniel Henrique Barboza (5):

>   spapr: add spapr_machine_using_legacy_numa() helper

>   spapr_numa: forbid asymmetrical NUMA setups

>   spapr_numa: change reference-points and maxdomain settings

>   spapr_numa: consider user input when defining associativity

>   specs/ppc-spapr-numa: update with new NUMA support

> 

>  capstone                      |   2 +-

>  docs/specs/ppc-spapr-numa.rst | 235 ++++++++++++++++++++++++++++++++--

>  hw/ppc/spapr.c                |  12 ++

>  hw/ppc/spapr_numa.c           | 185 ++++++++++++++++++++++++--

>  include/hw/ppc/spapr.h        |   2 +

>  5 files changed, 419 insertions(+), 17 deletions(-)

>
Daniel Henrique Barboza Oct. 8, 2020, 11:07 a.m. UTC | #2
On 10/8/20 6:13 AM, Greg Kurz wrote:
> On Wed,  7 Oct 2020 14:28:44 -0300

> Daniel Henrique Barboza <danielhb413@gmail.com> wrote:

> 

>> This forth version is based on review comments and suggestion

> 

> Series for SLOF ? ;-) ;-) ;-)



hahahaha sad thing is that a typo in "fourth" is the only viable
way for me to send a Forth series. SLOF is too damn hard!




> 

>> from David in v3.

>>

>> changes from v3:

>> - patch 4:

>>      * copied the explanation in spapr_numa_define_associativity_domains()

>>        to the commit message

>>      * return numa_level directly instead of calculating a temp

>>        value in spapr_numa_get_numa_level()

>>      * we're now setting assoc_src in all n_levels above it in

>>        spapr_numa_define_associativity_domains()

>> - patch 5:

>>      * changed the documentation as suggested by David

>>

>> v3 link: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg10443.html

>>

>> Daniel Henrique Barboza (5):

>>    spapr: add spapr_machine_using_legacy_numa() helper

>>    spapr_numa: forbid asymmetrical NUMA setups

>>    spapr_numa: change reference-points and maxdomain settings

>>    spapr_numa: consider user input when defining associativity

>>    specs/ppc-spapr-numa: update with new NUMA support

>>

>>   capstone                      |   2 +-

>>   docs/specs/ppc-spapr-numa.rst | 235 ++++++++++++++++++++++++++++++++--

>>   hw/ppc/spapr.c                |  12 ++

>>   hw/ppc/spapr_numa.c           | 185 ++++++++++++++++++++++++--

>>   include/hw/ppc/spapr.h        |   2 +

>>   5 files changed, 419 insertions(+), 17 deletions(-)

>>

>
David Gibson Oct. 8, 2020, 11:52 p.m. UTC | #3
On Wed, Oct 07, 2020 at 02:28:44PM -0300, Daniel Henrique Barboza wrote:
> This forth version is based on review comments and suggestion

> from David in v3.

> 

> changes from v3:

> - patch 4:

>     * copied the explanation in spapr_numa_define_associativity_domains()

>       to the commit message

>     * return numa_level directly instead of calculating a temp

>       value in spapr_numa_get_numa_level()

>     * we're now setting assoc_src in all n_levels above it in 

>       spapr_numa_define_associativity_domains()

> - patch 5:

>     * changed the documentation as suggested by David

> 

> v3 link:

> https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg10443.html


Applied to ppc-for-5.2, thanks.

> 

> Daniel Henrique Barboza (5):

>   spapr: add spapr_machine_using_legacy_numa() helper

>   spapr_numa: forbid asymmetrical NUMA setups

>   spapr_numa: change reference-points and maxdomain settings

>   spapr_numa: consider user input when defining associativity

>   specs/ppc-spapr-numa: update with new NUMA support

> 

>  capstone                      |   2 +-

>  docs/specs/ppc-spapr-numa.rst | 235 ++++++++++++++++++++++++++++++++--

>  hw/ppc/spapr.c                |  12 ++

>  hw/ppc/spapr_numa.c           | 185 ++++++++++++++++++++++++--

>  include/hw/ppc/spapr.h        |   2 +

>  5 files changed, 419 insertions(+), 17 deletions(-)

> 


-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson