mbox series

[PULL,0/8] NBD patches through 2020-10-08

Message ID 20201008185951.1026052-1-eblake@redhat.com
Headers show
Series NBD patches through 2020-10-08 | expand

Message

Eric Blake Oct. 8, 2020, 6:59 p.m. UTC
The following changes since commit e64cf4d569f6461d6b9072e00d6e78d0ab8bd4a7:

  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20201008' into staging (2020-10-08 17:18:46 +0100)

are available in the Git repository at:

  https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2020-10-08

for you to fetch changes up to 82cd3c26889adbd41756de121d38a3aa7c9351c7:

  nbd: Simplify meta-context parsing (2020-10-08 13:35:07 -0500)

----------------------------------------------------------------
nbd patches for 2020-10-08

- silence compilation warnings
- more fixes to prevent reconnect hangs
- improve 'qemu-nbd' termination behavior
- cleaner NBD protocol compliance on string handling

----------------------------------------------------------------
Christian Borntraeger (1):
      nbd: silence maybe-uninitialized warnings

Eric Blake (3):
      qemu-nbd: Honor SIGINT and SIGHUP
      nbd/server: Reject embedded NUL in NBD strings
      nbd: Simplify meta-context parsing

Vladimir Sementsov-Ogievskiy (4):
      block/nbd: fix drain dead-lock because of nbd reconnect-delay
      block/nbd: correctly use qio_channel_detach_aio_context when needed
      block/nbd: fix reconnect-delay
      block/nbd: nbd_co_reconnect_loop(): don't connect if drained

 block/nbd.c  |  71 ++++++++++++++++---
 nbd/server.c | 221 ++++++++++++++++++++++++-----------------------------------
 qemu-nbd.c   |  11 +--
 3 files changed, 155 insertions(+), 148 deletions(-)

Comments

Peter Maydell Oct. 9, 2020, 12:16 p.m. UTC | #1
On Thu, 8 Oct 2020 at 20:03, Eric Blake <eblake@redhat.com> wrote:
>

> The following changes since commit e64cf4d569f6461d6b9072e00d6e78d0ab8bd4a7:

>

>   Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20201008' into staging (2020-10-08 17:18:46 +0100)

>

> are available in the Git repository at:

>

>   https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2020-10-08

>

> for you to fetch changes up to 82cd3c26889adbd41756de121d38a3aa7c9351c7:

>

>   nbd: Simplify meta-context parsing (2020-10-08 13:35:07 -0500)

>

> ----------------------------------------------------------------

> nbd patches for 2020-10-08

>

> - silence compilation warnings

> - more fixes to prevent reconnect hangs

> - improve 'qemu-nbd' termination behavior

> - cleaner NBD protocol compliance on string handling


Build failure, OSX, FreeBSD, NetBSD:

Linking static target libqemuutil.a
../../qemu-nbd.c:591:29: error: use of undeclared identifier 'termsig_handler'
    sa_sigterm.sa_handler = termsig_handler;
                            ^
1 error generated.

thanks
-- PMM
Eric Blake Oct. 9, 2020, 12:25 p.m. UTC | #2
On 10/9/20 7:16 AM, Peter Maydell wrote:

>> ----------------------------------------------------------------

>> nbd patches for 2020-10-08

>>

>> - silence compilation warnings

>> - more fixes to prevent reconnect hangs

>> - improve 'qemu-nbd' termination behavior

>> - cleaner NBD protocol compliance on string handling

> 

> Build failure, OSX, FreeBSD, NetBSD:

> 

> Linking static target libqemuutil.a

> ../../qemu-nbd.c:591:29: error: use of undeclared identifier 'termsig_handler'

>     sa_sigterm.sa_handler = termsig_handler;

>                             ^


I see it; inconsistent #ifdefs.  Will spin v2 shortly.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org