mbox series

[PULL,00/30] nvme emulation patches for 5.2

Message ID 20201027104932.558087-1-its@irrelevant.dk
Headers show
Series nvme emulation patches for 5.2 | expand

Message

Klaus Jensen Oct. 27, 2020, 10:49 a.m. UTC
From: Klaus Jensen <k.jensen@samsung.com>


Hi Peter,

The following changes since commit 1dc887329a10903940501b43e8c0cc67af7c06d5:

  Merge remote-tracking branch 'remotes/philmd-gitlab/tags/sd-next-20201026' into staging (2020-10-26 17:19:26 +0000)

are available in the Git repository at:

  git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request

for you to fetch changes up to 843c8f91a7ad63f8f3e4e564d3f41f3d030ab8a9:

  hw/block/nvme: fix queue identifer validation (2020-10-27 11:29:25 +0100)

----------------------------------------------------------------
nvme emulation patches for 5.2

  - lots of cleanups
  - add support for scatter/gather lists
  - add support for multiple namespaces (adds new nvme-ns device)
  - change default pci vendor/device id
  - add support for per-namespace smart log

----------------------------------------------------------------

Dmitry Fomichev (1):
  hw/block/nvme: report actual LBA data shift in LBAF

Gollu Appalanaidu (4):
  hw/block/nvme: add support for sgl bit bucket descriptor
  hw/block/nvme: fix prp mapping status codes
  hw/block/nvme: fix create IO SQ/CQ status codes
  hw/block/nvme: fix queue identifer validation

Keith Busch (5):
  hw/block/nvme: remove pointless rw indirection
  hw/block/nvme: fix log page offset check
  hw/block/nvme: support per-namespace smart log
  hw/block/nvme: validate command set selected
  hw/block/nvme: support for admin-only command set

Klaus Jensen (20):
  hw/block/nvme: fix typo in trace event
  pci: pass along the return value of dma_memory_rw
  hw/block/nvme: handle dma errors
  hw/block/nvme: commonize nvme_rw error handling
  hw/block/nvme: alignment style fixes
  hw/block/nvme: add a lba to bytes helper
  hw/block/nvme: fix endian conversion
  hw/block/nvme: add symbolic command name to trace events
  hw/block/nvme: refactor aio submission
  hw/block/nvme: default request status to success
  hw/block/nvme: harden cmb access
  hw/block/nvme: add support for scatter gather lists
  hw/block/nvme: refactor identify active namespace id list
  hw/block/nvme: support multiple namespaces
  pci: allocate pci id for nvme
  hw/block/nvme: change controller pci id
  hw/block/nvme: update nsid when registered
  hw/block/nvme: reject io commands if only admin command set selected
  hw/block/nvme: add nsid to get/setfeat trace events
  hw/block/nvme: add trace event for requests with non-zero status code

 docs/specs/nvme.txt    |  23 +
 docs/specs/pci-ids.txt |   1 +
 hw/block/nvme-ns.h     |  74 ++++
 hw/block/nvme.h        |  83 +++-
 include/block/nvme.h   |  18 +-
 include/hw/pci/pci.h   |   4 +-
 hw/block/nvme-ns.c     | 168 ++++++++
 hw/block/nvme.c        | 921 +++++++++++++++++++++++++++++------------
 hw/core/machine.c      |   1 +
 MAINTAINERS            |   1 +
 hw/block/meson.build   |   2 +-
 hw/block/trace-events  |  32 +-
 12 files changed, 1025 insertions(+), 303 deletions(-)
 create mode 100644 docs/specs/nvme.txt
 create mode 100644 hw/block/nvme-ns.h
 create mode 100644 hw/block/nvme-ns.c

-- 
2.29.1

Comments

Peter Maydell Oct. 29, 2020, 11:39 a.m. UTC | #1
On Tue, 27 Oct 2020 at 10:49, Klaus Jensen <its@irrelevant.dk> wrote:
>
> From: Klaus Jensen <k.jensen@samsung.com>
>
> Hi Peter,
>
> The following changes since commit 1dc887329a10903940501b43e8c0cc67af7c06d5:
>
>   Merge remote-tracking branch 'remotes/philmd-gitlab/tags/sd-next-20201026' into staging (2020-10-26 17:19:26 +0000)
>
> are available in the Git repository at:
>
>   git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request
>
> for you to fetch changes up to 843c8f91a7ad63f8f3e4e564d3f41f3d030ab8a9:
>
>   hw/block/nvme: fix queue identifer validation (2020-10-27 11:29:25 +0100)
>
> ----------------------------------------------------------------
> nvme emulation patches for 5.2
>
>   - lots of cleanups
>   - add support for scatter/gather lists
>   - add support for multiple namespaces (adds new nvme-ns device)
>   - change default pci vendor/device id
>   - add support for per-namespace smart log

Hi. This tag appears to have been signed with a GPG key
which isn't one that's been used before for an nvme pullreq
and which isn't on the public GPG servers...

thanks
-- PMM
Klaus Jensen Oct. 29, 2020, 11:52 a.m. UTC | #2
On Oct 29 11:39, Peter Maydell wrote:
> On Tue, 27 Oct 2020 at 10:49, Klaus Jensen <its@irrelevant.dk> wrote:
> >
> > From: Klaus Jensen <k.jensen@samsung.com>
> >
> > Hi Peter,
> >
> > The following changes since commit 1dc887329a10903940501b43e8c0cc67af7c06d5:
> >
> >   Merge remote-tracking branch 'remotes/philmd-gitlab/tags/sd-next-20201026' into staging (2020-10-26 17:19:26 +0000)
> >
> > are available in the Git repository at:
> >
> >   git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request
> >
> > for you to fetch changes up to 843c8f91a7ad63f8f3e4e564d3f41f3d030ab8a9:
> >
> >   hw/block/nvme: fix queue identifer validation (2020-10-27 11:29:25 +0100)
> >
> > ----------------------------------------------------------------
> > nvme emulation patches for 5.2
> >
> >   - lots of cleanups
> >   - add support for scatter/gather lists
> >   - add support for multiple namespaces (adds new nvme-ns device)
> >   - change default pci vendor/device id
> >   - add support for per-namespace smart log
> 
> Hi. This tag appears to have been signed with a GPG key
> which isn't one that's been used before for an nvme pullreq
> and which isn't on the public GPG servers...
> 

Uhm. Keith, can we coordinate a keysigning?

Would a signature by Keith on my key be acceptable to you Peter? That
way Keith doesn't have to create a new tag and bomb the list again.
Philippe Mathieu-Daudé Oct. 29, 2020, 12:20 p.m. UTC | #3
On 10/29/20 12:52 PM, Klaus Jensen wrote:
> On Oct 29 11:39, Peter Maydell wrote:
>> On Tue, 27 Oct 2020 at 10:49, Klaus Jensen <its@irrelevant.dk> wrote:
>>>
>>> From: Klaus Jensen <k.jensen@samsung.com>
>>>
>>> Hi Peter,
>>>
>>> The following changes since commit 1dc887329a10903940501b43e8c0cc67af7c06d5:
>>>
>>>   Merge remote-tracking branch 'remotes/philmd-gitlab/tags/sd-next-20201026' into staging (2020-10-26 17:19:26 +0000)
>>>
>>> are available in the Git repository at:
>>>
>>>   git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request
>>>
>>> for you to fetch changes up to 843c8f91a7ad63f8f3e4e564d3f41f3d030ab8a9:
>>>
>>>   hw/block/nvme: fix queue identifer validation (2020-10-27 11:29:25 +0100)
>>>
>>> ----------------------------------------------------------------
>>> nvme emulation patches for 5.2
>>>
>>>   - lots of cleanups
>>>   - add support for scatter/gather lists
>>>   - add support for multiple namespaces (adds new nvme-ns device)
>>>   - change default pci vendor/device id
>>>   - add support for per-namespace smart log
>>
>> Hi. This tag appears to have been signed with a GPG key
>> which isn't one that's been used before for an nvme pullreq
>> and which isn't on the public GPG servers...
>>
> 
> Uhm. Keith, can we coordinate a keysigning?
> 
> Would a signature by Keith on my key be acceptable to you Peter? That
> way Keith doesn't have to create a new tag and bomb the list again.

Although list bombing isn't really a problem, if you don't modify
the patches, then you can simply post the cover (as v2) without
the patches.

You can also get your key signed and ask Peter to retry your tag,
or push a different tag and ask again, replying to this cover.

Regards,

Phil.
Klaus Jensen Oct. 29, 2020, 1:14 p.m. UTC | #4
On Oct 29 13:20, Philippe Mathieu-Daudé wrote:
> On 10/29/20 12:52 PM, Klaus Jensen wrote:
> > On Oct 29 11:39, Peter Maydell wrote:
> >> On Tue, 27 Oct 2020 at 10:49, Klaus Jensen <its@irrelevant.dk> wrote:
> >>>
> >>> From: Klaus Jensen <k.jensen@samsung.com>
> >>>
> >>> Hi Peter,
> >>>
> >>> The following changes since commit 1dc887329a10903940501b43e8c0cc67af7c06d5:
> >>>
> >>>   Merge remote-tracking branch 'remotes/philmd-gitlab/tags/sd-next-20201026' into staging (2020-10-26 17:19:26 +0000)
> >>>
> >>> are available in the Git repository at:
> >>>
> >>>   git://git.infradead.org/qemu-nvme.git tags/nvme-next-pull-request
> >>>
> >>> for you to fetch changes up to 843c8f91a7ad63f8f3e4e564d3f41f3d030ab8a9:
> >>>
> >>>   hw/block/nvme: fix queue identifer validation (2020-10-27 11:29:25 +0100)
> >>>
> >>> ----------------------------------------------------------------
> >>> nvme emulation patches for 5.2
> >>>
> >>>   - lots of cleanups
> >>>   - add support for scatter/gather lists
> >>>   - add support for multiple namespaces (adds new nvme-ns device)
> >>>   - change default pci vendor/device id
> >>>   - add support for per-namespace smart log
> >>
> >> Hi. This tag appears to have been signed with a GPG key
> >> which isn't one that's been used before for an nvme pullreq
> >> and which isn't on the public GPG servers...
> >>
> > 
> > Uhm. Keith, can we coordinate a keysigning?
> > 
> > Would a signature by Keith on my key be acceptable to you Peter? That
> > way Keith doesn't have to create a new tag and bomb the list again.
> 
> Although list bombing isn't really a problem, if you don't modify
> the patches, then you can simply post the cover (as v2) without
> the patches.
> 
> You can also get your key signed and ask Peter to retry your tag,
> or push a different tag and ask again, replying to this cover.
> 

Thanks Phil!