| Message ID | 20201105175153.30489-1-alex.bennee@linaro.org |
|---|---|
| Headers | show |
| Series | Xen guest-loader and arm64 build fixes/enhancements | expand |
Patchew URL: https://patchew.org/QEMU/20201105175153.30489-1-alex.bennee@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201105175153.30489-1-alex.bennee@linaro.org
Subject: [RFC PATCH 00/15] Xen guest-loader and arm64 build fixes/enhancements
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20201105175153.30489-1-alex.bennee@linaro.org -> patchew/20201105175153.30489-1-alex.bennee@linaro.org
Switched to a new branch 'test'
27a1c8e meson.build: build a Xen aware qemu-aarch64-system
c2531b0 xen: only build HVM support under CONFIG_XEN_HVM
a4e2d49 accel/stubs: drop unused cpu.h include
8e6bdd0 stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub
c89ecab include/hw/xen.h: drop superfluous struct
f76f5a8 meson.build: clean-up summary reporting of XEN and it's features
739b93f meson.build: introduce CONFIG_XEN_HVM flag
e739aac meson.build: fix building of Xen support for aarch64
f28183e accel/meson: you only need accelerator stubs for softmmu builds
8227889 docs: add some documentation for the guest-loader
5d2e6b4 docs: move generic-loader documentation into the main manual
97eabd7 hw/core: implement a guest-loader to support static hypervisor guests
d3af3c7 device_tree: add qemu_fdt_setprop_string_array helper
57bb510 hw/riscv: migrate fdt field to generic MachineState
4d28909 hw/board: promote fdt from ARM VirtMachineState to MachineState
=== OUTPUT BEGIN ===
1/15 Checking commit 4d289091b31a (hw/board: promote fdt from ARM VirtMachineState to MachineState)
2/15 Checking commit 57bb510cbd7f (hw/riscv: migrate fdt field to generic MachineState)
3/15 Checking commit d3af3c7f5650 (device_tree: add qemu_fdt_setprop_string_array helper)
WARNING: line over 80 characters
#66: FILE: softmmu/device_tree.c:406:
+int qemu_fdt_setprop_string_array(void *fdt, const char *node_path, const char *prop,
total: 0 errors, 1 warnings, 61 lines checked
Patch 3/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/15 Checking commit 97eabd73472c (hw/core: implement a guest-loader to support static hypervisor guests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23:
new file mode 100644
WARNING: line over 80 characters
#69: FILE: hw/core/guest-loader.c:42:
+static void loader_insert_platform_data(GuestLoaderState *s, int size, Error **errp)
ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead
#73: FILE: hw/core/guest-loader.c:46:
+ g_autofree char *node = g_strdup_printf("/chosen/module@%#08lx", s->addr);
WARNING: line over 80 characters
#87: FILE: hw/core/guest-loader.c:60:
+ (fdt, node, "compatible", (char **) &compat, ARRAY_SIZE(compat)) < 0) {
ERROR: "foo * bar" should be "foo *bar"
#97: FILE: hw/core/guest-loader.c:70:
+ const char * compat[2] = { "multiboot,module", "multiboot,ramdisk" };
WARNING: line over 80 characters
#99: FILE: hw/core/guest-loader.c:72:
+ (fdt, node, "compatible", (char **) &compat, ARRAY_SIZE(compat)) < 0) {
WARNING: line over 80 characters
#114: FILE: hw/core/guest-loader.c:87:
+ error_setg(errp, "Cannot specify a kernel and initrd in the same stanza");
total: 2 errors, 5 warnings, 182 lines checked
Patch 4/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/15 Checking commit 5d2e6b45a0ff (docs: move generic-loader documentation into the main manual)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15:
deleted file mode 100644
ERROR: trailing whitespace
#204: FILE: docs/system/generic-loader.rst:87:
+ $
total: 1 errors, 1 warnings, 124 lines checked
Patch 5/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/15 Checking commit 82278896e117 (docs: add some documentation for the guest-loader)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11:
new file mode 100644
total: 0 errors, 1 warnings, 61 lines checked
Patch 6/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/15 Checking commit f28183e58873 (accel/meson: you only need accelerator stubs for softmmu builds)
8/15 Checking commit e739aac98546 (meson.build: fix building of Xen support for aarch64)
9/15 Checking commit 739b93f74453 (meson.build: introduce CONFIG_XEN_HVM flag)
10/15 Checking commit f76f5a8ae6f4 (meson.build: clean-up summary reporting of XEN and it's features)
11/15 Checking commit c89ecab617c8 (include/hw/xen.h: drop superfluous struct)
12/15 Checking commit 8e6bdd0b268e (stubs/xen-hw-stub: drop xenstore_store_pv_console_info stub)
13/15 Checking commit a4e2d49e005e (accel/stubs: drop unused cpu.h include)
14/15 Checking commit c2531b00f4b8 (xen: only build HVM support under CONFIG_XEN_HVM)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
total: 0 errors, 1 warnings, 66 lines checked
Patch 14/15 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/15 Checking commit 27a1c8ef9d5d (meson.build: build a Xen aware qemu-aarch64-system)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20201105175153.30489-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com