From patchwork Mon Feb 6 19:38:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 650951 Delivered-To: patch@linaro.org Received: by 2002:a17:522:d8c:b0:4be:c3dc:14d8 with SMTP id d12csp2462551pva; Mon, 6 Feb 2023 11:39:04 -0800 (PST) X-Google-Smtp-Source: AK7set8t6bX5WnZJb99DXOESBTup7JceKJVYyfNh7zLzvdErSnkNXAmy60weJaxh6wuosuv8mInT X-Received: by 2002:a05:622a:1746:b0:3b6:8bc3:a09c with SMTP id l6-20020a05622a174600b003b68bc3a09cmr1151682qtk.25.1675712344628; Mon, 06 Feb 2023 11:39:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675712344; cv=none; d=google.com; s=arc-20160816; b=u7PqApfaW1d8GhPkdX639gQgaIppNYhfnmPDMFCcMyyB8NBnJWCXUZSwTieHFjh1yc aNvdcm7nMtqHC4+06qlfggrKkRp4U48/Jq6tn2OXQ77hiDSR2HLu1podLQe1XHwTLFBt 8/Tm/7xAumZt1g53WDhbuRl7jiiVVOhAIL0tYI4vAOW6GPiCdYsSwnAL0P+E5CHvF9ll FfIiWiHz502iLxKoXuLtAOPNXLFefot9vVQ9+GmOjSjldbld7d/J+TekqiKTnq23zRjE 7XwPaReI4Un4B79docbDp5xoaYVEqDawAIlBbz5pC9OotwOor9ELu6mv5gw0RF6WLXBd v5hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=0q60s5JtYRzXWJA/mIjLMUaaUnLiACsxKZ6xNlH4bSU=; b=cRAiKTgwQZ1CdX7+6M/J+6tIXjK1s06RIZwfr7Umtsyl8dqLBT3IuaFjnvzP7s0Uk9 Z7XvZP8jeSaX1jRkBWwLTiWEpEorBFlu6CMtGJDJU2g5ewe1WxM0trlAfU02eLTOoRq1 oYNz66NnhGOAkvv7Ev25I5qUyHJPold1iKCLL3kiAeh7EJ53YQEghbubYADcLwfB0dAH /Pcmx8lemp/YYUpKHxiMClvAXIYF1VjpLkcm228VAhbFKrwJ0aOnm8C/t44cn26KYk4a A/ROmaHwiNoNvaA0dMohXmFWLKdUi2nEYDxzPmyV9Qm/wk8rV6HSdZqy2YVloQZqdhxC 3H0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JdVrbWon; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id e14-20020ac8414e000000b003ba1088cf12si6523906qtm.166.2023.02.06.11.39.04 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Feb 2023 11:39:04 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JdVrbWon; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP7Ji-0004nA-RT; Mon, 06 Feb 2023 14:38:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP7Jh-0004mw-2G for qemu-devel@nongnu.org; Mon, 06 Feb 2023 14:38:17 -0500 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP7Jf-0005U7-Fz for qemu-devel@nongnu.org; Mon, 06 Feb 2023 14:38:16 -0500 Received: by mail-pl1-x636.google.com with SMTP id e19so5380603plc.9 for ; Mon, 06 Feb 2023 11:38:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0q60s5JtYRzXWJA/mIjLMUaaUnLiACsxKZ6xNlH4bSU=; b=JdVrbWonCJsy1p9wUrXL5OU1r9tvHan5Ctu2rkutwDbmfdxgnnDN2rwpzVWp1nSHwS r9GJ6JAM5NWHUMUaCG6+AkcNX63JfCAwPhjKKHFB4DHVsbwemQ1q6FLSnKsCDoZKo2kz Y7Po6tunvcx1jel00aiNnIDwhZM392dOxVhFfQLi4vownmqXUEaOnQV5HpUevJ11bGk9 mvGXEW/5pvQa4m0FmHCDqdAUBwEuCEqYR9NC5/Kbh3U7Q7X3WKg3iNzQbqsHq4WthnpK Zs1eLJ0gwz90C+jhuBKZsKZP+s2NeXpnEipGGwblhQ/tQ/Z5An8YvteQIy8Ct5mW4OWz YBYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0q60s5JtYRzXWJA/mIjLMUaaUnLiACsxKZ6xNlH4bSU=; b=kOwmeEuGwOnILcOJanznS6oDcKwes9HrtoDgSvG5QmI/4dEGtTD9QNxl7aNRv3hKFQ xkyVTuxB9oa7ZovBNi7EU70k8DHhiyrTvBldh0E0300zPxzvFZBxx3dCWRIrRC1pmU7X Iy0R1HPhXsk4MbbljQ3Q6QexQBM8Z0XndFToAVNhIZ9GtHiAFN9D7Tt6pA6w16R39gOC TXxLo0B1wq2Qvoisnw/c+sfft28bPPMW8jCDcqBOHNroZN30Y1Co2e0lAPKShppjqqwB hnBNGyMA9u2UHS2CmoXSKdX2XPfys+CYCVOd+dZ7+qrppq+9EqWK7zghVd06ItACMMjl PRug== X-Gm-Message-State: AO0yUKXvGwoaLpmWhtAJ5H9VMG79biq8B69aL2UTxeFlIolpJG3et3ON sVGNpZi028IMmlrIYePZXEayQxJPUpiwBje+0PmHgA== X-Received: by 2002:a17:903:1cf:b0:199:1f42:8bed with SMTP id e15-20020a17090301cf00b001991f428bedmr725616plh.12.1675712293429; Mon, 06 Feb 2023 11:38:13 -0800 (PST) Received: from stoup.. (rrcs-74-87-59-234.west.biz.rr.com. [74.87.59.234]) by smtp.gmail.com with ESMTPSA id p6-20020a170902780600b001929f0b4582sm7190058pll.300.2023.02.06.11.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 11:38:12 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: sidneym@quicinc.com, mburton@qti.qualcomm.com, bcain@quicinc.com, mathbern@qti.qualcomm.com, Jorgen.Hansen@wdc.com, Ajay.Joshi@wdc.com Subject: [PATCH 0/1] accel/tcg: Allow the second page of an instruction to be MMIO Date: Mon, 6 Feb 2023 09:38:08 -1000 Message-Id: <20230206193809.1153124-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Curious but true: two independent reports of the same issue within 24 hours, one with an x86 guest and one with an arm guest. Neither report included instructions for reproduction (and both seem to be with complex setup), therefore this is untested, but seems simple enough to be the proper fix. It matches up with /* * If the TB is not associated with a physical RAM page then it must be * a temporary one-insn TB, and we have nothing left to do. Return early * before attempting to link to other TBs or add to the lookup table. */ if (tb_page_addr0(tb) == -1) { return tb; } in tb_gen_code(). r~ Richard Henderson (1): accel/tcg: Allow the second page of an instruction to be MMIO accel/tcg/translator.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)