| Message ID | 20230223124340.95367-1-philmd@linaro.org |
|---|---|
| Headers | show |
| Series | target: Restrict 'qapi-commands-machine.h' to system emulation | expand |
Philippe Mathieu-Daudé <philmd@linaro.org> writes: > All series reviewed, can patches be picked by corresponding > maintainers, or should I include them in on of my PRs? I'm sitting on a lonely patch for the monitor subsystem. Want me to throw in your series, so my PR is a less complete waste of CI minutes? [...]
On 23/2/23 14:49, Markus Armbruster wrote: > Philippe Mathieu-Daudé <philmd@linaro.org> writes: > >> All series reviewed, can patches be picked by corresponding >> maintainers, or should I include them in on of my PRs? > > I'm sitting on a lonely patch for the monitor subsystem. Want me to > throw in your series, so my PR is a less complete waste of CI minutes? That would be lovely! v4: https://lore.kernel.org/qemu-devel/20230223155540.30370-1-philmd@linaro.org/
On 23/2/23 16:56, Philippe Mathieu-Daudé wrote: > On 23/2/23 14:49, Markus Armbruster wrote: >> Philippe Mathieu-Daudé <philmd@linaro.org> writes: >> >>> All series reviewed, can patches be picked by corresponding >>> maintainers, or should I include them in on of my PRs? >> >> I'm sitting on a lonely patch for the monitor subsystem. Want me to >> throw in your series, so my PR is a less complete waste of CI minutes? > > That would be lovely! v4: > https://lore.kernel.org/qemu-devel/20230223155540.30370-1-philmd@linaro.org/ btw I didn't add these files in your MAINTAINERS Monitor section because I expect them to be taken care by each $target maintainer.
Philippe Mathieu-Daudé <philmd@linaro.org> writes: > On 23/2/23 16:56, Philippe Mathieu-Daudé wrote: >> On 23/2/23 14:49, Markus Armbruster wrote: >>> Philippe Mathieu-Daudé <philmd@linaro.org> writes: >>> >>>> All series reviewed, can patches be picked by corresponding >>>> maintainers, or should I include them in on of my PRs? >>> >>> I'm sitting on a lonely patch for the monitor subsystem. Want me to >>> throw in your series, so my PR is a less complete waste of CI minutes? >> >> That would be lovely! v4: >> https://lore.kernel.org/qemu-devel/20230223155540.30370-1-philmd@linaro.org/ Okay, I'll take care of it. > btw I didn't add these files in your MAINTAINERS Monitor section because > I expect them to be taken care by each $target maintainer. Makes sense, thanks!
All series reviewed, can patches be picked by corresponding maintainers, or should I include them in on of my PRs? The "qapi-commands-machine.h" header is not generated in user-only emulation. This series removes its use in user-emu code by moving the QMP code depending on this header into a separate sysemu unit. Since v2: - Rebased - Renamed target/$foo/monitor.c -> target/$foo/$foo-qmp-cmds.c (Markus) Since v1: - renamed cpu-monitor.c -> monitor.c on loongarch Philippe Mathieu-Daudé (4): target/arm: Restrict 'qapi-commands-machine.h' to system emulation target/i386: Restrict 'qapi-commands-machine.h' to system emulation target/loongarch: Restrict 'qapi-commands-machine.h' to system emulation target/ppc: Restrict 'qapi-commands-machine.h' to system emulation target/arm/{monitor.c => arm-qmp-cmds.c} | 28 +++++++++ target/arm/helper.c | 29 ---------- target/arm/meson.build | 2 +- target/i386/cpu.c | 74 +++++++++++++----------- target/loongarch/cpu.c | 27 --------- target/loongarch/loongarch-qmp-cmds.c | 37 ++++++++++++ target/loongarch/meson.build | 1 + target/ppc/cpu-qom.h | 2 + target/ppc/cpu_init.c | 48 +-------------- target/ppc/meson.build | 2 +- target/ppc/{monitor.c => ppc-qmp-cmds.c} | 50 +++++++++++++++- 11 files changed, 159 insertions(+), 141 deletions(-) rename target/arm/{monitor.c => arm-qmp-cmds.c} (90%) create mode 100644 target/loongarch/loongarch-qmp-cmds.c rename target/ppc/{monitor.c => ppc-qmp-cmds.c} (78%)