mbox series

[v2,0/7] plugin: fix clearing of plugin_mem_cbs on TB exit

Message ID 20230310195252.210956-1-richard.henderson@linaro.org
Headers show
Series plugin: fix clearing of plugin_mem_cbs on TB exit | expand

Message

Richard Henderson March 10, 2023, 7:52 p.m. UTC 
Changes for v2:
  * Use plugin_gen_disable_mem_helpers,
  * Remove plugin_gen_disable_mem_helpers from tcg_gen_exit_tb.
  * Break include loop with hw/core/cpu.h and qemu/plugins.h.
  * Inline plugin_gen_disable_mem_helpers.


r~


Richard Henderson (7):
  tcg: Clear plugin_mem_cbs on TB exit
  tcg: Drop plugin_gen_disable_mem_helpers from tcg_gen_exit_tb
  include/qemu/plugin: Remove QEMU_PLUGIN_ASSERT
  *: Add missing includes of qemu/error-report.h
  *: Add missing includes of qemu/plugin.h
  include/qemu: Split out plugin-event.h
  include/qemu/plugin: Inline qemu_plugin_disable_mem_helpers

 include/hw/core/cpu.h          |  2 +-
 include/qemu/plugin-event.h    | 26 ++++++++++++++++++++++++++
 include/qemu/plugin.h          | 27 ++++++---------------------
 accel/accel-softmmu.c          |  2 +-
 accel/tcg/cpu-exec-common.c    |  3 +++
 accel/tcg/cpu-exec.c           |  5 +----
 block/monitor/block-hmp-cmds.c |  1 +
 cpu.c                          |  1 +
 dump/dump.c                    |  1 +
 dump/win_dump.c                |  1 +
 hw/arm/collie.c                |  2 ++
 hw/arm/cubieboard.c            |  1 +
 hw/arm/musicpal.c              |  2 ++
 hw/arm/npcm7xx_boards.c        |  2 ++
 hw/arm/nseries.c               |  2 ++
 hw/arm/omap_sx1.c              |  2 ++
 hw/arm/orangepi.c              |  1 +
 hw/arm/palm.c                  |  2 ++
 hw/core/machine-smp.c          |  2 ++
 hw/i386/sgx.c                  |  1 +
 hw/loongarch/acpi-build.c      |  1 +
 hw/loongarch/virt.c            |  2 ++
 hw/m68k/next-cube.c            |  1 +
 hw/m68k/q800.c                 |  1 +
 hw/m68k/virt.c                 |  1 +
 hw/openrisc/boot.c             |  1 +
 hw/ppc/spapr_softmmu.c         |  2 ++
 hw/riscv/opentitan.c           |  1 +
 hw/riscv/shakti_c.c            |  1 +
 hw/riscv/virt-acpi-build.c     |  1 +
 linux-user/elfload.c           |  1 +
 linux-user/exit.c              |  1 +
 linux-user/syscall.c           |  1 +
 plugins/core.c                 | 11 -----------
 target/i386/cpu.c              |  1 +
 target/i386/host-cpu.c         |  1 +
 target/s390x/cpu_models.c      |  1 +
 target/s390x/diag.c            |  2 ++
 tcg/tcg-op.c                   |  1 -
 39 files changed, 79 insertions(+), 39 deletions(-)
 create mode 100644 include/qemu/plugin-event.h

Comments

Alex Bennée March 13, 2023, 10:47 a.m. UTC | #1 
Richard Henderson <richard.henderson@linaro.org> writes:

> Changes for v2:
>   * Use plugin_gen_disable_mem_helpers,
>   * Remove plugin_gen_disable_mem_helpers from tcg_gen_exit_tb.
>   * Break include loop with hw/core/cpu.h and qemu/plugins.h.
>   * Inline plugin_gen_disable_mem_helpers.

Queued to for-8.0/tweaks-and-fixes, thanks.
Emilio Cota March 19, 2023, 2:06 p.m. UTC | #2 
On Fri, Mar 10, 2023 at 11:52:45 -0800, Richard Henderson wrote:
> Changes for v2:
(snip)
> Richard Henderson (7):
>   tcg: Clear plugin_mem_cbs on TB exit
>   tcg: Drop plugin_gen_disable_mem_helpers from tcg_gen_exit_tb
>   include/qemu/plugin: Remove QEMU_PLUGIN_ASSERT
>   *: Add missing includes of qemu/error-report.h
>   *: Add missing includes of qemu/plugin.h
>   include/qemu: Split out plugin-event.h
>   include/qemu/plugin: Inline qemu_plugin_disable_mem_helpers

Reviewed-by: Emilio Cota <cota@braap.org>

Thanks, Richard!

Alex: is it too late to add my R-b tags to the series?

		Emilio
Alex Bennée March 20, 2023, 5:31 p.m. UTC | #3 
Emilio Cota <cota@braap.org> writes:

> On Fri, Mar 10, 2023 at 11:52:45 -0800, Richard Henderson wrote:
>> Changes for v2:
> (snip)
>> Richard Henderson (7):
>>   tcg: Clear plugin_mem_cbs on TB exit
>>   tcg: Drop plugin_gen_disable_mem_helpers from tcg_gen_exit_tb
>>   include/qemu/plugin: Remove QEMU_PLUGIN_ASSERT
>>   *: Add missing includes of qemu/error-report.h
>>   *: Add missing includes of qemu/plugin.h
>>   include/qemu: Split out plugin-event.h
>>   include/qemu/plugin: Inline qemu_plugin_disable_mem_helpers
>
> Reviewed-by: Emilio Cota <cota@braap.org>
>
> Thanks, Richard!
>
> Alex: is it too late to add my R-b tags to the series?

I have to re-roll so I'll do that now.

>
> 		Emilio