mbox series

[v2,0/5] scrips/coverity-scan: COMPONENTS.md updates

Message ID 20240604145934.1230583-1-peter.maydell@linaro.org
Headers show
Series scrips/coverity-scan: COMPONENTS.md updates | expand

Message

Peter Maydell June 4, 2024, 2:59 p.m. UTC
Since commit 83aa1baa069c we have been running the build for Coverity
Scan as a Gitlab CI job, rather than the old setup where it was run
on a local developer's machine.  This is working well, but the
absolute paths of files are different for the Gitlab CI job, which
means that the regexes we use to identify Coverity components no
longer work. With Gitlab CI builds the file paths are of the form
 /builds/qemu-project/qemu/accel/kvm/kvm-all.c

rather than the old
 /qemu/accel/kvm/kvm-all.c

and our regexes all don't match.

The main aim of this series is to fix that, which is what patch 1 does.

Patches 2-5 are minor updates where we were missing files in some
components because we hadn't updated them when we moved things around
or added new files. They're worth doing now since handling patch 1
will require a manual deletion of all components in the coverity
web GUI and re-adding them. (There is, alas, no automated API for this.)

thanks
-- PMM

Peter Maydell (5):
  scripts/coverity-scan/COMPONENTS.md: Update paths to match gitlab CI
  scripts/coverity-scan/COMPONENTS.md: Fix 'char' component
  scripts/coverity-scan/COMPONENTS.md: Add crypto headers in
    host/include to the crypto component
  scripts/coverity-scan/COMPONENTS.md: Fix monitor component
  scripts/coverity-scan/COMPONENTS.md: Include libqmp in testlibs

 scripts/coverity-scan/COMPONENTS.md | 107 ++++++++++++++--------------
 1 file changed, 55 insertions(+), 52 deletions(-)

Comments

Peter Maydell June 10, 2024, 12:25 p.m. UTC | #1
On Tue, 4 Jun 2024 at 15:59, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> Since commit 83aa1baa069c we have been running the build for Coverity
> Scan as a Gitlab CI job, rather than the old setup where it was run
> on a local developer's machine.  This is working well, but the
> absolute paths of files are different for the Gitlab CI job, which
> means that the regexes we use to identify Coverity components no
> longer work. With Gitlab CI builds the file paths are of the form
>  /builds/qemu-project/qemu/accel/kvm/kvm-all.c
>
> rather than the old
>  /qemu/accel/kvm/kvm-all.c
>
> and our regexes all don't match.
>
> The main aim of this series is to fix that, which is what patch 1 does.
>
> Patches 2-5 are minor updates where we were missing files in some
> components because we hadn't updated them when we moved things around
> or added new files. They're worth doing now since handling patch 1
> will require a manual deletion of all components in the coverity
> web GUI and re-adding them. (There is, alas, no automated API for this.)

I'll take this via target-arm.next and do the web GUI update
at some point too.

thanks
-- PMM