From patchwork Mon Jul 1 02:51:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 808824 Delivered-To: patch@linaro.org Received: by 2002:adf:fe0a:0:b0:362:4979:7f74 with SMTP id n10csp1376480wrr; Sun, 30 Jun 2024 19:52:20 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXtBSOefd3gtVgQcIQuZC9XnAy0gaWcR+49sFnnxTeGSdgnLKS+Dv1+34c+DGiDWT+DAss1gYdlDpUPzwyKUDqf X-Google-Smtp-Source: AGHT+IHHCMLxbSv2lFR5St0/9FYUL+wg/c4SAVk3q077deDIdizj4wpJ6FAvKI46+Z0o85SiX4PF X-Received: by 2002:ad4:5de9:0:b0:6b5:46f1:6b01 with SMTP id 6a1803df08f44-6b5b7185e04mr50270026d6.61.1719802340030; Sun, 30 Jun 2024 19:52:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1719802340; cv=none; d=google.com; s=arc-20160816; b=v2P9JZ5mIPGqhNuhymHMZqIJvVRpnfP702t0Zrigb/9uLVYgJZcMO6sD+/U7sdT+QO A61qUJ5+FD2AkwiOveGQPrF7KeQQkiWVeQcJP1Y+oW2AiuFfD53/eBnNmPGpDo/i2v9R buyBUq73Zg/+m+2pBEqoBi9JuQ0mNJ89obXxCCcuQBxsaQ3CAyA6Vjyjv+Y3baNMBw7v RZ8+zjnNaHMjm4QGsBSUTmPk9u9lW0IMe+xMmuMJN9eqRCIG3qWCYPAKiz09Tf67mWes dm+bXe+9X9ZJOvhLAienjbjO2dOaiBavaVwO0yNP47zJPY5HhrvCioxu9/Yi5it6Zozd UG0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=WnwSoeUV3cwlH1+3n2f06XV+qKm4+k7po4qjUIY9IEI=; fh=3mEp7FusppN5Drq2PN08R8D/9xXM9YdbtG5TkJxJBiE=; b=PQ3uD1ryrlBXie87GJKTv5Zo7Yb5zmuHVs9n/umfdQt0ZK3wLkz+xCMwgdVc0P6l7w EP/XCoRUlKOuu9SrKp0zKcJUzKs+v/yFvkr4PZNlyDxzZrj2Tzcq9aXbW6Ujz+vxQV7t hNhYfBUGlKvcFd/Qx92QQfdVH05Kz7EnzP0xBsi41kejr3212RmN0bfXuwIp9LtZicby WjAvojPnJ6RuazQqM3ofjGe9zBtj9QO0mr2gCBDO8yWuUV6S9AAko+LfCJAcI0Tjg2AK SIuIfuAh2vRPYJpQk/yWZVwH+b4Hm1/is5OVe0PnWtXsc+D+LvxiQo0YnY5sPpbNms8k aacA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GU6aJmSf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6b59e6169b3si72601816d6.556.2024.06.30.19.52.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 30 Jun 2024 19:52:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GU6aJmSf; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sO78T-0002tv-Du; Sun, 30 Jun 2024 22:51:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sO78R-0002s8-I1 for qemu-devel@nongnu.org; Sun, 30 Jun 2024 22:51:19 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sO78P-0008Va-VX for qemu-devel@nongnu.org; Sun, 30 Jun 2024 22:51:19 -0400 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-7066a3229f4so1371936b3a.2 for ; Sun, 30 Jun 2024 19:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719802277; x=1720407077; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WnwSoeUV3cwlH1+3n2f06XV+qKm4+k7po4qjUIY9IEI=; b=GU6aJmSfjO5OPAnmZRKAvdkp1XHKINbasEPBG8zvq1kx/zWBNKvJ0c8x+2s++XK7xC 9/VHiY1i6wFKbIjyc+mwwtkDUTcSEijjBlbwCt80WeYCWszregz3haI+idlxtOeWfeLN Ol7tpLnuDe7X2F2lVI4G1f4l4ZD/ZbjN+t1J6mTzyf/bIcBUcV77GEzYF9muzHxo36EZ /kTai/xQ9Id2V2ZVbS0RtGl0L5TUEurFDM1J9mdfpDPrFZufsM+wB4U3bs/DGUf4c0g1 5jioqk4i0CJuzRmpKK31Tll9/wL0XgQYFAAdTfhtQDYG7FQAu6Fje5OOPNHdGrxzvAG5 2zRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719802277; x=1720407077; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WnwSoeUV3cwlH1+3n2f06XV+qKm4+k7po4qjUIY9IEI=; b=im8NpAEhp+/ylIX2IR7YBbJ14qQgVQJwWjVbtb3OiL1DfCW+uWg5XCiAmPBOqhOjcS 8mw72uUpr36NVwckTm5l+n+YkEHfjlUY0ItTJN9px8imhIsqefvfOyCFYeFiWaOdJ93X u51k1pssloAp2aM+kCuYULnpZy7lbWYEqUBUQFxtVr0zrTCsTqLGNjJeH2DbwNVcss98 x8s7iIVmbv6NmtlFCZUMI9QzQWvhQ+r5ba26qmUdWVD6RKCUFZ8pk3XdniqAJN3w2sdj wZQbvoTmVxd128EcytABu0bWrY7m/m0yDZUny6qVkTQrd2Raurge2J2Nt9RQDwi+UTZC oKqw== X-Gm-Message-State: AOJu0Yy3Vi3wEWKOWz+PCquuTJMAbgs3AmkHKoLKuoLBXMC+P4Xnx/y1 xpXC0IGGb/4/6IxSy2lVFplSPiQ5CAnnpnXUghI6cUYzIyfX28O+oF1eq8lGuCb2IqKvlGuW1yP S X-Received: by 2002:a05:6a20:ce4d:b0:1be:c65c:1e32 with SMTP id adf61e73a8af0-1bef621edadmr3134198637.51.1719802276453; Sun, 30 Jun 2024 19:51:16 -0700 (PDT) Received: from stoup.. (174-21-76-141.tukw.qwest.net. [174.21.76.141]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c91d3b9349sm5531698a91.37.2024.06.30.19.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jun 2024 19:51:16 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com Subject: [PATCH 0/5] target/i386: CCOp cleanups Date: Sun, 30 Jun 2024 19:51:10 -0700 Message-Id: <20240701025115.1265117-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org While debugging #2413, I spent quite a bit of time trying to work out if the CCOp value was incorrect. I think the following is a worthwhile cleanup, isolating potential problems to asserts. r~ Richard Henderson (5): target/i386: Tidy cc_op_str usage target/i386: Convert cc_op_live to a function target/i386: Rearrange CCOp target/i386: Remove default in cc_op_live target/i386: Introduce cc_op_size target/i386/cpu.h | 44 +++++++++-------- target/i386/cpu-dump.c | 17 ++++--- target/i386/tcg/translate.c | 84 +++++++++++++++++++------------- target/i386/tcg/decode-new.c.inc | 2 +- target/i386/tcg/emit.c.inc | 9 ++-- 5 files changed, 93 insertions(+), 63 deletions(-)