mbox series

[0/9] hw/arm/stellaris: Fix overwritten IRQs and cleanups

Message ID 20250110160204.74997-1-philmd@linaro.org
Headers show
Series hw/arm/stellaris: Fix overwritten IRQs and cleanups | expand

Message

Philippe Mathieu-Daudé Jan. 10, 2025, 4:01 p.m. UTC
- Remove invalid unimplemented I2C#0
- Add DEVCAP() macro to check DeviceCapability registers
- Check DEVCAP() before creating devices
- Use 4 inputs for ADC, wire each timer output properly
- Improve documentation

Philippe Mathieu-Daudé (9):
  hw/arm/stellaris: Link each board schematic
  hw/arm/stellaris: Constify read-only arrays
  hw/arm/stellaris: Remove incorrect unimplemented i2c-0 at 0x40002000
  hw/arm/stellaris: Replace magic numbers by definitions
  hw/arm/stellaris: Use DEVCAP macro to access DeviceCapability
    registers
  hw/arm/stellaris: Map both I2C controllers
  hw/arm/stellaris: Only create MPU when available
  hw/arm/stellaris: Only map existing devices as unimplemented
  hw/arm/stellaris: Wire GPTM[#n] output to ADC input #n

 hw/arm/stellaris.c | 146 +++++++++++++++++++++++++++++++--------------
 1 file changed, 102 insertions(+), 44 deletions(-)

Comments

Peter Maydell Jan. 27, 2025, 2:31 p.m. UTC | #1
On Fri, 10 Jan 2025 at 16:02, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> - Remove invalid unimplemented I2C#0
> - Add DEVCAP() macro to check DeviceCapability registers
> - Check DEVCAP() before creating devices
> - Use 4 inputs for ADC, wire each timer output properly
> - Improve documentation
>
> Philippe Mathieu-Daudé (9):
>   hw/arm/stellaris: Link each board schematic
>   hw/arm/stellaris: Constify read-only arrays
>   hw/arm/stellaris: Remove incorrect unimplemented i2c-0 at 0x40002000
>   hw/arm/stellaris: Replace magic numbers by definitions
>   hw/arm/stellaris: Use DEVCAP macro to access DeviceCapability
>     registers
>   hw/arm/stellaris: Map both I2C controllers
>   hw/arm/stellaris: Only create MPU when available
>   hw/arm/stellaris: Only map existing devices as unimplemented
>   hw/arm/stellaris: Wire GPTM[#n] output to ADC input #n

Applied 1-6 to target-arm.next; left review comments on the others.

thanks
-- PMM
Philippe Mathieu-Daudé Jan. 27, 2025, 2:48 p.m. UTC | #2
On 27/1/25 15:31, Peter Maydell wrote:
> On Fri, 10 Jan 2025 at 16:02, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:

> Applied 1-6 to target-arm.next; left review comments on the others.

Thanks, could you s/http/https/ in patch #1 or should I post a patch
on top?

Regards,

Phil.
Peter Maydell Jan. 27, 2025, 3 p.m. UTC | #3
On Mon, 27 Jan 2025 at 14:49, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> On 27/1/25 15:31, Peter Maydell wrote:
> > On Fri, 10 Jan 2025 at 16:02, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> > Applied 1-6 to target-arm.next; left review comments on the others.
>
> Thanks, could you s/http/https/ in patch #1 or should I post a patch
> on top?

Yeah, I made that fixup when I applied the patches.

-- PMM