From patchwork Wed Jul 18 14:10:22 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 10118 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 81C8E23E56 for ; Wed, 18 Jul 2012 14:10:39 +0000 (UTC) Received: from mail-gh0-f180.google.com (mail-gh0-f180.google.com [209.85.160.180]) by fiordland.canonical.com (Postfix) with ESMTP id 52130A180BC for ; Wed, 18 Jul 2012 14:10:39 +0000 (UTC) Received: by mail-gh0-f180.google.com with SMTP id z12so1720467ghb.11 for ; Wed, 18 Jul 2012 07:10:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=s8E7o/pZFkxbtPkF/cOIqlcHVeSdrOhxVvFNd82p+zk=; b=MuF4UaX8gptUjCuMZu9oGC5auFlhIWsWa8Q4cfzIEFSxtUeGYwJIu25AhHYLVhHDdV Xpr7tTThmz8VMKVnSavM4NCiVbZSXlxMe6NDqc70SObv8Jf74aaCazL05Ov5l8Nhgwwo 7jTltrqvbm775LpM7uz5GOy2b9P5HCzZTKIx6XomRKoG3aCzf0T5BxITR3gCo3NuB2yH Jmvn+9lT2vYCOcmBgAA9ZN/m/Qz3s1IfftbzosT5GaYpfO7pFJYY1RJD/O+j+x9I0Kqd 5v7cgAcMamFVs/d6AIzB6uyxK+yDwpLhYEA2KXvRql9LRXUGu943j0xegWBMQ/pP7LsN JXlw== Received: by 10.50.203.39 with SMTP id kn7mr2090726igc.53.1342620638729; Wed, 18 Jul 2012 07:10:38 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.153.7 with SMTP id i7csp244ibw; Wed, 18 Jul 2012 07:10:35 -0700 (PDT) Received: by 10.236.116.5 with SMTP id f5mr928492yhh.39.1342620634763; Wed, 18 Jul 2012 07:10:34 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [81.2.115.146]) by mx.google.com with ESMTPS id r47si19242367yhm.78.2012.07.18.07.10.31 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Jul 2012 07:10:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) client-ip=81.2.115.146; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1SrUxQ-0003KG-Gg; Wed, 18 Jul 2012 15:10:28 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Stefan Weil Subject: [PATCH 05/11] configure: -march=i486 belongs in QEMU_CFLAGS, not CFLAGS Date: Wed, 18 Jul 2012 15:10:22 +0100 Message-Id: <1342620628-12751-6-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1342620628-12751-1-git-send-email-peter.maydell@linaro.org> References: <1342620628-12751-1-git-send-email-peter.maydell@linaro.org> X-Gm-Message-State: ALoCoQme22uAjqLhQvPTFRvyvBWR+HPqvTLSWOrwRXl/+mp+Ju8pHPxXQkpA1lpRn9aWyKPF6+Lk The distinction between QEMU_CFLAGS and CFLAGS is that the former is for flags without which QEMU can't compile, whereas the latter is for flags like "-g -O2" which the user can safely override. "-march=i486" is in the former category, and so belongs in QEMU_CFLAGS. Signed-off-by: Peter Maydell --- configure | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index f54415d..3de4ea7 100755 --- a/configure +++ b/configure @@ -2810,7 +2810,7 @@ int main(int argc, char **argv) } EOF if ! compile_prog "" "" ; then - CFLAGS="-march=i486 $CFLAGS" + QEMU_CFLAGS="-march=i486 $QEMU_CFLAGS" fi fi