From patchwork Wed Aug 1 13:35:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 10443 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id A0B1B2402A for ; Wed, 1 Aug 2012 13:35:54 +0000 (UTC) Received: from mail-yx0-f180.google.com (mail-yx0-f180.google.com [209.85.213.180]) by fiordland.canonical.com (Postfix) with ESMTP id 67078A18379 for ; Wed, 1 Aug 2012 13:35:54 +0000 (UTC) Received: by yenq6 with SMTP id q6so7158853yen.11 for ; Wed, 01 Aug 2012 06:35:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=aM/3sNjpVcDbpy9hQ3vxdy4Jrb03dWoelHRjOsDK4B8=; b=ZkLxmRNAKKJ6dQKc/di22buIKCbYVjCoMcKCgnouRyn2DVcExSnJ5gr7xKC85Pm9Kg MJ36gVBEh40O8mDsmaq+dDi9QH7feLp045M7R12m+ssO6DGqv2n1lTeWJqEqPA/xAc0m 2JkqQHbMnp9Ye4F/ueurZhqvzPhA6RNNv1JktsYYxn1XqPoh+0A5NQgSZkXHOcRqvNfj a3M10Nl8EX8AI4SVUZi6/diBbHHG7qurHyuYwW7wlqSarsmp7RjAKP9euY8Pr3V6La5W CvFrL22X9YcqoJotbYwiNUP7GrgW+xhtpjdghA6qpD+0Q0MOYfTLU1T0s88nIVJwX6lP FQKw== Received: by 10.50.163.5 with SMTP id ye5mr4055762igb.51.1343828153648; Wed, 01 Aug 2012 06:35:53 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.87.40 with SMTP id u8csp199778igz; Wed, 1 Aug 2012 06:35:52 -0700 (PDT) Received: by 10.14.218.5 with SMTP id j5mr16785755eep.16.1343828151693; Wed, 01 Aug 2012 06:35:51 -0700 (PDT) Received: from mnementh.archaic.org.uk (1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id 1si1708239eee.13.2012.08.01.06.35.50 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 01 Aug 2012 06:35:51 -0700 (PDT) Received-SPF: neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) client-ip=2001:8b0:1d0::1; Authentication-Results: mx.google.com; spf=neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1SwZ5X-0002Sp-Rw; Wed, 01 Aug 2012 14:35:47 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, qemu-trivial@nongnu.org, Avi Kivity Subject: [PATCH] exec.c: Remove out of date comment Date: Wed, 1 Aug 2012 14:35:47 +0100 Message-Id: <1343828147-9446-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 X-Gm-Message-State: ALoCoQk5ZzFHVwsh3ejvtimOVMiZjA9XcCqxCyZmAzf0R76YZAZySbyHy+wg4I4CapMiwJGSUOng Remove an out of date comment: this comment used to be attached to cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally inserted a couple of other functions between the comment and its function. It is in any case obsolete since (a) the function arguments it refers to have been replaced with a single MemoryRegionSection* argument and (b) the inability to handle regions whose offset_within_address_space and offset_within_region aren't equally aligned was fixed as part of the rewrite of this code. Signed-off-by: Peter Maydell --- Pretty sure my analysis is right and this comment is out of date -- Avi, could you confirm that please? exec.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/exec.c b/exec.c index feb4795..22dff17 100644 --- a/exec.c +++ b/exec.c @@ -2240,14 +2240,6 @@ static void phys_sections_clear(void) phys_sections_nb = 0; } -/* register physical memory. - For RAM, 'size' must be a multiple of the target page size. - If (phys_offset & ~TARGET_PAGE_MASK) != 0, then it is an - io memory page. The address used when calling the IO function is - the offset from the start of the region, plus region_offset. Both - start_addr and region_offset are rounded down to a page boundary - before calculating this offset. This should not be a problem unless - the low bits of start_addr and region_offset differ. */ static void register_subpage(MemoryRegionSection *section) { subpage_t *subpage;