From patchwork Mon Jan 21 12:50:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 14180 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 39B8123DFE for ; Mon, 21 Jan 2013 13:12:30 +0000 (UTC) Received: from mail-ve0-f174.google.com (mail-ve0-f174.google.com [209.85.128.174]) by fiordland.canonical.com (Postfix) with ESMTP id DC92EA1914B for ; Mon, 21 Jan 2013 13:12:29 +0000 (UTC) Received: by mail-ve0-f174.google.com with SMTP id c13so221447vea.19 for ; Mon, 21 Jan 2013 05:12:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=o3njj12jlLrw0TyekO6Qt9xNNn4azI12PqTddm5I91Q=; b=CslaunbQ00RmUC1rQIFmeCaSejls7GE9u6pOeCKoayCCBSMYMEkaOwbznVD5brLpCb zzreO9NCag2KXew5CttkBLQgTMufCaJgg8rDjM8RXKAD8QTE4wJwtjoTyZz0zEn6J71f oGxD4LWjAsaANmTvZUUIAO1NS+dDb51ia+tJSAbqGeJfCVKwRNhiC5GEF7MkPircjLCe sxJRHbgbgmTOyTfQkf0Rv3546FnvuV8egCMmTIbEX5XmrAgY6fe1EWyHcYhjWnclSTIj 9lTYBjFqn9qKYql2kkjQ1z16Pk2NgQmFu065z+UIB228Wnu55JSgtFoAWnm7t6v+xk7u gAoQ== X-Received: by 10.52.34.108 with SMTP id y12mr12846961vdi.8.1358773949402; Mon, 21 Jan 2013 05:12:29 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.145.101 with SMTP id st5csp200438veb; Mon, 21 Jan 2013 05:12:28 -0800 (PST) X-Received: by 10.14.209.131 with SMTP id s3mr43383732eeo.26.1358773947698; Mon, 21 Jan 2013 05:12:27 -0800 (PST) Received: from mnementh.archaic.org.uk (1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id e9si23533694eei.239.2013.01.21.05.12.27 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 21 Jan 2013 05:12:27 -0800 (PST) Received-SPF: neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) client-ip=2001:8b0:1d0::1; Authentication-Results: mx.google.com; spf=neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1TxGq0-0001vx-Vv; Mon, 21 Jan 2013 12:50:57 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Blue Swirl Subject: [PATCH 2/6] hw/omap1.c: Add fallthrough markers and breaks Date: Mon, 21 Jan 2013 12:50:52 +0000 Message-Id: <1358772656-7406-3-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1358772656-7406-1-git-send-email-peter.maydell@linaro.org> References: <1358772656-7406-1-git-send-email-peter.maydell@linaro.org> X-Gm-Message-State: ALoCoQngpvLPTbznB9S/ezBnSrHWaS3SSPlxmTU+tAZOr7PAdSY/uwaMw6GtQbISn+TpmI0/UHg0 Explicitly mark cases where we are deliberately falling through to the following code. In one case we insert a 'break' instead of falling through to a 'break', as this seems slightly clearer. Signed-off-by: Peter Maydell --- hw/omap1.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/omap1.c b/hw/omap1.c index e85f2e2..cc19893 100644 --- a/hw/omap1.c +++ b/hw/omap1.c @@ -529,6 +529,7 @@ static uint64_t omap_ulpd_pm_read(void *opaque, hwaddr addr, case 0x28: /* Reserved */ case 0x2c: /* Reserved */ OMAP_BAD_REG(addr); + /* fall through */ case 0x00: /* COUNTER_32_LSB */ case 0x04: /* COUNTER_32_MSB */ case 0x08: /* COUNTER_HIGH_FREQ_LSB */ @@ -633,6 +634,7 @@ static void omap_ulpd_pm_write(void *opaque, hwaddr addr, case 0x28: /* Reserved */ case 0x2c: /* Reserved */ OMAP_BAD_REG(addr); + /* fall through */ case 0x24: /* SETUP_ANALOG_CELL3_ULPD1 */ case 0x38: /* COUNTER_32_FIQ */ case 0x48: /* LOCL_TIME */ @@ -1089,6 +1091,7 @@ static void omap_mpui_write(void *opaque, hwaddr addr, /* Not in OMAP310 */ case 0x14: /* DSP_STATUS */ OMAP_RO_REG(addr); + break; case 0x18: /* DSP_BOOT_CONFIG */ case 0x1c: /* DSP_MPUI_CONFIG */ break;