From patchwork Thu Apr 17 10:33:41 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 28579 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ve0-f198.google.com (mail-ve0-f198.google.com [209.85.128.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5901820674 for ; Thu, 17 Apr 2014 12:40:50 +0000 (UTC) Received: by mail-ve0-f198.google.com with SMTP id oz11sf1228640veb.5 for ; Thu, 17 Apr 2014 05:40:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=68TkZTmufpiA7ccLel+jYuHNxO+osBaoqZFmBnqFLjY=; b=MM0UFeHj3n/Lyyzw7tu2YnTPq1ROLyvxA/dz5eHtlciryicdsgJ/qxtfSIq4IXyUyD z7GmQg2b74eVyki2yEb9wEdc11mmhGalK/5MdwT4sBdMVjIC3OBETZEOIK7Nk/U0HyYd V/TKTN+fxCtL3IGo4tdWf1TDdsgNQhjvrfD6mV/CqZY7Ja1Q4Tq8Q8UgwpYc3c/Fkzil UzBpxvZIh/Lkc2Bl9pOE3GGBXZX41eVMhqHTVXEtah9mM6OVH1rX0/MmuiQ3o0xrGUF9 ugu5o9sBHNJ2vPJTJOskxS8NukM2B83rtuFw0T0st90BhLpjF5khMN9ObIG689q5RP/j WmJg== X-Gm-Message-State: ALoCoQk2n0vZuuhIrmTQo1nz+s18An76J9jh/6oPG5G6GeiI9eIymqOJEcXdrkIrLT++LLn5wcCP X-Received: by 10.236.88.210 with SMTP id a58mr6378544yhf.50.1397738450104; Thu, 17 Apr 2014 05:40:50 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.103.77 with SMTP id x71ls1082316qge.31.gmail; Thu, 17 Apr 2014 05:40:50 -0700 (PDT) X-Received: by 10.58.169.97 with SMTP id ad1mr94391vec.45.1397738449991; Thu, 17 Apr 2014 05:40:49 -0700 (PDT) Received: from mail-ve0-f179.google.com (mail-ve0-f179.google.com [209.85.128.179]) by mx.google.com with ESMTPS id cx1si3090760vdb.182.2014.04.17.05.40.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 17 Apr 2014 05:40:49 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.179; Received: by mail-ve0-f179.google.com with SMTP id db12so408567veb.24 for ; Thu, 17 Apr 2014 05:40:49 -0700 (PDT) X-Received: by 10.52.104.33 with SMTP id gb1mr105941vdb.45.1397738449914; Thu, 17 Apr 2014 05:40:49 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp32126vcb; Thu, 17 Apr 2014 05:40:49 -0700 (PDT) X-Received: by 10.140.108.200 with SMTP id j66mr16735882qgf.7.1397738449365; Thu, 17 Apr 2014 05:40:49 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id b6si10400255qae.7.2014.04.17.05.40.49 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 17 Apr 2014 05:40:49 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:59491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WajnT-0000iK-7C for patch@linaro.org; Thu, 17 Apr 2014 06:43:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WajeD-0007pT-4Z for qemu-devel@nongnu.org; Thu, 17 Apr 2014 06:34:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WajeC-0002V0-6f for qemu-devel@nongnu.org; Thu, 17 Apr 2014 06:34:25 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:47842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WajeB-0002OB-Uf for qemu-devel@nongnu.org; Thu, 17 Apr 2014 06:34:24 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1Wajdw-00020k-HT for qemu-devel@nongnu.org; Thu, 17 Apr 2014 11:34:08 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Thu, 17 Apr 2014 11:33:41 +0100 Message-Id: <1397730846-7576-27-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1397730846-7576-1-git-send-email-peter.maydell@linaro.org> References: <1397730846-7576-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Subject: [Qemu-devel] [PULL 26/51] target-arm: Remove THUMB2EE feature from AArch64 'any' CPU X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The AArch64 usermode 'any' CPU type was accidentally specified with the ARM_FEATURE_THUMB2EE bit set. This is incorrect since ARMv8 removes Thumb2EE completely. Since we never implemented Thumb2EE anyway having the feature bit set was fairly harmless for user-mode, but the correct thing is to not set it at all. Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite --- target-arm/cpu64.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c index 5be7d72..b8b4fa6 100644 --- a/target-arm/cpu64.c +++ b/target-arm/cpu64.c @@ -83,7 +83,6 @@ static void aarch64_any_initfn(Object *obj) set_feature(&cpu->env, ARM_FEATURE_VFP4); set_feature(&cpu->env, ARM_FEATURE_VFP_FP16); set_feature(&cpu->env, ARM_FEATURE_NEON); - set_feature(&cpu->env, ARM_FEATURE_THUMB2EE); set_feature(&cpu->env, ARM_FEATURE_ARM_DIV); set_feature(&cpu->env, ARM_FEATURE_V7MP); set_feature(&cpu->env, ARM_FEATURE_AARCH64);