From patchwork Thu Apr 17 10:34:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 28554 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yh0-f71.google.com (mail-yh0-f71.google.com [209.85.213.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id F3A6C20674 for ; Thu, 17 Apr 2014 11:54:12 +0000 (UTC) Received: by mail-yh0-f71.google.com with SMTP id a41sf1104292yho.10 for ; Thu, 17 Apr 2014 04:54:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:subject:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:errors-to:sender :x-original-sender:x-original-authentication-results:mailing-list :content-type:content-transfer-encoding; bh=cOIlJw8KluGGD70Amy1SYTm+HTyiB9Qme8M9LgSdEJo=; b=FYdNaq73psBTJ+D2sOS+0lKSxWbcQ4VKQKTYJmtxyUHvQboT147xSWryAR7fA4gKef Z3bWiiofU8yG81TJcGvTTe/hHAZKQbCrt3v8faaV+QWHi0LtW+oOE5Dp8syA61I0y1n9 oO4UacsGg++QycLZJOT270MkvVBo+EnsIxwG/F4otqhzttH7K/Zd1/GxcI2ZSYjUaPn3 GPrAr92+Xjzoo9qEyiibsqTPydk4xD8v8Z3dgtR4RT0zV8mMldxl2i1aTbr+1I0XVMCu CBXf+UPXd6tY16gXFbhST5QqSo5l6cVz1G2CjXEGyiTXDuZL2O6/US/xj7DVR8GyYeGB cqUA== X-Gm-Message-State: ALoCoQnpSgHoueDllHrIf2EkDj/gZy2lP5DaomaQlkrLnD6HfBeg9PxPJB5S+q31qwdR52YNxGu0 X-Received: by 10.224.95.9 with SMTP id b9mr5293248qan.2.1397735652727; Thu, 17 Apr 2014 04:54:12 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.48.70 with SMTP id n64ls1022091qga.19.gmail; Thu, 17 Apr 2014 04:54:12 -0700 (PDT) X-Received: by 10.58.46.207 with SMTP id x15mr7840296vem.17.1397735652589; Thu, 17 Apr 2014 04:54:12 -0700 (PDT) Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com [209.85.220.181]) by mx.google.com with ESMTPS id ud8si3880790vdc.69.2014.04.17.04.54.12 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 17 Apr 2014 04:54:12 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.181; Received: by mail-vc0-f181.google.com with SMTP id id10so359458vcb.12 for ; Thu, 17 Apr 2014 04:54:12 -0700 (PDT) X-Received: by 10.58.230.103 with SMTP id sx7mr1464525vec.28.1397735652501; Thu, 17 Apr 2014 04:54:12 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp28827vcb; Thu, 17 Apr 2014 04:54:12 -0700 (PDT) X-Received: by 10.140.86.71 with SMTP id o65mr9785668qgd.67.1397735652121; Thu, 17 Apr 2014 04:54:12 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id i96si440434qge.53.2014.04.17.04.54.12 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 17 Apr 2014 04:54:12 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:59434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WajiO-0003eW-NL for patch@linaro.org; Thu, 17 Apr 2014 06:38:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Waje6-0007f6-Fd for qemu-devel@nongnu.org; Thu, 17 Apr 2014 06:34:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Waje3-0002Pc-HV for qemu-devel@nongnu.org; Thu, 17 Apr 2014 06:34:18 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:47842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Waje3-0002OB-BJ for qemu-devel@nongnu.org; Thu, 17 Apr 2014 06:34:15 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1Wajdy-00022l-3w for qemu-devel@nongnu.org; Thu, 17 Apr 2014 11:34:10 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Thu, 17 Apr 2014 11:34:06 +0100 Message-Id: <1397730846-7576-52-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1397730846-7576-1-git-send-email-peter.maydell@linaro.org> References: <1397730846-7576-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Subject: [Qemu-devel] [PULL 51/51] target-arm: A64: fix unallocated test of scalar SQXTUN X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Alex Bennée The test for the U bit was incorrectly inverted in the scalar case of SQXTUN. This doesn't affect the vector case as the U bit is used to select XTN(2). Reported-by: Hao Liu Signed-off-by: Alex Bennée Reviewed-by: Claudio Fontana Reviewed-by: Peter Maydell Cc: qemu-stable@nongnu.org Signed-off-by: Peter Maydell --- target-arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 188287d..d86b8ff 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -7708,7 +7708,7 @@ static void disas_simd_scalar_two_reg_misc(DisasContext *s, uint32_t insn) } break; case 0x12: /* SQXTUN */ - if (u) { + if (!u) { unallocated_encoding(s); return; }