From patchwork Tue May 27 21:30:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 31020 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f198.google.com (mail-ie0-f198.google.com [209.85.223.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 613702066E for ; Tue, 27 May 2014 21:31:02 +0000 (UTC) Received: by mail-ie0-f198.google.com with SMTP id tp5sf52087949ieb.5 for ; Tue, 27 May 2014 14:31:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=pqzWMtqBTTKOYDpWMiOk6GVXkoX7sZ4ta0w2GuuMUno=; b=hauflv2k9UuLJh7R4SFOs8EZcawOYC8tCyl18k7GakVb+JAGq6DakfBxe3Em577/9b bIkjTgNAdX2fJKr5ju+N0EdJuv8oQoS2C2hrh/LsF9BHzOOlJ+/gcezIbIjaK3AdAW6S AdcT3L4ouTfTZcl2IudFPE3ARR0DUt29CVl6s7fD67VSdI1ja1oiON6v3cvHf9RBFohF XFuaDxA8vuIpNvDyUDloEhKmqnMHgf2V3Vo6i8F+Ev8paN2cHTOyNkXOwN0hhv3yq+Ra rpscJhxJLSX00JMyajewhRXVRQZJxBWRn8DsjdgBkhGB1a+8r3waCxELkcLtZsen2YrB Drtw== X-Gm-Message-State: ALoCoQkKsdMOQd1XuqiXIKKwQXBXUqQto7b9Flc3S2CP5FufTAjOIezKX8HJFAALecLImnIJRdjV X-Received: by 10.182.86.5 with SMTP id l5mr14947041obz.32.1401226261891; Tue, 27 May 2014 14:31:01 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.82.37 with SMTP id g34ls3285700qgd.64.gmail; Tue, 27 May 2014 14:31:01 -0700 (PDT) X-Received: by 10.53.12.229 with SMTP id et5mr25393158vdd.32.1401226261743; Tue, 27 May 2014 14:31:01 -0700 (PDT) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id qg3si9087544veb.84.2014.05.27.14.31.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 27 May 2014 14:31:01 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id il7so11394021vcb.18 for ; Tue, 27 May 2014 14:31:01 -0700 (PDT) X-Received: by 10.220.89.4 with SMTP id c4mr3747635vcm.53.1401226261583; Tue, 27 May 2014 14:31:01 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp151112vcb; Tue, 27 May 2014 14:31:01 -0700 (PDT) X-Received: by 10.194.89.168 with SMTP id bp8mr43463634wjb.73.1401226260679; Tue, 27 May 2014 14:31:00 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id kp8si27509000wjb.72.2014.05.27.14.31.00 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 27 May 2014 14:31:00 -0700 (PDT) Received-SPF: none (google.com: pm215@archaic.org.uk does not designate permitted sender hosts) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WpOxX-00061O-9S; Tue, 27 May 2014 22:30:59 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org Subject: [PATCH] target-arm/cpu64.c: Actually register Cortex-A57 impdef registers Date: Tue, 27 May 2014 22:30:59 +0100 Message-Id: <1401226259-23121-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , cpu64.c contains a reginfo list for the impdef registers on the Cortex-A57; however we forgot to actually call define_arm_cp_regs(), so it was sitting there doing nothing. Remedy this omission. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias Reviewed-by: Peter Crosthwaite Tested-by: Peter Crosthwaite --- target-arm/cpu64.c | 1 + 1 file changed, 1 insertion(+) Oops. clang 3.4 warns about the unused variable (along with a lot of similar issues in other parts of the codebase). Linux doesn't actually look at any of the A57 impdef regs, or we'd have noticed this earlier. diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c index 8daa622..ff4c2b4 100644 --- a/target-arm/cpu64.c +++ b/target-arm/cpu64.c @@ -128,6 +128,7 @@ static void aarch64_a57_initfn(Object *obj) cpu->ccsidr[1] = 0x201fe012; /* 48KB L1 icache */ cpu->ccsidr[2] = 0x70ffe07a; /* 2048KB L2 cache */ cpu->dcz_blocksize = 4; /* 64 bytes */ + define_arm_cp_regs(cpu, cortexa57_cp_reginfo); } #ifdef CONFIG_USER_ONLY