From patchwork Sun Sep 14 19:38:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 37393 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f72.google.com (mail-ee0-f72.google.com [74.125.83.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 6CAE2206A5 for ; Sun, 14 Sep 2014 19:38:51 +0000 (UTC) Received: by mail-ee0-f72.google.com with SMTP id d17sf1708869eek.3 for ; Sun, 14 Sep 2014 12:38:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=ucTxPKf0T2xllXLFWhzB1ewKSjbg8kCxdF2WWzk/Op8=; b=CrNGt7eiKQTNRsTfKk7zzFrSoGabcq0yAjAFMWsvzDHx/Z3n2OvCbQA3XfAx9qrLhn RhTXyGNEH8y/mFHpnHqWuulLaQsm366f63+PBeoiPrzCgeGu1resuiJFpnc7BxyMtCpw uuDBdX9u3vlug+7laScTQoBpMcRBS76dNjwPlihZPPHXsUYRDhVCUTR+HkRGnWSSIWyJ sz4ASIUjCchV6SwrcVks2T08DQgXZ2vXzrhIF9qIbaCfzpu5nO6h9PhL7nRrwawJX7R5 KQnzOEfvqwB3+AFjEYCtTKeSQFbCx/ceNrYUJyKF7SGRkuFCw2VaKtVqebqu5k+6F12s P7Tw== X-Gm-Message-State: ALoCoQnlb5u7YFkNP5Wnq4K2JCgKE4Ul4kyl8DiwsuIjkoTcI+R9yaHaWfhOBlWlEbPr9cQ32zSD X-Received: by 10.112.149.67 with SMTP id ty3mr6136731lbb.1.1410723530269; Sun, 14 Sep 2014 12:38:50 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.42.195 with SMTP id q3ls310873lal.22.gmail; Sun, 14 Sep 2014 12:38:49 -0700 (PDT) X-Received: by 10.152.44.162 with SMTP id f2mr3657442lam.84.1410723529712; Sun, 14 Sep 2014 12:38:49 -0700 (PDT) Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com [209.85.217.170]) by mx.google.com with ESMTPS id s7si16175008lbb.38.2014.09.14.12.38.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 14 Sep 2014 12:38:49 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) client-ip=209.85.217.170; Received: by mail-lb0-f170.google.com with SMTP id c11so3462068lbj.29 for ; Sun, 14 Sep 2014 12:38:49 -0700 (PDT) X-Received: by 10.112.76.6 with SMTP id g6mr22190373lbw.22.1410723529560; Sun, 14 Sep 2014 12:38:49 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.112.130.169 with SMTP id of9csp113274lbb; Sun, 14 Sep 2014 12:38:49 -0700 (PDT) X-Received: by 10.194.57.237 with SMTP id l13mr4481118wjq.102.1410723529082; Sun, 14 Sep 2014 12:38:49 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [81.2.115.146]) by mx.google.com with ESMTPS id f17si11673432wiw.47.2014.09.14.12.38.48 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 14 Sep 2014 12:38:49 -0700 (PDT) Received-SPF: none (google.com: pm215@archaic.org.uk does not designate permitted sender hosts) client-ip=81.2.115.146; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1XTFdH-0004fD-Cm; Sun, 14 Sep 2014 20:38:47 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, qemu-ppc@nongnu.org, Alexander Graf Subject: [PATCH] hw/pci/ppc4xx_pci.c: Remove unused pci4xx_cfgaddr_read/write/ops Date: Sun, 14 Sep 2014 20:38:47 +0100 Message-Id: <1410723527-17902-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.170 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The MemoryRegionOps struct pci4xx_cfgaddr_ops and the read and write functions it references are all unused; remove them. Signed-off-by: Peter Maydell --- This is rather applying a blunt instrument to the code -- maybe the ops should be used for something instead? (cf the comment about splitting memory regions in ppc4xx_pcihost_initfn()...) hw/ppc/ppc4xx_pci.c | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/hw/ppc/ppc4xx_pci.c b/hw/ppc/ppc4xx_pci.c index 55a3cab..0bb3cdb 100644 --- a/hw/ppc/ppc4xx_pci.c +++ b/hw/ppc/ppc4xx_pci.c @@ -92,30 +92,6 @@ typedef struct PPC4xxPCIState PPC4xxPCIState; #define PCI_ALL_SIZE (PCI_REG_BASE + PCI_REG_SIZE) -static uint64_t pci4xx_cfgaddr_read(void *opaque, hwaddr addr, - unsigned size) -{ - PPC4xxPCIState *ppc4xx_pci = opaque; - PCIHostState *phb = PCI_HOST_BRIDGE(ppc4xx_pci); - - return phb->config_reg; -} - -static void pci4xx_cfgaddr_write(void *opaque, hwaddr addr, - uint64_t value, unsigned size) -{ - PPC4xxPCIState *ppc4xx_pci = opaque; - PCIHostState *phb = PCI_HOST_BRIDGE(ppc4xx_pci); - - phb->config_reg = value & ~0x3; -} - -static const MemoryRegionOps pci4xx_cfgaddr_ops = { - .read = pci4xx_cfgaddr_read, - .write = pci4xx_cfgaddr_write, - .endianness = DEVICE_LITTLE_ENDIAN, -}; - static void ppc4xx_pci_reg_write4(void *opaque, hwaddr offset, uint64_t value, unsigned size) {