From patchwork Fri Jan 12 11:31:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 124308 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp1996942qgn; Fri, 12 Jan 2018 04:24:44 -0800 (PST) X-Google-Smtp-Source: ACJfBovVrJzyXwlfubNy3SRsjyv+CBmRQu2i36mj7nZn+MXhYhtwI/miEQOAa+xl79HkFNgnrxPO X-Received: by 10.37.216.3 with SMTP id p3mr23267513ybg.84.1515759884840; Fri, 12 Jan 2018 04:24:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515759884; cv=none; d=google.com; s=arc-20160816; b=K62wesPUJ08eZh4eUFEEc9Pb2bko2zrKhuRH63ju/74SfigXLNaLeB06mQsoOXkZ6l PbSuxSbPBy+0JD8Ge5CzIc6WQ4aClSvCUqu5b0Yu2NzR8WenB/12aHWsHTse88XMvaC6 eSC8W7rw5gm2tS3PUQ+AIdq50dEoRZ332lCfVpnLDumYmwwAC5KxH15zHwGnZYfrratx /F4MxZy2kitf4tS0atDLF76F5DNyLSsRLBxIBsSPjvItIX5SdR2Y9nKzmdVHL/yTxjwE LC5D62o9LV8iZaIAsdPayZ9r+F/hbflkiO/Z2GSkbyGBe4bQA+OdO/OYnZ5KXeZsW4hU cJgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=M0ZMFLJUiCrUyWZeCMLargX01+hYB4hFZwDirfHBgGc=; b=SkAFJFToVJ2DYy11yjZtnUT2RWbHYGm9mrTc/g+1VD/BFTASbwKZ8nMdjfOZFtFwoN r36mYzxY1ZMJdUPlNXoOGF6jBbYq5nkKKN6YJqlVy2I29TxQnLQFc11f9Of49m4FZ9DH l92utlyYfF+11NBJo0z9A/H03b7jHdrncW6M7j9UENEk+9YW8ruwqx2MkA7Zq87btsCq lgO4Jm6Eq9Dy9CUT7gJdV7AmzrtELyT9EEKhrkPQSgQ75rpIlKE7o6PiLoIJ3FgjfHnx B/qoXNRcLFHVPpEkwVJpgLKMo1RkdyktlQhsJzCOTrv0B+vlD3CvIc9bJvK7JNfcl5ha LtjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Hu4qz35W; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id o2si2540045ywc.795.2018.01.12.04.24.44 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 12 Jan 2018 04:24:44 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Hu4qz35W; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:36863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZyO4-0004MD-C6 for patch@linaro.org; Fri, 12 Jan 2018 07:24:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZxZP-000855-Kv for qemu-devel@nongnu.org; Fri, 12 Jan 2018 06:32:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZxZO-00066R-Kq for qemu-devel@nongnu.org; Fri, 12 Jan 2018 06:32:23 -0500 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:41786) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZxZO-00065r-CN for qemu-devel@nongnu.org; Fri, 12 Jan 2018 06:32:22 -0500 Received: by mail-wm0-x22e.google.com with SMTP id g75so11524094wme.0 for ; Fri, 12 Jan 2018 03:32:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M0ZMFLJUiCrUyWZeCMLargX01+hYB4hFZwDirfHBgGc=; b=Hu4qz35WmvxrEVWbzhnSNYc9X4sVjecxETQ8I5sdCAhTiqwvjsOTJYlndlVXzemNm1 u4E08uMqB/VMQyypKXXwNK8PfVKk0Moj7xk2hx2QEonowNvLv8SRU4w2eb8jHwhrzAjr x3ecyaOPnqtWxbZN0f5KGglSsE8JCjOeCXIWy3NSQJshEH/jn2R+WMzkEP7fWRZMb109 q8WcJnpy750mPRN5QAx7OyIXfKgl+iHpoS/f6XW29yk4T8azfkd1zfFcpEKtPbkO8CbW GcwqZ3oMF74gjknI17sdNOzV7bOsxV5gxH4wCTkeGnOnXi0aLUxrpGo2Qnhdnum/uEko +YYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=M0ZMFLJUiCrUyWZeCMLargX01+hYB4hFZwDirfHBgGc=; b=JsAjQrtMxEBQFXBwvh2PTNRr5zj3bbExMsej3M1DkfhZ53WqI86fmK1t0skeDWO67T Mia0lM2e0KbiugHOI1uCwi3QuY20tZwALiRnh0Q521hQ7Xug/w+02Dh2RF6P7r/uZKXQ kbxRhbH5NLcR7uyskBy/Y0aKpC2CblnaqFcdqdnS5X/B10y5CIC+3BDkZpfrPM60hTUu Nl2Wk95drN/zb19PYk006cjF9rr1NE9UsQn+vbchk5SWnoIuykEElb5qlRcSQNURjefM anVyS+9HQOJMYbde/57E0noh8Q5NDltuufU3t/oh5hyn6JAfaxYH6gdmI35p81eOWKLD Wv5A== X-Gm-Message-State: AKwxytdvLuwvtOMmU4+LO7PTsayFHSmYb2qthj7/6MJRk5WZdHpMuWfG 7pRVEtdQ+TwbwLxyh6Iyx8hyV6c4 X-Received: by 10.28.35.200 with SMTP id j191mr4194322wmj.146.1515756740980; Fri, 12 Jan 2018 03:32:20 -0800 (PST) Received: from 640k.lan (dynamic-adsl-78-12-229-84.clienti.tiscali.it. [78.12.229.84]) by smtp.gmail.com with ESMTPSA id l8sm2732271wmg.46.2018.01.12.03.32.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Jan 2018 03:32:20 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 12 Jan 2018 12:31:16 +0100 Message-Id: <1515756676-3860-53-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1515756676-3860-1-git-send-email-pbonzini@redhat.com> References: <1515756676-3860-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22e Subject: [Qemu-devel] [PULL 52/52] scripts/analyse-locks-simpletrace.py: script to analyse lock times X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée This script allows analysis of mutex acquisition and hold times based on a trace file. Given a trace control file of: qemu_mutex_lock qemu_mutex_locked qemu_mutex_unlock And running with: $QEMU $QEMU_ARGS -trace events=./lock-trace You can analyse the results with: ./scripts/analyse-locks-simpletrace.py trace-events-all ./trace-21812 Signed-off-by: Alex Bennée Signed-off-by: Paolo Bonzini --- scripts/analyse-locks-simpletrace.py | 99 ++++++++++++++++++++++++++++++++++++ 1 file changed, 99 insertions(+) create mode 100755 scripts/analyse-locks-simpletrace.py -- 1.8.3.1 diff --git a/scripts/analyse-locks-simpletrace.py b/scripts/analyse-locks-simpletrace.py new file mode 100755 index 0000000..a69ed5c --- /dev/null +++ b/scripts/analyse-locks-simpletrace.py @@ -0,0 +1,99 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*- +# +# Analyse lock events and +# +# Author: Alex Bennée +# + +import os +import simpletrace +import argparse +import numpy as np + +class MutexAnalyser(simpletrace.Analyzer): + "A simpletrace Analyser for checking locks." + + def __init__(self): + self.locks = 0 + self.locked = 0 + self.unlocks = 0 + self.mutex_records = {} + + def _get_mutex(self, mutex): + if not mutex in self.mutex_records: + self.mutex_records[mutex] = {"locks": 0, + "lock_time": 0, + "acquire_times": [], + "locked": 0, + "locked_time": 0, + "held_times": [], + "unlocked": 0} + + return self.mutex_records[mutex] + + def qemu_mutex_lock(self, timestamp, mutex, filename, line): + self.locks += 1 + rec = self._get_mutex(mutex) + rec["locks"] += 1 + rec["lock_time"] = timestamp[0] + rec["lock_loc"] = (filename, line) + + def qemu_mutex_locked(self, timestamp, mutex, filename, line): + self.locked += 1 + rec = self._get_mutex(mutex) + rec["locked"] += 1 + rec["locked_time"] = timestamp[0] + acquire_time = rec["locked_time"] - rec["lock_time"] + rec["locked_loc"] = (filename, line) + rec["acquire_times"].append(acquire_time) + + def qemu_mutex_unlock(self, timestamp, mutex, filename, line): + self.unlocks += 1 + rec = self._get_mutex(mutex) + rec["unlocked"] += 1 + held_time = timestamp[0] - rec["locked_time"] + rec["held_times"].append(held_time) + rec["unlock_loc"] = (filename, line) + + +def get_args(): + "Grab options" + parser = argparse.ArgumentParser() + parser.add_argument("--output", "-o", type=str, help="Render plot to file") + parser.add_argument("events", type=str, help='trace file read from') + parser.add_argument("tracefile", type=str, help='trace file read from') + return parser.parse_args() + +if __name__ == '__main__': + args = get_args() + + # Gather data from the trace + analyser = MutexAnalyser() + simpletrace.process(args.events, args.tracefile, analyser) + + print ("Total locks: %d, locked: %d, unlocked: %d" % + (analyser.locks, analyser.locked, analyser.unlocks)) + + # Now dump the individual lock stats + for key, val in sorted(analyser.mutex_records.iteritems(), + key=lambda (k,v): v["locks"]): + print ("Lock: %#x locks: %d, locked: %d, unlocked: %d" % + (key, val["locks"], val["locked"], val["unlocked"])) + + acquire_times = np.array(val["acquire_times"]) + if len(acquire_times) > 0: + print (" Acquire Time: min:%d median:%d avg:%.2f max:%d" % + (acquire_times.min(), np.median(acquire_times), + acquire_times.mean(), acquire_times.max())) + + held_times = np.array(val["held_times"]) + if len(held_times) > 0: + print (" Held Time: min:%d median:%d avg:%.2f max:%d" % + (held_times.min(), np.median(held_times), + held_times.mean(), held_times.max())) + + # Check if any locks still held + if val["locks"] > val["locked"]: + print (" LOCK HELD (%s:%s)" % (val["locked_loc"])) + print (" BLOCKED (%s:%s)" % (val["lock_loc"]))