From patchwork Tue Dec 6 15:00:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 86854 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp2059819qgi; Tue, 6 Dec 2016 07:02:57 -0800 (PST) X-Received: by 10.237.54.97 with SMTP id e88mr60636389qtb.57.1481036577859; Tue, 06 Dec 2016 07:02:57 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [208.118.235.17]) by mx.google.com with ESMTPS id v127si11899073qkh.28.2016.12.06.07.02.57 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 06 Dec 2016 07:02:57 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:60815 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEHGj-0000xp-ED for patch@linaro.org; Tue, 06 Dec 2016 10:02:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cEHFB-0000Eq-W5 for qemu-devel@nongnu.org; Tue, 06 Dec 2016 10:01:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cEHF7-0005H5-Fh for qemu-devel@nongnu.org; Tue, 06 Dec 2016 10:01:22 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:37765) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cEHF7-0005Gk-05 for qemu-devel@nongnu.org; Tue, 06 Dec 2016 10:01:17 -0500 Received: by mail-wm0-f41.google.com with SMTP id t79so128836068wmt.0 for ; Tue, 06 Dec 2016 07:01:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pe3uYZyQ3AiGMxlzqTfqxmvJfShV9p579vkBBP+CLFA=; b=ZeBFSNLZzA4MrlTZ5i2LjpGyF+3OmpbO2zYMn9CKXAmuhyd2T8a4iGrVZUpG2ATnpa jYk04xtlFpXZEx9jabytfxOvpMzGrsOn9N26gP79jn9YS0R8u+8GYSSGL15FfLrrmtvd C6gF5bZOm6Omr1wWx+/pG6u+0byMiGPfOR0XA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pe3uYZyQ3AiGMxlzqTfqxmvJfShV9p579vkBBP+CLFA=; b=esKSLRVdHTclDZtzXoN6KJHmyljMSVc4K8HA5bfohRGFMqfGkTR6yBJS1Z7JJiDgNi IhNjX1puijwIy2C5U/t9CQ7EojdvCjZ1PXYP/wkmUsa9DjgtQ7f4FfCRSzgOcho3Un3S B3an7ohptvK5IChrOYZL+A742Fn6ukspcWWGFfZVFwOZKftr7f1F6UMte+QyQtamleB8 7diCE5nq34kj4vOq6manj7/PZCidWfJWX7a46S/FJZ+D/sFGe1RKHhs8Orv2vaumz0Az CD2bAJVAbQvh25PvbebXkhgi46/iDSfvYCEWCPyUbGwc4ma3V5nhl/cagSSYNSUswaXe AnFg== X-Gm-Message-State: AKaTC0380zs1YXcayg7ZlTSvzxkNKuFvlFoluFR4+6EGCpc3zLf4mOePA9lV/xWtfNZH0wvJ X-Received: by 10.28.216.9 with SMTP id p9mr2968051wmg.11.1481036415120; Tue, 06 Dec 2016 07:00:15 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id m145sm4454782wma.3.2016.12.06.07.00.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Dec 2016 07:00:14 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id C5A773E0203; Tue, 6 Dec 2016 15:00:13 +0000 (GMT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Tue, 6 Dec 2016 15:00:04 +0000 Message-Id: <20161206150004.19758-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.10.2 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 74.125.82.41 Subject: [Qemu-devel] [RFC PATCH for 2.9] gdbstub: remove spurious tb_flush() calls X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, rth@twiddle.net, =?UTF-8?q?Alex=20Benn=C3=A9e?= , pbonzini@redhat.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" These are (now) mostly harmless but not needed. The correct place to flush if you want to is in the TCG aware code and not in gdbstub. Currently flushes are triggered for cpu_single_step() and breakpoint manipulation. Signed-off-by: Alex Bennée --- gdbstub.c | 2 -- 1 file changed, 2 deletions(-) -- 2.10.2 diff --git a/gdbstub.c b/gdbstub.c index de62d26..ea48415 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1274,7 +1274,6 @@ static void gdb_vm_state_change(void *opaque, int running, RunState state) cpu->watchpoint_hit = NULL; goto send_packet; } - tb_flush(cpu); ret = GDB_SIGNAL_TRAP; break; case RUN_STATE_PAUSED: @@ -1513,7 +1512,6 @@ gdb_handlesig(CPUState *cpu, int sig) /* disable single step if it was enabled */ cpu_single_step(cpu, 0); - tb_flush(cpu); if (sig != 0) { snprintf(buf, sizeof(buf), "S%02x", target_signal_to_gdb(sig));