From patchwork Mon Jul 10 19:21:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 107320 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp3838884qge; Mon, 10 Jul 2017 12:25:06 -0700 (PDT) X-Received: by 10.55.132.135 with SMTP id g129mr6450037qkd.36.1499714706336; Mon, 10 Jul 2017 12:25:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499714706; cv=none; d=google.com; s=arc-20160816; b=hFZY/8UOzgp6pgXBXHaVRT4iTCG0V+8fU9+d4TW104ax+ngzcpi6dZqekUVSYjke9T YIxU6bbnEQyL6KF2nt1Q5f8V5IfWciGvi1lmZYqLzEdatqME9CBcre1l4nnnCNZW6NR7 cUuwrK5yLqNsDIz3Iz0Oz6q9/SGumHrg68W3E6B1IYuy7t/XP8DdTVqxjLy2knCqA9aB 3QAI6RqiOk0Ulgje7q2QZaTTOQr1AFrc0gMWIJWBv2SfGkSunxCIMspf4TbTM5xLOnje pmpFSkrnctQzzbS+O2kJfAQEOr3SCdyrqDpffslaoKfcTKElgydKp2/ukKwlGUT3gk8v 4rFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=miagGu2m06GsBWnbGIrgvqPDRnh1k6uVQW1God4w2uQ=; b=gqc/gpCYax7kCXA77ge2dqBVi0g7vOT4Cw1SPKzsgOwbiIG0hwVkLohJJ5GjA3Q6JL be4WROHPcutWlKbdLeAinEHBdMfNsIfsgP9c7wPjq+GKru/OqWwIlqOWnGxp0uESqjkD TXx1x6043cbkORJPp7GU9zc+S72/I3nePXOEpF26Em7bDCRrY4pU4dwKoP/ejSS2nT3d vWP+blAQSi46+tvxo3mbj7Fdr0Y49CNEJxD/7aS8d2UabKzaXomNBjog1KW4I4dT1xRu 9FCE+VgW2VOEfm0HnikCzIlEZeLKbapW0k4d0MI4OjWMMXuY8wb1Lwj7+c+qjAqyoPnv N6oQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.b=dN7P2uRh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [208.118.235.17]) by mx.google.com with ESMTPS id x7si11442704qtx.301.2017.07.10.12.25.05 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 10 Jul 2017 12:25:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.b=dN7P2uRh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42629 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUeIp-0001Sd-OB for patch@linaro.org; Mon, 10 Jul 2017 15:25:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUeGS-00087Q-6J for qemu-devel@nongnu.org; Mon, 10 Jul 2017 15:22:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUeGR-00077D-Bc for qemu-devel@nongnu.org; Mon, 10 Jul 2017 15:22:36 -0400 Received: from mail-wr0-f169.google.com ([209.85.128.169]:36026) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dUeGR-00076u-4n for qemu-devel@nongnu.org; Mon, 10 Jul 2017 15:22:35 -0400 Received: by mail-wr0-f169.google.com with SMTP id c11so151877945wrc.3 for ; Mon, 10 Jul 2017 12:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=miagGu2m06GsBWnbGIrgvqPDRnh1k6uVQW1God4w2uQ=; b=dN7P2uRheBG0/JkrH1vk1kqSvJKybxYAzHJTb8ibf5rV0v+EJMRF6b2OmwGzSEyG3u j1E2h2/Me1SK438VE9Eh8IPBZf/V0n3q36mHBNzIRRnkrNIxAhk5AnDmGlXm1X9fTxig YerJOJSdob2/Kpc9G44qTA3PW3ksK18lg6Dl0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=miagGu2m06GsBWnbGIrgvqPDRnh1k6uVQW1God4w2uQ=; b=LeKw+2z7WL2fEv89u40tBEXNuVdSx2W/k/Zz24bAyEfVyPPnG5NfZAwzCkoKETaw2P DuFRMYBcmCJRaNnaUP4bUhUiGXF1vhjruyK6EecOUqm13e64HXX31GywsQLxhPUGyczB J6CyU3shLI/Pnci+qTARZke+qxVrTB/y3JoMiWgyhHIsmWWUZO+1a5LlxeedYGrO2rpN 6Yywbf2n46ThArXAH+szRjiU6W80CcWniARI/kYrZ8oPrDx7SIXr70RZci8FjG0TkfzI uMLBlP45pneVgGJP0OyfGd99BlcQ0OFtM/4732V1DGuxEFtCeYh2Em3kEpaiJPWOmd0B cdvA== X-Gm-Message-State: AIVw113PyztcgGsAQtl8LhgjUP/jVOM2QG9XRF4UHsV7WbcCtAwEnQ25 MFPrRwQUnUbF8SYU X-Received: by 10.28.57.197 with SMTP id g188mr8735824wma.13.1499714494091; Mon, 10 Jul 2017 12:21:34 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id r200sm5501975wmd.20.2017.07.10.12.21.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Jul 2017 12:21:32 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id A317F3E0641; Mon, 10 Jul 2017 20:21:28 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org, rth@twiddle.net, cota@braap.org Date: Mon, 10 Jul 2017 20:21:26 +0100 Message-Id: <20170710192128.9048-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170710192128.9048-1-alex.bennee@linaro.org> References: <20170710192128.9048-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.128.169 Subject: [Qemu-devel] [PATCH v2 3/5] target/arm/translate.h: expand comment on DISAS_EXIT X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:ARM" , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" We already have an exit condition, DISAS_UPDATE which will exit the run-loop. Expand on the difference with DISAS_EXIT in the comments. Signed-off-by: Alex Bennée --- target/arm/translate.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.13.0 Reviewed-by: Richard Henderson diff --git a/target/arm/translate.h b/target/arm/translate.h index 15d383d9af..12fd79ba8e 100644 --- a/target/arm/translate.h +++ b/target/arm/translate.h @@ -140,7 +140,10 @@ static void disas_set_insn_syndrome(DisasContext *s, uint32_t syn) */ #define DISAS_BX_EXCRET 11 /* For instructions which want an immediate exit to the main loop, - * as opposed to attempting to use lookup_and_goto_ptr. + * as opposed to attempting to use lookup_and_goto_ptr. Unlike + * DISAS_UPDATE this doesn't write the PC on exiting the translation + * loop so you need to ensure something (gen_a64_set_pc_im or runtime + * helper) has done so before we reach return from cpu_tb_exec. */ #define DISAS_EXIT 12