From patchwork Fri Sep 22 22:55:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Liang Yan X-Patchwork-Id: 114109 Delivered-To: patch@linaro.org Received: by 10.140.106.117 with SMTP id d108csp56166qgf; Fri, 22 Sep 2017 15:56:14 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCYn3RJtHOj2e+B2G/YW3NKBxZx8QKfMqzoGb/7oJidoCZGSTYmGYIP/lUswXKLzX9iRszj X-Received: by 10.200.24.65 with SMTP id n1mr1055587qtk.323.1506120974834; Fri, 22 Sep 2017 15:56:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1506120974; cv=none; d=google.com; s=arc-20160816; b=QL9xAqMRwe1b5q+7CaboKEgrPZ+IQ2ORXfpWZmf/I0PsvDExevJjK0d7uMlQmlOdLo SSbUBzKNkrvk1v5sZmWNbzI81vwTnYLtJjti6rM+0S8Jn3U9OGdYlGd26GYNjp2GGNXn 1sTZI06O38Z2sM7TSkvHO37ql5TnlS5g3B/xM91kT/aEiUOuCohjAO5bmWkF/Nm9Dumg 5gBD8Csq5Qy+XN0Z4TdQjPgRe6ZTMWJ8ZW5rYPPyzU87PgnSN5VoW6mbNT8OF8hGX5Z0 TO/1ySr49Ct7mMfLDzZKnh069Bf7iKxv7CI4WP0sUjg29VDk3mNi90g9QZOqlOKVqXto WHWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:to:from :arc-authentication-results; bh=SMyj6ZSRgV1X3DWhJ99C/LDYI5yw9lLpSjZKA6dtDhs=; b=fSF5DpmfYpsKkga4T79Mg8AeyTFll3lsWfPzwed7UET5qdzLa8MT1MPkKcnYIshL7a ebroO1ecwRno67cqscUhsz8fsijdeE0C+t9zvPwLcsnlj8QvG582OKZU+zW7JKjZtAMf GKaDBY4Rn2bE1M8Gn+G8/0WAV+PYY6XS/2k8XZ9NML3cHiX7skMoLa8/C4PAAPxFeZYN NpmHL4u+QOq+IGwAtOQFDx0bBhuO7WmddNkFeIYQm3XTdoXkBFbd0OJvGK5YblkSusjh HoGQh7p0nK/YqBy9k3KuwFM244/0VoNoAaXj7xx4av/r19avgcKmh52aeezPj+BaDv53 1BEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 137si775430qkk.547.2017.09.22.15.56.14 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 22 Sep 2017 15:56:14 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:33062 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvWrk-00051v-TJ for patch@linaro.org; Fri, 22 Sep 2017 18:56:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvWrX-0004z1-3Z for qemu-devel@nongnu.org; Fri, 22 Sep 2017 18:56:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvWrU-0006kw-1P for qemu-devel@nongnu.org; Fri, 22 Sep 2017 18:55:59 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:46555) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dvWrT-0006hC-Bl; Fri, 22 Sep 2017 18:55:55 -0400 Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Sat, 23 Sep 2017 00:55:52 +0200 Received: from linux-vqw3.gns.novell.com (nwb-a10-snat.microfocus.com [10.120.13.201]) by emea4-mta.ukb.novell.com with ESMTP (TLS encrypted); Fri, 22 Sep 2017 23:55:39 +0100 From: Liang Yan To: samuel.thibault@ens-lyon.org, pbonzini@redhat.com, marcandre.lureau@redhat.com Date: Fri, 22 Sep 2017 18:55:33 -0400 Message-Id: <20170922225533.1928-1-lyan@suse.com> X-Mailer: git-send-email 2.14.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 195.135.221.5 Subject: [Qemu-devel] [PATCH] chardev/baum: fix baum that releases brlapi twice X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Error process of baum_chr_open needs to set brlapi null, so it won't get released twice in char_braille_finalize, which will cause "/usr/bin/qemu-system-x86_64: double free or corruption (!prev)" Signed-off-by: Liang Yan --- chardev/baum.c | 1 + 1 file changed, 1 insertion(+) -- 2.14.1 Reviewed-by: Marc-André Lureau diff --git a/chardev/baum.c b/chardev/baum.c index 302dd9666c..67fd783a59 100644 --- a/chardev/baum.c +++ b/chardev/baum.c @@ -643,6 +643,7 @@ static void baum_chr_open(Chardev *chr, error_setg(errp, "brlapi__openConnection: %s", brlapi_strerror(brlapi_error_location())); g_free(handle); + baum->brlapi = NULL; return; } baum->deferred_init = 0;