From patchwork Tue Oct 31 11:25:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pavel Dovgalyuk X-Patchwork-Id: 117591 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp3789845qgn; Tue, 31 Oct 2017 04:38:33 -0700 (PDT) X-Google-Smtp-Source: ABhQp+RniEqIdPkF4N21Hi7MGg48C20/Kkcm8JItF3vYHGbppFnHS42NtjygSgp2tJA3UJTJcUYo X-Received: by 10.37.210.19 with SMTP id j19mr915938ybg.476.1509449913457; Tue, 31 Oct 2017 04:38:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1509449913; cv=none; d=google.com; s=arc-20160816; b=Zmed5hB8+/oS2dDtn4NxUU2LNooMiHsT/vDDQqt9MVHghfqQJk08fLa+W1nzePMixS 9lH5LIBY9e2h+EaNoQYpqXfu/YNBLqUYnFBmmDnv72UWs1sPcUEt9xD8raOI2F/aWuzw JjLs/8URz7d0o8HX+kMdXGmoO0mTBB8jcz8iKgdMcTFXi03jdiiYXFBOhXKjOL8Duxb6 9XVVAbkFz8AmFdFv956QfKkeCNDFeAiJY//pejMuL3YeJUWLRSeI80sk92hVDLnf29HP R9lLqz0bY1+NTYphyr6P8fqtuhaVqFKfqLY0ZFRk9D2MhUs7DgUsMev/p3+U3YNe32Qe Cf8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:user-agent:references :in-reply-to:message-id:date:to:from:arc-authentication-results; bh=rs1qWJWv8UDbdM1egYNaxIk0TpwVSiUjobYQ5TjYI7s=; b=g5rctRRt0VLZk0e9aPuSfG3hX3IawKqhN1b/MdjYrHS6DoSDknJI/P5YnkTpi8gQZ+ 54Gg9IXJ8l0plx8G9yVetvpbaVZEo5ZZGN5rmsb14Zq0L04iLkIM1DyTDzDTeZOk0qsO ZYX9eJheXOVCxTHzJYWrWVlnAr/EDrBcls9tLtQkfAKuDfN64Pk3+zg9fEnVxhnTEeu/ 9X9l3q/QwMjArh8UvpMvf1h+pXOJFAGKbeHDkfaj9Vc+m7YvaRteahQrSZcU+Hv7OdDB 2m3RZ9R78m9Ys7Lv0TkZRmsL0K6kT8ZppK1r1SFbkatx8gK9w5q/jQ15Ns59rapibj6w JmUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id k3si337612ywd.185.2017.10.31.04.38.33 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 31 Oct 2017 04:38:33 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:44925 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9UsK-0004tw-Ud for patch@linaro.org; Tue, 31 Oct 2017 07:38:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9UgC-0003L2-MN for qemu-devel@nongnu.org; Tue, 31 Oct 2017 07:26:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9UgB-0007zt-O0 for qemu-devel@nongnu.org; Tue, 31 Oct 2017 07:26:00 -0400 Received: from mail.ispras.ru ([83.149.199.45]:45114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9UgB-0007yh-Gn for qemu-devel@nongnu.org; Tue, 31 Oct 2017 07:25:59 -0400 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id 9E20854006A; Tue, 31 Oct 2017 14:25:58 +0300 (MSK) From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Tue, 31 Oct 2017 14:25:59 +0300 Message-ID: <20171031112559.10516.57546.stgit@pasha-VirtualBox> In-Reply-To: <20171031112457.10516.8971.stgit@pasha-VirtualBox> References: <20171031112457.10516.8971.stgit@pasha-VirtualBox> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [RFC PATCH 11/26] target/arm/arm-powertctl: drop BQL assertions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, pavel.dovgaluk@ispras.ru, mst@redhat.com, jasowang@redhat.com, quintela@redhat.com, zuban32s@gmail.com, maria.klimushenkova@ispras.ru, dovgaluk@ispras.ru, kraxel@redhat.com, boost.lists@gmail.com, pbonzini@redhat.com, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée The powerctl code is run in the context of the vCPU changing power state. It does not need the BQL to protect its changes. Signed-off-by: Alex Bennée --- target/arm/arm-powerctl.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/target/arm/arm-powerctl.c b/target/arm/arm-powerctl.c index 25207cb..9661a59 100644 --- a/target/arm/arm-powerctl.c +++ b/target/arm/arm-powerctl.c @@ -124,7 +124,6 @@ static void arm_set_cpu_on_async_work(CPUState *target_cpu_state, g_free(info); /* Finally set the power status */ - assert(qemu_mutex_iothread_locked()); target_cpu->power_state = PSCI_ON; } @@ -135,8 +134,6 @@ int arm_set_cpu_on(uint64_t cpuid, uint64_t entry, uint64_t context_id, ARMCPU *target_cpu; struct CpuOnInfo *info; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 " (EL %d, %s) @ 0x%" PRIx64 " with R0 = 0x%" PRIx64 "\n", cpuid, target_el, target_aa64 ? "aarch64" : "aarch32", entry, context_id); @@ -227,7 +224,6 @@ static void arm_set_cpu_off_async_work(CPUState *target_cpu_state, { ARMCPU *target_cpu = ARM_CPU(target_cpu_state); - assert(qemu_mutex_iothread_locked()); target_cpu->power_state = PSCI_OFF; target_cpu_state->halted = 1; target_cpu_state->exception_index = EXCP_HLT; @@ -238,8 +234,6 @@ int arm_set_cpu_off(uint64_t cpuid) CPUState *target_cpu_state; ARMCPU *target_cpu; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 "\n", cpuid); /* change to the cpu we are powering up */ @@ -274,8 +268,6 @@ int arm_reset_cpu(uint64_t cpuid) CPUState *target_cpu_state; ARMCPU *target_cpu; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 "\n", cpuid); /* change to the cpu we are resetting */