From patchwork Tue Nov 14 08:17:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pavel Dovgalyuk X-Patchwork-Id: 118844 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp2763187qgn; Tue, 14 Nov 2017 00:24:39 -0800 (PST) X-Google-Smtp-Source: AGs4zMZFHAP0ck80LBSnM61ulvAXsOxRGY5r1LCUnApNT00tK3Cjx/QNW8PdLt2bO6ReOfXTgLES X-Received: by 10.37.163.1 with SMTP id d1mr6936695ybi.367.1510647879377; Tue, 14 Nov 2017 00:24:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1510647879; cv=none; d=google.com; s=arc-20160816; b=qyZl2fCUy+zEsgEwlV7X3EBAfTBIo68zcY2spvum295EdR4fyNbGPOwHVccjl9to7l psHLibdManSUf+O2Yfpx2srq4OKjr/MHlm2Tvt80ZWMatTSG2+FHgwsHTH//FR5g0zB5 FybyFcr07PDTUjmyens8oDst8TKUOKh6LL9lCy2HOt0IVT+BDvhyiYKrGJ1atUm++l3c VLBM1uWYkU/o+2+v0gIsgOatCaMEAgWtK8GNLSIIcwhOwFc+XJWfrWyINB47wXh8zOuG 2SuSSKUJD3i82EFqH8RkJMnxSbzdwkloLVguZ1VyjgUZen6CpckdXUOoD6uVWCsTrm9I BkEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:user-agent:references :in-reply-to:message-id:date:to:from:arc-authentication-results; bh=rs1qWJWv8UDbdM1egYNaxIk0TpwVSiUjobYQ5TjYI7s=; b=KfDWt9xneTvAde7TOQGWKPZZlgySghGZPH3DF6zkKpIg1Xdeo90dMkwJFg0lL8O3cG 0I8EJUb/HPk84cTLo4iWzWNleJwZHTxo8ajwUDGrBxt9xZi+4GpcJPxCtXslTAbpRXv5 BjLhEOFU3ASxudvhkwtKocayxtW1q/M3MwKzwUxS78clYa005RN3U4k/xt9RUB/bZ3iu 8MTPI6KN0LV+k0ytdQoQQwIh2WdrhcG3DQVJ230Ix7NZuX7BItEP6ztq6OD0VnJMNaqX DepwqvVvwRKabffbyFQDfX4TR/yaGc4kl0m2Zsi50P1hTtj3DPsj122uAcHLRHfMTwhq lovw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id a66si659459ybg.439.2017.11.14.00.24.39 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 14 Nov 2017 00:24:39 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:58191 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEWWM-00067K-R9 for patch@linaro.org; Tue, 14 Nov 2017 03:24:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEWPS-0008G6-86 for qemu-devel@nongnu.org; Tue, 14 Nov 2017 03:17:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEWPO-0006LU-7Z for qemu-devel@nongnu.org; Tue, 14 Nov 2017 03:17:30 -0500 Received: from mail.ispras.ru ([83.149.199.45]:52640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEWPN-0006L7-Us for qemu-devel@nongnu.org; Tue, 14 Nov 2017 03:17:26 -0500 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id 16DC154006A; Tue, 14 Nov 2017 11:17:25 +0300 (MSK) From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Tue, 14 Nov 2017 11:17:33 +0300 Message-ID: <20171114081733.27640.74292.stgit@pasha-VirtualBox> In-Reply-To: <20171114081630.27640.53933.stgit@pasha-VirtualBox> References: <20171114081630.27640.53933.stgit@pasha-VirtualBox> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [RFC PATCH v2 11/26] target/arm/arm-powertctl: drop BQL assertions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, pavel.dovgaluk@ispras.ru, mst@redhat.com, jasowang@redhat.com, quintela@redhat.com, zuban32s@gmail.com, maria.klimushenkova@ispras.ru, dovgaluk@ispras.ru, kraxel@redhat.com, boost.lists@gmail.com, pbonzini@redhat.com, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée The powerctl code is run in the context of the vCPU changing power state. It does not need the BQL to protect its changes. Signed-off-by: Alex Bennée --- target/arm/arm-powerctl.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/target/arm/arm-powerctl.c b/target/arm/arm-powerctl.c index 25207cb..9661a59 100644 --- a/target/arm/arm-powerctl.c +++ b/target/arm/arm-powerctl.c @@ -124,7 +124,6 @@ static void arm_set_cpu_on_async_work(CPUState *target_cpu_state, g_free(info); /* Finally set the power status */ - assert(qemu_mutex_iothread_locked()); target_cpu->power_state = PSCI_ON; } @@ -135,8 +134,6 @@ int arm_set_cpu_on(uint64_t cpuid, uint64_t entry, uint64_t context_id, ARMCPU *target_cpu; struct CpuOnInfo *info; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 " (EL %d, %s) @ 0x%" PRIx64 " with R0 = 0x%" PRIx64 "\n", cpuid, target_el, target_aa64 ? "aarch64" : "aarch32", entry, context_id); @@ -227,7 +224,6 @@ static void arm_set_cpu_off_async_work(CPUState *target_cpu_state, { ARMCPU *target_cpu = ARM_CPU(target_cpu_state); - assert(qemu_mutex_iothread_locked()); target_cpu->power_state = PSCI_OFF; target_cpu_state->halted = 1; target_cpu_state->exception_index = EXCP_HLT; @@ -238,8 +234,6 @@ int arm_set_cpu_off(uint64_t cpuid) CPUState *target_cpu_state; ARMCPU *target_cpu; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 "\n", cpuid); /* change to the cpu we are powering up */ @@ -274,8 +268,6 @@ int arm_reset_cpu(uint64_t cpuid) CPUState *target_cpu_state; ARMCPU *target_cpu; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 "\n", cpuid); /* change to the cpu we are resetting */