From patchwork Tue Jan 9 12:22:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 123917 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp3967088qgn; Tue, 9 Jan 2018 04:34:43 -0800 (PST) X-Google-Smtp-Source: ACJfBotiRdTloEhcft/CDZbFjVnQw8fW8Zm+nmI+SqoGRMrzY2EWqQIBFd7N1ZSY4I0JsB4lN7MW X-Received: by 10.37.214.213 with SMTP id n204mr12094178ybg.67.1515501282995; Tue, 09 Jan 2018 04:34:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515501282; cv=none; d=google.com; s=arc-20160816; b=aje9jQOOx/3GareYxKr/66AWWECDGjKRK4jZi1Zz04ik5l63TLhCH8BaXhNS4ykpI7 wcvjgZ5a9Hn2kPr+nptKICGLjQO+dn34z2ccENeEmtirF/SqI0p5138DeRArZoKHIHlq nfgJ/qhrqS4oJ9Lt6lqgOUCOXavMYE1OHlTiIH5srpCW+2z/y6DmPybOb+0Y3QyudGW5 Tu9At1Bs6lJTo7dYIbW19TWvrFvIMMiutlX/q2igBEUBm09244PPO6CBeYVh2aic7VEK G8SMj9OCorwKPAojnfL0G/XtqqygoIZmduRpaiww3WCYO36lFkwvHzpqvTe15o4pvTEf CVng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=w73w7ZZQIMHcKkvA79sIXqgUK5/buI45QDc8gpNpU+E=; b=cMNPalOpeqMQvNWVCJTW/O2dDZUga1fV+YnmLJDlOpYzMV1f5nOoPdsQBJSd03NOhd g2nmciIvtimoMEYY58j34FykeOzydW4WaO1yAOVCr16fWeRE6HdY0CvMRE4MikrtO40D TLAM9M+Ph0/N/IAHg6gfAkiU14hCjEzXhW1iTs+ozQ+mV7FFkmTqvWkRqO+R+e1x9J6t b6TcnFXrbgut8biWujbaMxp9rEqfZwcb/MOnWb7W6473HXWGp7+4JNIgJ7TIa0y2x+z+ NtS1yZFJblPUsB70/pIqSh1gkgKKg3X6rPDymENQcgUGu4+lr7k0mL9oHoZC6UH8//6P QY5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=IfJKldQL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id x15si999220ywd.123.2018.01.09.04.34.42 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 09 Jan 2018 04:34:42 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=IfJKldQL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49552 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYt74-0007Rq-Cv for patch@linaro.org; Tue, 09 Jan 2018 07:34:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYsvu-0006jA-B1 for qemu-devel@nongnu.org; Tue, 09 Jan 2018 07:23:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYsvp-0006li-Sg for qemu-devel@nongnu.org; Tue, 09 Jan 2018 07:23:10 -0500 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:41544) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eYsvp-0006hg-MJ for qemu-devel@nongnu.org; Tue, 09 Jan 2018 07:23:05 -0500 Received: by mail-wm0-x241.google.com with SMTP id g75so20186467wme.0 for ; Tue, 09 Jan 2018 04:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w73w7ZZQIMHcKkvA79sIXqgUK5/buI45QDc8gpNpU+E=; b=IfJKldQLDdUzwauX2LkUXX+p7kQFwscvu5ASX8sdOSqLTJvcEBPOYLy+7/QCzTyRNW DEpn+vFi6frqOmSx/fZUN34K9huRpR8gvuUUKLV6icm4hshTwrzFYRuA7zLuR5O8lvrm 66PXdrVbxyisroCS/vTeJjEEm83W4OadkAQfE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w73w7ZZQIMHcKkvA79sIXqgUK5/buI45QDc8gpNpU+E=; b=AS0WpKUM0Z4CwOM6LmtXYTwSLjlRpK5WAXjk4H/w3hgT7rqqHdKtJByKI6NdlE03Js ECrNjAZCO+M8dYifJIKQccPv68TfmNaYqARbr9tOqNrnwTumDgasMRAKrvJ+oBerYv4Z mLn9BiPmgYILRy9DADQ56qhFYe2WQ78XhN3s4998UMBwqpfcZr+2vVSLRNfflolkBtA3 tlNHab97REBxyv74XL5uQjg3iYcCtHQk7YhVLIz6dHrmcZ11NnbdZu1kK6APGww7vSq0 DLO1S032dVfCnMIPBOn0XP/6UsilYeHzZ/cmATHBLU4ox8638CoGfCOT7Uid70/A7Mi+ QYSw== X-Gm-Message-State: AKGB3mLfFJ59vbKbv/KOvWcycooPUDS/abmae+pwZ6C8t4VysfM3PUFj OPZnaJC7aXrKAm9c0Ew0hULyw+GfSJQ= X-Received: by 10.28.106.26 with SMTP id f26mr11098557wmc.40.1515500584601; Tue, 09 Jan 2018 04:23:04 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id 31sm17529754wrw.8.2018.01.09.04.22.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jan 2018 04:22:59 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id B3D033E2B4B; Tue, 9 Jan 2018 12:22:52 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: richard.henderson@linaro.org, peter.maydell@linaro.org, laurent@vivier.eu, bharata@linux.vnet.ibm.com, andrew@andrewdutcher.com Date: Tue, 9 Jan 2018 12:22:40 +0000 Message-Id: <20180109122252.17670-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180109122252.17670-1-alex.bennee@linaro.org> References: <20180109122252.17670-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PATCH v2 08/20] fpu/softfloat: improve comments on ARM NaN propagation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org, Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Mention the pseudo-code fragment from which this is based and correct the spelling of signalling. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- fpu/softfloat-specialize.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.15.1 diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h index de2c5d5702..3d507d8c77 100644 --- a/fpu/softfloat-specialize.h +++ b/fpu/softfloat-specialize.h @@ -445,14 +445,15 @@ static float32 commonNaNToFloat32(commonNaNT a, float_status *status) #if defined(TARGET_ARM) static int pickNaN(flag aIsQNaN, flag aIsSNaN, flag bIsQNaN, flag bIsSNaN, - flag aIsLargerSignificand) + flag aIsLargerSignificand) { - /* ARM mandated NaN propagation rules: take the first of: - * 1. A if it is signaling - * 2. B if it is signaling + /* ARM mandated NaN propagation rules (see FPProcessNaNs()), take + * the first of: + * 1. A if it is signalling + * 2. B if it is signalling * 3. A (quiet) * 4. B (quiet) - * A signaling NaN is always quietened before returning it. + * A signalling NaN is always quietened before returning it. */ if (aIsSNaN) { return 0;