From patchwork Wed Jan 10 06:33:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 124021 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp4907831qgn; Tue, 9 Jan 2018 22:36:02 -0800 (PST) X-Google-Smtp-Source: ACJfBovjROnzCaytwVzW08Dj0eoVQ9TH4NFISZMVdTWkZM4dbE11/ANi1R+6dEp2YmXKxY+boS3Y X-Received: by 10.37.248.26 with SMTP id u26mr3712680ybd.313.1515566162335; Tue, 09 Jan 2018 22:36:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1515566162; cv=none; d=google.com; s=arc-20160816; b=V5H+V/eztmUESvm+4AHgm7QvWYUozWVDGdX3mXJb3rcFYlOzIcj2uIrmveQ/bF3HhW WZKyQCeLs0xVUs9ugRU9LPAoOc+5iCZk7BcMlymfgVWWRF2uOh1MGYRFxK5dUXkVMdIH 4tuOGgLuhSW3wqTk6xJfKmVyORdGzWwtw9pWkEIBO9fykO0zjPIuKLGZ0tJXDgX0vM7Y 0JarF7zvbz1W0YGsO+gxFf4Ha+wv8lg5Q/b02SB0UZDaGcAXdIISJNOvsfDo4f2RG6rM FlCRmFBEYKEgJ2QxX1h23Na+/FUELQqhMTXzYoZ/+vyzXUcUb0WUGO9bBUQqe89rdU6a hP7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=UFqJDWvUw1rDGkRcgOYidWu2Y9N8QkkSi1gxjUW7cl4=; b=oisfWU6MVLzqJAfT/jKcs8YhCJDz3+JC9Lte8jeDeKL9tsYf8CvEn9Z+hbUWqTNRQJ yoKSXLz16dqjtnPGasN9oF428aJXCyW6cTlw9HFMmEaR8ZXSMCEHdPTUr9+La95GaTRv zu2IqX5R+wy6IdABzABse9KLYk+WQmFTQUE+32kkodBm5ZDc7sUgHAaDTA5G0QxLtlgh FkUJdBoP0k90UKwT6nNm9bCmfQErDhMt72Id8e1HggDD9y0xe+P73AczCgCcchUPMqGr Tx/o0lgBvDGk2v9PW2nhVNoTcs5vjFDCsHE6czKJyozuWmXzmbTOkSLZpidXDUsh3igw ANcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hFQ7tTiX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id d3si48207ybl.316.2018.01.09.22.36.02 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 09 Jan 2018 22:36:02 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hFQ7tTiX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48396 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZ9zV-0002Ku-Uc for patch@linaro.org; Wed, 10 Jan 2018 01:36:01 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZ9xJ-0000ph-QY for qemu-devel@nongnu.org; Wed, 10 Jan 2018 01:33:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZ9xF-0007L7-WE for qemu-devel@nongnu.org; Wed, 10 Jan 2018 01:33:45 -0500 Received: from mail-pl0-x241.google.com ([2607:f8b0:400e:c01::241]:40665) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZ9xF-0007Kq-QR for qemu-devel@nongnu.org; Wed, 10 Jan 2018 01:33:41 -0500 Received: by mail-pl0-x241.google.com with SMTP id 62so6728388pld.7 for ; Tue, 09 Jan 2018 22:33:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UFqJDWvUw1rDGkRcgOYidWu2Y9N8QkkSi1gxjUW7cl4=; b=hFQ7tTiXKY2D1a3QKhBdAzAig5mBb7VGvaZ6WgaZWojWXLIBxzassI8KB64DVEJb9b oIXqtl/5wEmIrW1EYmNHZeGbsJ64vnpNW/Emruh3s83Uau76MUaxeV4GdOyX9DIINYFW LwpIlK3aIUlgvFJfc9Wi8BTJfEpbU/zLJtnQ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=UFqJDWvUw1rDGkRcgOYidWu2Y9N8QkkSi1gxjUW7cl4=; b=mcCX5ef6XFYNvJYMXRPgr3MaP0gtAARIY6886wZCbXH/UFQ7OLacYdJ+NlDTHmZWy7 21MFc0fnLbnk/vgNR974caMVWqA4OWFsigMDD81jXK91mDnEoPbOPWPUKhZwCwJVTYxe sl3Ql0Vcpb8Hnbuy/0E5LacsKQN/JdSME8J53/VQ8oJTZG3Ejdu1M+HZ9xXm0flTz0bN VNrTA4hRLq90KBXIIZrpL1/mghICLormxgeiBFaExHpND4GEthBIFssmCXvYWAZX0Znc nBxyV7JJU9N93mO6uZ7QAD/krblGGd3sYW1hE9FzFKV0Un9xpnOI9gxBkdLPD1Zh56N5 cuoA== X-Gm-Message-State: AKGB3mKBlYdi57EHyAOjHwTVAPc56IktA58P+8zxPyMJSvSoqz2po12j qqz0+SyzL0pr98ffgNGKYqrfNSDj19g= X-Received: by 10.84.247.141 with SMTP id o13mr17767075pll.285.1515566020484; Tue, 09 Jan 2018 22:33:40 -0800 (PST) Received: from pike.twiddle.net (97-113-183-164.tukw.qwest.net. [97.113.183.164]) by smtp.gmail.com with ESMTPSA id y1sm29172963pgc.52.2018.01.09.22.33.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Jan 2018 22:33:39 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 9 Jan 2018 22:33:36 -0800 Message-Id: <20180110063337.21538-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180110063337.21538-1-richard.henderson@linaro.org> References: <20180110063337.21538-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::241 Subject: [Qemu-devel] [PATCH 1/2] target/arm: Split out vfp_expand_imm X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 44 ++++++++++++++++++++++++++++---------------- 1 file changed, 28 insertions(+), 16 deletions(-) -- 2.13.6 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index ecb72e4d9c..e03cd3801a 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5014,6 +5014,33 @@ static void disas_fp_3src(DisasContext *s, uint32_t insn) } } +/* The imm8 encodes the sign bit, enough bits to represent an exponent in + * the range 01....1xx to 10....0xx, and the most significant 4 bits of + * the mantissa; see VFPExpandImm() in the v8 ARM ARM. + */ +static uint64_t vfp_expand_imm(int size, uint8_t imm8) +{ + uint64_t imm; + + switch (size) { + case MO_64: + imm = (extract32(imm8, 7, 1) ? 0x8000 : 0) | + (extract32(imm8, 6, 1) ? 0x3fc0 : 0x4000) | + extract32(imm8, 0, 6); + imm <<= 48; + break; + case MO_32: + imm = (extract32(imm8, 7, 1) ? 0x8000 : 0) | + (extract32(imm8, 6, 1) ? 0x3e00 : 0x4000) | + (extract32(imm8, 0, 6) << 3); + imm <<= 16; + break; + default: + g_assert_not_reached(); + } + return imm; +} + /* Floating point immediate * 31 30 29 28 24 23 22 21 20 13 12 10 9 5 4 0 * +---+---+---+-----------+------+---+------------+-------+------+------+ @@ -5037,22 +5064,7 @@ static void disas_fp_imm(DisasContext *s, uint32_t insn) return; } - /* The imm8 encodes the sign bit, enough bits to represent - * an exponent in the range 01....1xx to 10....0xx, - * and the most significant 4 bits of the mantissa; see - * VFPExpandImm() in the v8 ARM ARM. - */ - if (is_double) { - imm = (extract32(imm8, 7, 1) ? 0x8000 : 0) | - (extract32(imm8, 6, 1) ? 0x3fc0 : 0x4000) | - extract32(imm8, 0, 6); - imm <<= 48; - } else { - imm = (extract32(imm8, 7, 1) ? 0x8000 : 0) | - (extract32(imm8, 6, 1) ? 0x3e00 : 0x4000) | - (extract32(imm8, 0, 6) << 3); - imm <<= 16; - } + imm = vfp_expand_imm(MO_32 + is_double, imm8); tcg_res = tcg_const_i64(imm); write_fp_dreg(s, rd, tcg_res);