From patchwork Fri Jan 19 08:43:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pavel Dovgalyuk X-Patchwork-Id: 125122 Delivered-To: patch@linaro.org Received: by 10.46.66.141 with SMTP id h13csp197646ljf; Fri, 19 Jan 2018 01:00:57 -0800 (PST) X-Google-Smtp-Source: ACJfBotXx+f58yRSreL17jqI/+YLENDpF9zPKTmdXses5QYAoAAjJrGEAypoVVZW2+5uSl+mMdtc X-Received: by 10.129.46.151 with SMTP id u145mr9216703ywu.164.1516352457881; Fri, 19 Jan 2018 01:00:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516352457; cv=none; d=google.com; s=arc-20160816; b=wLDK0QN3P1mmikuy+s6WxaanD1/VWCwErjAq3p0e2iarE5S+EWNclSnzzS02m7mjbQ nrf8ius4441ntcHOOos++Z/ClAuIe2eI9F/F1/i3uCkoVsb6bgZ73W2BjARBf9RG6gaU GpSdR2XRSUvLHEk9ezsM6JJE8r50m/X37fp30cEvtbrtEULzzvL0Cgv0A/q778ArmiFp fy5bU5VijxtvC2jXTDiGZyCvRfjb7OfrfyJ7W/1I9NIROCuoLUWjLJqrb8HzHoI5mWwx WtXVSxLR7njExT4/ZN3KRs3GFEIgwRmqTtYvddsENXYxwUReT5fH+btxV9q8a7uCNX9A tuDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:user-agent:references :in-reply-to:message-id:date:to:from:arc-authentication-results; bh=wTFEK1rP/PsAYVE6lDn8t3/G3KRjFANptpcyQJugdR4=; b=YWI4nsYRSSRinbGm5WikFDAgnOIofA9cSJPSnDpQGONd+MzLFrasADv7o/zYzZzBP1 ROdOtGkOdvrWf7OURJcAlI1uVm0Zyg9uQNdBn4o2uvtkhM5I1A14Zxhge4t/R0oyucPZ zMPPTFV8vjmzs1RvCDMq74vDrJQBj9mdEGohBqIYVrTqoR6swOQ5GGH8wxZu5ns0e9Sd M3Uvu0vtwJBgo9wsgsGPWfLiu4vAHgH+JPkjEtVlzDWpUvs2yLBASAU5FW8WNKZbXrhM A1iNvKCX5HBclJX1LaDi2oG52BCAGBl+QHKi/ChSMHNC0l6QzlH7ADCeZSvM69Ip5TSQ qE4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id o196si924949ywd.411.2018.01.19.01.00.57 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 19 Jan 2018 01:00:57 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:35686 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecSXh-0006DP-BB for patch@linaro.org; Fri, 19 Jan 2018 04:00:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecSHN-0001GM-4m for qemu-devel@nongnu.org; Fri, 19 Jan 2018 03:44:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecSHI-0005Ms-8r for qemu-devel@nongnu.org; Fri, 19 Jan 2018 03:44:05 -0500 Received: from mail.ispras.ru ([83.149.199.45]:53668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecSHI-0005Mg-1f for qemu-devel@nongnu.org; Fri, 19 Jan 2018 03:44:00 -0500 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id 9FC3B54006A; Fri, 19 Jan 2018 11:43:58 +0300 (MSK) From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Fri, 19 Jan 2018 11:43:59 +0300 Message-ID: <20180119084359.7100.2236.stgit@pasha-VirtualBox> In-Reply-To: <20180119084235.7100.98318.stgit@pasha-VirtualBox> References: <20180119084235.7100.98318.stgit@pasha-VirtualBox> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [RFC PATCH v4 11/23] target/arm/arm-powertctl: drop BQL assertions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, pavel.dovgaluk@ispras.ru, mst@redhat.com, jasowang@redhat.com, quintela@redhat.com, zuban32s@gmail.com, maria.klimushenkova@ispras.ru, dovgaluk@ispras.ru, kraxel@redhat.com, boost.lists@gmail.com, pbonzini@redhat.com, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée The powerctl code is run in the context of the vCPU changing power state. It does not need the BQL to protect its changes. Signed-off-by: Alex Bennée --- target/arm/arm-powerctl.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/target/arm/arm-powerctl.c b/target/arm/arm-powerctl.c index 25207cb..9661a59 100644 --- a/target/arm/arm-powerctl.c +++ b/target/arm/arm-powerctl.c @@ -124,7 +124,6 @@ static void arm_set_cpu_on_async_work(CPUState *target_cpu_state, g_free(info); /* Finally set the power status */ - assert(qemu_mutex_iothread_locked()); target_cpu->power_state = PSCI_ON; } @@ -135,8 +134,6 @@ int arm_set_cpu_on(uint64_t cpuid, uint64_t entry, uint64_t context_id, ARMCPU *target_cpu; struct CpuOnInfo *info; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 " (EL %d, %s) @ 0x%" PRIx64 " with R0 = 0x%" PRIx64 "\n", cpuid, target_el, target_aa64 ? "aarch64" : "aarch32", entry, context_id); @@ -227,7 +224,6 @@ static void arm_set_cpu_off_async_work(CPUState *target_cpu_state, { ARMCPU *target_cpu = ARM_CPU(target_cpu_state); - assert(qemu_mutex_iothread_locked()); target_cpu->power_state = PSCI_OFF; target_cpu_state->halted = 1; target_cpu_state->exception_index = EXCP_HLT; @@ -238,8 +234,6 @@ int arm_set_cpu_off(uint64_t cpuid) CPUState *target_cpu_state; ARMCPU *target_cpu; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 "\n", cpuid); /* change to the cpu we are powering up */ @@ -274,8 +268,6 @@ int arm_reset_cpu(uint64_t cpuid) CPUState *target_cpu_state; ARMCPU *target_cpu; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 "\n", cpuid); /* change to the cpu we are resetting */