From patchwork Tue Jan 23 08:54:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pavel Dovgalyuk X-Patchwork-Id: 125479 Delivered-To: patch@linaro.org Received: by 10.46.66.141 with SMTP id h13csp1630936ljf; Tue, 23 Jan 2018 00:59:39 -0800 (PST) X-Google-Smtp-Source: AH8x224VtL9yd++YXEhG2VTd+5t71TL4TgEGRe+jUpaNi3eKv9XHUb9V6pZd/Dm7eKxLhvK2QmkS X-Received: by 10.13.219.22 with SMTP id d22mr1664392ywe.93.1516697978954; Tue, 23 Jan 2018 00:59:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516697978; cv=none; d=google.com; s=arc-20160816; b=B/pqn6TfBUGhIdOFYRgNIMl3uf8edj3TFU/OvLSiAXlsCwmroJF6fUbzVaESGXtj3D evpju6zCc4fshyfGg+XG8W3ozc+GpPG3OiaCcqlBaMnk2/5FoVWeUeLgTgj7QHgPYJwo Ge/4HFMy07D1iCQihr6mMImPePTEszfigZQvkiD7wpfSAIxlzseI6YXcAFi7KiiTqWVC i+z5kZC1+24B3wc7Jah4vcYOCtJLQh28GX2ZamI3aR38/m1pETnL/Z6AA8bop3BBQgkz 4Ra0Ku+0TEFVPBqzMm8/vr335S1ezrEqhXu37b6rA9EU3AFgtY3VsPODzUvvYWnTRHeG 42iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:user-agent:references :in-reply-to:message-id:date:to:from:arc-authentication-results; bh=wTFEK1rP/PsAYVE6lDn8t3/G3KRjFANptpcyQJugdR4=; b=D+PBApuq6jztWGNDAiMrKu/n8ZXLwIIX5w6cnoN6EB36CSs6IVegnj/WHmHw0jk5Qt 88HJ2qPibaOT7gWa64ONOh28bId6+gq8nqzH/Yhbg50vjbBFDU5Hn0vQqEU3LX64HFyD lMQ65w9sIED6uCYYFHovKCQe4UrIN5DCuVtlq/biiqm+GkWK5WHFNu21cvQkklqdOGj+ wHKK61xkv4QB/VzJvAvjJMQQmry/Jc4StaopIfXNMKreEfVklug8mVq2RIfV9xLxwqq/ DWuHws+V4JSG4HY+01Epga0RfCwIxzHMhaF68rD/0jdQS42PTsOIBB0ybH5oPQLw+D86 obFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v191si1427472ybv.406.2018.01.23.00.59.38 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 23 Jan 2018 00:59:38 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:45936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eduQc-0006GG-9j for patch@linaro.org; Tue, 23 Jan 2018 03:59:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eduLS-0001eA-U0 for qemu-devel@nongnu.org; Tue, 23 Jan 2018 03:54:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eduLP-0008Rr-T9 for qemu-devel@nongnu.org; Tue, 23 Jan 2018 03:54:19 -0500 Received: from mail.ispras.ru ([83.149.199.45]:57176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eduLP-0008Rc-Lr for qemu-devel@nongnu.org; Tue, 23 Jan 2018 03:54:15 -0500 Received: from [127.0.1.1] (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id A542454006A; Tue, 23 Jan 2018 11:54:14 +0300 (MSK) From: Pavel Dovgalyuk To: qemu-devel@nongnu.org Date: Tue, 23 Jan 2018 11:54:15 +0300 Message-ID: <20180123085415.3419.37058.stgit@pasha-VirtualBox> In-Reply-To: <20180123085319.3419.97865.stgit@pasha-VirtualBox> References: <20180123085319.3419.97865.stgit@pasha-VirtualBox> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 83.149.199.45 Subject: [Qemu-devel] [RFC PATCH v5 10/24] target/arm/arm-powertctl: drop BQL assertions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, pavel.dovgaluk@ispras.ru, mst@redhat.com, jasowang@redhat.com, quintela@redhat.com, zuban32s@gmail.com, maria.klimushenkova@ispras.ru, dovgaluk@ispras.ru, kraxel@redhat.com, boost.lists@gmail.com, pbonzini@redhat.com, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée The powerctl code is run in the context of the vCPU changing power state. It does not need the BQL to protect its changes. Signed-off-by: Alex Bennée --- target/arm/arm-powerctl.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/target/arm/arm-powerctl.c b/target/arm/arm-powerctl.c index 25207cb..9661a59 100644 --- a/target/arm/arm-powerctl.c +++ b/target/arm/arm-powerctl.c @@ -124,7 +124,6 @@ static void arm_set_cpu_on_async_work(CPUState *target_cpu_state, g_free(info); /* Finally set the power status */ - assert(qemu_mutex_iothread_locked()); target_cpu->power_state = PSCI_ON; } @@ -135,8 +134,6 @@ int arm_set_cpu_on(uint64_t cpuid, uint64_t entry, uint64_t context_id, ARMCPU *target_cpu; struct CpuOnInfo *info; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 " (EL %d, %s) @ 0x%" PRIx64 " with R0 = 0x%" PRIx64 "\n", cpuid, target_el, target_aa64 ? "aarch64" : "aarch32", entry, context_id); @@ -227,7 +224,6 @@ static void arm_set_cpu_off_async_work(CPUState *target_cpu_state, { ARMCPU *target_cpu = ARM_CPU(target_cpu_state); - assert(qemu_mutex_iothread_locked()); target_cpu->power_state = PSCI_OFF; target_cpu_state->halted = 1; target_cpu_state->exception_index = EXCP_HLT; @@ -238,8 +234,6 @@ int arm_set_cpu_off(uint64_t cpuid) CPUState *target_cpu_state; ARMCPU *target_cpu; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 "\n", cpuid); /* change to the cpu we are powering up */ @@ -274,8 +268,6 @@ int arm_reset_cpu(uint64_t cpuid) CPUState *target_cpu_state; ARMCPU *target_cpu; - assert(qemu_mutex_iothread_locked()); - DPRINTF("cpu %" PRId64 "\n", cpuid); /* change to the cpu we are resetting */