From patchwork Wed Jan 24 23:25:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 125738 Delivered-To: patch@linaro.org Received: by 10.46.66.141 with SMTP id h13csp737660ljf; Wed, 24 Jan 2018 15:42:46 -0800 (PST) X-Google-Smtp-Source: AH8x224oYVL7Gg5X86m28aiP/BvgNtd1jLZcLqMRcVxEPIFBCbTAj14L2/pTexyjiN1O6VIpGBYf X-Received: by 10.129.161.202 with SMTP id y193mr7141034ywg.228.1516837366264; Wed, 24 Jan 2018 15:42:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516837366; cv=none; d=google.com; s=arc-20160816; b=F6teW/0dClJl9zzyVhewy3gOrN+QnUs81sxfaRZpV2auKK82IHKOXLWXEmHFPFYvzR 1f4n38RNjoWueBZYcMvtC43ZFzbnc3GL+n01d82yqeW+WlM/s4wqR3K1MlQd93ufz+RN bFvjtfGqoFpJ7wlQ+QEKMo7lKsqn43gbrwyVo0aOFdXPKvllUL44I9oLsgS3X1qqlQjK 4hTdpUv/kl15SRhmj64gCwCK8Q12bGvGblbCVkf9CSvuYs2PaGS1HmN87Qw01/Gbzov0 cwFA+yoiL+gm9Wd+GB/fMJMKVFVKjRx/gRHw5ue0hNTbiX3i8r1kkgCwTc5wO9JhYBwE Yfzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=R7Enyxbsmc64EfsW5JScMt9UKiAW8/F8PsYnC3AJCUE=; b=rA8y2oGW3VTTUVJn6rFaFHGwWQkm4HRmlR35lLDpI60SboXa617sy64LLXMiot79aj VLNVEjTrcL/blD2LK3VHHcRDPAGC6LMwSGXjcUMVOn4bhQr+OUbzqF/JKvjx8q6gOtK4 pLBEaDdDixTuIVZKfo9ZEtZhvx9uXv2BwgTLGhXIJ6joT4+TBFV6f6ISKuUnk0YZxF3K R+fQR/G2OOjj/Lr97YGjpj2131gqH5kK8CftG+ngGKDIRBC7MsGJztNOVfgK63W65mTm aRr8Q2uY73ljDuqH9DD4QeTgR4stxjQEtoz/IQ4dntxhtLx1+XDaPWzJa0LAypCdlwCD H04A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=K1oZ4V/k; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id m78si3071215ybm.322.2018.01.24.15.42.46 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 24 Jan 2018 15:42:46 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=K1oZ4V/k; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:54556 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeUgn-0000OO-KN for patch@linaro.org; Wed, 24 Jan 2018 18:42:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeURU-0004dh-9H for qemu-devel@nongnu.org; Wed, 24 Jan 2018 18:26:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeURQ-0001jN-4f for qemu-devel@nongnu.org; Wed, 24 Jan 2018 18:26:56 -0500 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:36606) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eeURP-0001iY-V8 for qemu-devel@nongnu.org; Wed, 24 Jan 2018 18:26:52 -0500 Received: by mail-pg0-x244.google.com with SMTP id k68so3819217pga.3 for ; Wed, 24 Jan 2018 15:26:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=R7Enyxbsmc64EfsW5JScMt9UKiAW8/F8PsYnC3AJCUE=; b=K1oZ4V/kJgvKM3arUoY8YawsoC8lo9rU7/lj+OZicc+Pc/o3b9xhU4uDnGD9X9f7Wj n7MtB4VPjsaUyXddnukAzk3dvEwvD6YMDMzhF25QV6SFyHov2AnZk0e357Xp3Q1tl3I7 rj13zKTb0duXtPk9xfctJHn2EGd9lPLI/pqmE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=R7Enyxbsmc64EfsW5JScMt9UKiAW8/F8PsYnC3AJCUE=; b=hHDMLyiSWTVc5fVByq1eXYa/b69fSe4lzxHevlzti0KEumLKqTUMLuBL43hOTjRFow RIJ3uXp+TFKBIfmS7/vsuXZJMgNoxYpGhO26ZDjNbyW54H5c0stm3Slfo/wFqpTOnnVK EckyKnNWNZGg01yiANR5/7w3yjvKUJsX16oxRqbu5mDWHp0gCvWUmOkIAOmnJBmtN/dB C9wuVr/nSRXloXkcg0LgcaOsV536xbkmKt96NHsLUXmbOMNxNgP6qiBI+rOkLsXWTmcT g/OsShxlpeTaq/cybiXpiwFBq4q25d35rES9Gci51Wrb5lXJwpe9xQWLplems94zADM2 tSBg== X-Gm-Message-State: AKwxytcHoAk+mnjJt22P/HO1LZh2kW2UuGJX+ZB8jpD9sXVPe/E94E9G 4kDTgqQsxgCSTYY/ib/B+YHEpb90wc8= X-Received: by 2002:a17:902:229:: with SMTP id 38-v6mr7694467plc.429.1516836410514; Wed, 24 Jan 2018 15:26:50 -0800 (PST) Received: from cloudburst.twiddle.net (174-21-6-47.tukw.qwest.net. [174.21.6.47]) by smtp.gmail.com with ESMTPSA id z19sm9760028pfh.185.2018.01.24.15.26.49 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jan 2018 15:26:49 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 24 Jan 2018 15:25:55 -0800 Message-Id: <20180124232625.30105-16-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180124232625.30105-1-richard.henderson@linaro.org> References: <20180124232625.30105-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PATCH v3 15/45] target/hppa: Avoid privilege level decrease during branches X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" These instructions force the destination privilege level of the branch destination to be no higher than current. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 52 ++++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 47 insertions(+), 5 deletions(-) -- 2.14.3 diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 6be9e0c3ff..4a69f05a91 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -1862,6 +1862,40 @@ static DisasJumpType do_ibranch(DisasContext *ctx, TCGv_reg dest, return DISAS_NEXT; } +/* Implement + * if (IAOQ_Front{30..31} < GR[b]{30..31}) + * IAOQ_Next{30..31} ← GR[b]{30..31}; + * else + * IAOQ_Next{30..31} ← IAOQ_Front{30..31}; + * which keeps the privilege level from being increased. + */ +static TCGv_reg do_ibranch_priv(DisasContext *ctx, TCGv_reg offset) +{ +#ifdef CONFIG_USER_ONLY + return offset; +#else + TCGv_reg dest; + switch (ctx->privilege) { + case 0: + /* Privilege 0 is maximum and is allowed to decrease. */ + return offset; + case 3: + /* Privilege 3 is minimum and is never allowed increase. */ + dest = get_temp(ctx); + tcg_gen_ori_reg(dest, offset, 3); + break; + default: + dest = tcg_temp_new(); + tcg_gen_andi_reg(dest, offset, -4); + tcg_gen_ori_reg(dest, dest, ctx->privilege); + tcg_gen_movcond_reg(TCG_COND_GTU, dest, dest, offset, dest, offset); + tcg_temp_free(dest); + break; + } + return dest; +#endif +} + #ifdef CONFIG_USER_ONLY /* On Linux, page zero is normally marked execute only + gateway. Therefore normal read or write is supposed to fail, but specific @@ -3441,6 +3475,7 @@ static DisasJumpType trans_be(DisasContext *ctx, uint32_t insn, bool is_l) unsigned n = extract32(insn, 1, 1); unsigned b = extract32(insn, 21, 5); target_sreg disp = assemble_17(insn); + TCGv_reg tmp; /* unsigned s = low_uextract(insn, 13, 3); */ /* ??? It seems like there should be a good way of using @@ -3449,16 +3484,19 @@ static DisasJumpType trans_be(DisasContext *ctx, uint32_t insn, bool is_l) manage along side branch delay slots. Therefore we handle entry into the gateway page via absolute address. */ +#ifdef CONFIG_USER_ONLY /* Since we don't implement spaces, just branch. Do notice the special case of "be disp(*,r0)" using a direct branch to disp, so that we can goto_tb to the TB containing the syscall. */ if (b == 0) { return do_dbranch(ctx, disp, is_l ? 31 : 0, n); - } else { - TCGv_reg tmp = get_temp(ctx); - tcg_gen_addi_reg(tmp, load_gpr(ctx, b), disp); - return do_ibranch(ctx, tmp, is_l ? 31 : 0, n); } +#endif + + tmp = get_temp(ctx); + tcg_gen_addi_reg(tmp, load_gpr(ctx, b), disp); + tmp = do_ibranch_priv(ctx, tmp); + return do_ibranch(ctx, tmp, is_l ? 31 : 0, n); } static DisasJumpType trans_bl(DisasContext *ctx, uint32_t insn, @@ -3490,6 +3528,7 @@ static DisasJumpType trans_blr(DisasContext *ctx, uint32_t insn, tcg_gen_shli_reg(tmp, load_gpr(ctx, rx), 3); tcg_gen_addi_reg(tmp, tmp, ctx->iaoq_f + 8); + /* The computation here never changes privilege level. */ return do_ibranch(ctx, tmp, link, n); } @@ -3508,6 +3547,7 @@ static DisasJumpType trans_bv(DisasContext *ctx, uint32_t insn, tcg_gen_shli_reg(dest, load_gpr(ctx, rx), 3); tcg_gen_add_reg(dest, dest, load_gpr(ctx, rb)); } + dest = do_ibranch_priv(ctx, dest); return do_ibranch(ctx, dest, 0, n); } @@ -3517,8 +3557,10 @@ static DisasJumpType trans_bve(DisasContext *ctx, uint32_t insn, unsigned n = extract32(insn, 1, 1); unsigned rb = extract32(insn, 21, 5); unsigned link = extract32(insn, 13, 1) ? 2 : 0; + TCGv_reg dest; - return do_ibranch(ctx, load_gpr(ctx, rb), link, n); + dest = do_ibranch_priv(ctx, load_gpr(ctx, rb)); + return do_ibranch(ctx, dest, link, n); } static const DisasInsn table_branch[] = {