From patchwork Sun Jan 28 23:15:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 126129 Delivered-To: patch@linaro.org Received: by 10.46.84.92 with SMTP id y28csp1989284ljd; Sun, 28 Jan 2018 15:49:34 -0800 (PST) X-Google-Smtp-Source: AH8x224qhBgr20AOw7aVvxJywp2QQ1/HKlgVS41NU39By6TjYRQiPsjo01VKHYo1/8KV6Ovqqngf X-Received: by 10.37.59.75 with SMTP id i72mr4112176yba.420.1517183374720; Sun, 28 Jan 2018 15:49:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517183374; cv=none; d=google.com; s=arc-20160816; b=kBC6C97pVSZ1KQASSVp1/EKLx/FS+K00vpdRqWfowbOpORBwn+P08g+mhpVg/uhFIL vjg5PuoFTOiL1fdS/B25TDahuzp/CNV1/XGdGkkCjj56noJ4CXCZZ+4P9J70vFLpW/I1 iBNNT+m7wzwl0QFZBDFPT00wWsLOTKfk7ED7HjlwffH18FFJ6WPqYsSRIYOXkx7GoioF U9uCNiXAm1j+ZHzoWa/f85Kd3wlQgEDlz71tUbLqkdW0K6RS0LqTQy6yacYuIOj4HPQh YNO1ijjNAQjIi12+ePYtqpWsEGWjOIJRGDyibGiS2i4kq1IN19RMjCjfB9kLfsEBxjzV pxwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=SWeo8TZ80j7KBw5h84Jj3RhyNZF4F9nvYkElb1G8SKA=; b=JOp6sDnct48wmCCxZ5EYFnFsSGom4S4UYZuP9voomS9q77rjWbkyynQJNv8XOaDxiD SrBcTXn1tYxwGjPaTPQOBtlZYqg+X01UrV3ATmAY8ZrORVRpyNQDlC+FwSC4gm1u7M6O LSZEuyMWeLDAmXv3/msyFn/KJCdegWoF1mgQoGYTPtcL6QZC+LTFYLDHrnkNOB0jgXAs rBJc7ZrEEWBC/4Cy3605Sn1K4p1QUFqbGaAh1XIM9PxuSI3dSsXU6l5/zEa4zTnUzRis eK4mIie/0szvCeaUXdk4EuHAVnx9Y717Aj7y4lBdnij0QWfjJnABFMtybup8ro+cjA+k jx7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Xc9S+8rv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id t16si1828450ybb.654.2018.01.28.15.49.34 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 28 Jan 2018 15:49:34 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Xc9S+8rv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:45394 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efwha-0003fD-3I for patch@linaro.org; Sun, 28 Jan 2018 18:49:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efwBT-00036h-TJ for qemu-devel@nongnu.org; Sun, 28 Jan 2018 18:16:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efwBR-0000J4-Fi for qemu-devel@nongnu.org; Sun, 28 Jan 2018 18:16:23 -0500 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:45535) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1efwBR-0000IC-96 for qemu-devel@nongnu.org; Sun, 28 Jan 2018 18:16:21 -0500 Received: by mail-pf0-x242.google.com with SMTP id a88so3251278pfe.12 for ; Sun, 28 Jan 2018 15:16:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SWeo8TZ80j7KBw5h84Jj3RhyNZF4F9nvYkElb1G8SKA=; b=Xc9S+8rv6hhPHPypEgoFN0QUSba6I/dYEFIbPAf2ocJZS1puzvwDXT73glTUy3W3uT iDCK82Xu0/M0ukdakoFga7OX5Swjh7YaXS+wFHbMy7jDhMC/AuDg17w5oB9oD6+4qVnk twKUCmf8tG1k2HSnHcKs4huFbCIJfJLlPtNw0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SWeo8TZ80j7KBw5h84Jj3RhyNZF4F9nvYkElb1G8SKA=; b=NZ1FlrHgfZuS5pDTUijSJBeIdCJv5WjAQ3ckKrtceIqD1t191DeLkDCuvZlW3kzdg/ nkcDBLLFYCwUpCVUHMzUzJtUzp1ovq2l1a2PdcIgLFTK+j2NJEX/oiJBeAGWCGMVI4Rx UW/muGgOBKqEbp85GDJ0L91QWKNaqj2Q4UyCI/cdxwvY5eKe09sbQI5S+7ezH7CopIcX b8zv/vOaQ8uUGdzL63micJ37dHTOumctKTAY/yZGWhBxl/tPoDJLukqWGPpXteizNyC1 7f/3aHvBjLRoE8UNXYPjp4IiMXgaeH2wLnx31MK8eJHxJSoDWwuLHYUSsUifWn73Vfnk /W1Q== X-Gm-Message-State: AKwxytcQeggJx/z9lGf3Cp+mBINuQMLsOTT+D8qM5VLIq/Eo8uIMlEcz ThFF/SaFdjGsSDaXg85nj+FJf376faM= X-Received: by 2002:a17:902:9683:: with SMTP id n3-v6mr19593103plp.177.1517181380065; Sun, 28 Jan 2018 15:16:20 -0800 (PST) Received: from cloudburst.twiddle.net (174-21-6-47.tukw.qwest.net. [174.21.6.47]) by smtp.gmail.com with ESMTPSA id r27sm26949344pfj.75.2018.01.28.15.16.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Jan 2018 15:16:19 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sun, 28 Jan 2018 15:15:17 -0800 Message-Id: <20180128231528.22719-33-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180128231528.22719-1-richard.henderson@linaro.org> References: <20180128231528.22719-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::242 Subject: [Qemu-devel] [PULL v4 32/43] target/hppa: Only use EXCP_DTLB_MISS X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Unknown why this works, but if we return EXCP_ITLB_MISS we will triple-fault the first userland instruction fetch. Is it something to do with having a combined I/DTLB? Signed-off-by: Richard Henderson --- target/hppa/mem_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.14.3 diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index a34c64cc4a..08a4eb2480 100644 --- a/target/hppa/mem_helper.c +++ b/target/hppa/mem_helper.c @@ -96,7 +96,9 @@ int hppa_get_physical_address(CPUHPPAState *env, vaddr addr, int mmu_idx, if (ent == NULL || !ent->entry_valid) { phys = 0; prot = 0; - ret = (type & PAGE_EXEC ? EXCP_ITLB_MISS : EXCP_DTLB_MISS); + /* ??? Unconditionally report data tlb miss, + even if this is an instruction fetch. */ + ret = EXCP_DTLB_MISS; goto egress; }