From patchwork Fri Mar 23 18:49:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 132355 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp948498ljb; Fri, 23 Mar 2018 11:50:40 -0700 (PDT) X-Google-Smtp-Source: AG47ELtUoQHYBwPh/wdr/hoTxiNZ9L61xKfTIitx2mgqCb90rmzGZsWFuvdkI0DkiCyg/Zt4ciW5 X-Received: by 10.233.232.215 with SMTP id a206mr42757166qkg.238.1521831040691; Fri, 23 Mar 2018 11:50:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521831040; cv=none; d=google.com; s=arc-20160816; b=vboBWBVpVzIblwLHAY/x96AZA9aBLmCDECW2JbZOddw9CBurGFeQ3xC5rBNVKTnYn/ 9VarIx4qZ5JQfEqPf/x6ob9snr6SRuoDocrMJyAcET6nqqQIS6IoItm+YFIePaS1a6T6 YIYfDKFGxwZ+qXiKuqHWG5gzrFGd6zXelYuY87nU3MBk2u78OJU8fqkHaepjASqHPxyw kPZc3+kenpWf09CmnV7/CHQgwo+LHvZsHckyCLz58l1aKk5JVeMzBOZQVpN6WyXsGX6L Mri6OEZZYCUn2cW49pQQLUzY4A+CjfHsy2Fm1dIQUeP103Ogsckx2paaHL+cD00ZQnfk gBZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:arc-authentication-results; bh=y1P7/hDCaAmz8Xoavyr1CifeN3rofM6Ac3TluqWjMsI=; b=rztLa2oc4utB+a3gZF3EWW7J+lwrdyAelWg+uc0FYteQpS/4ejThNYck9flO4n9QGL fyQifrSvy92DYKNN+NpQ34Xa+1pFYE0WVebJAFdST+idhTrXh5P4U1B2lIT7uOFxfl0K SBlLZoPV6pO5q4oBk1UU7qUnKvbr/R0s2hdYovkTw8kQpew53dMp51XRh9lfTV/0KQul ptjNYHcNYlo81ZesXF0GQhnZ3HZkYhMJ9XeTCswKxjYyUE3qgOFvcbumsHw/UUj0810B B8bBi1j8K6vITqyHfwRBsa6ji0yxn5f7O0UoTdl1QKDwnXyXptNIXjM2XG5XLWPghML3 gTVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v34si1919973qtv.369.2018.03.23.11.50.40 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 23 Mar 2018 11:50:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:39367 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezRlw-00018X-3g for patch@linaro.org; Fri, 23 Mar 2018 14:50:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ezRlL-00017O-Bg for qemu-devel@nongnu.org; Fri, 23 Mar 2018 14:50:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezRlK-0004DZ-Fw for qemu-devel@nongnu.org; Fri, 23 Mar 2018 14:50:03 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:40506) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ezRlK-0004CA-9S for qemu-devel@nongnu.org; Fri, 23 Mar 2018 14:50:02 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.89) (envelope-from ) id 1ezRlI-0007e8-R0 for qemu-devel@nongnu.org; Fri, 23 Mar 2018 18:50:00 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 23 Mar 2018 18:49:50 +0000 Message-Id: <20180323184958.14252-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180323184958.14252-1-peter.maydell@linaro.org> References: <20180323184958.14252-1-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 02/10] sdhci: fix incorrect use of Error * X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Paolo Bonzini Detected by Coverity (CID 1386072, 1386073, 1386076, 1386077). local_err was unused, and this made the static analyzer unhappy. Signed-off-by: Paolo Bonzini Message-id: 20180320151355.25854-1-pbonzini@redhat.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/sd/sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.16.2 diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 1b828b104d..63c44a4ee8 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1474,7 +1474,7 @@ static void sdhci_pci_realize(PCIDevice *dev, Error **errp) Error *local_err = NULL; sdhci_initfn(s); - sdhci_common_realize(s, errp); + sdhci_common_realize(s, &local_err); if (local_err) { error_propagate(errp, local_err); return; @@ -1556,7 +1556,7 @@ static void sdhci_sysbus_realize(DeviceState *dev, Error ** errp) SysBusDevice *sbd = SYS_BUS_DEVICE(dev); Error *local_err = NULL; - sdhci_common_realize(s, errp); + sdhci_common_realize(s, &local_err); if (local_err) { error_propagate(errp, local_err); return;